Re: All updaters are broken

2023-01-03 Thread Ludovic Courtès
Hi! Hartmut Goebel skribis: > Am 03.01.23 um 10:49 schrieb Ludovic Courtès: >> I tried something different and perhaps simpler: making sure >> ‘options->update-specs’ always returns a list of , as the >> name implies, and does the right thing with manifests, -r, and -e. >> (Part of the patch

Re: All updaters are broken

2023-01-03 Thread Hartmut Goebel
Am 03.01.23 um 10:49 schrieb Ludovic Courtès: I tried something different and perhaps simpler: making sure ‘options->update-specs’ always returns a list of , as the name implies, and does the right thing with manifests, -r, and -e. (Part of the patch moves the definition before its first use.)

Re: All updaters are broken

2023-01-03 Thread Ludovic Courtès
Hello! Ricardo Wurmus skribis: > Okay. Here’s something simpler using “partition”: > > commit 96fb123832b262a3453fe1b7646758da235a343e > Author: Ricardo Wurmus > Date: Tue Jan 3 10:14:52 2023 +0100 > > WIP > > diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm > index

Re: All updaters are broken

2023-01-03 Thread Ricardo Wurmus
Hi Hartmut, > Am 02.01.23 um 20:17 schrieb Ricardo Wurmus: > > Thanks for providing the patch. For me this looks huge and hard to > maintain. > > “Hard to maintain”? How so? > > For me this double structure is hard to understand and thus to maintain. YMMV. Okay. Here’s something simpler using

Re: All updaters are broken

2023-01-02 Thread Hartmut Goebel
Am 02.01.23 um 20:17 schrieb Ricardo Wurmus: Thanks for providing the patch. For me this looks huge and hard to maintain. “Hard to maintain”? How so? For me this double structure is hard to understand and thus to maintain. YMMV. Anyhow, if you want me to implement a solution bases on your

Re: All updaters are broken

2023-01-02 Thread Ricardo Wurmus
Hartmut Goebel writes: > Hello Ricardo, > > Am 02.01.23 um 14:16 schrieb Ricardo Wurmus: >> Attached is a crude implementation of that. I just consed the lists >> together instead of returning multiple values, because the compound >> value is to be used inside the store monad where we can’t

Re: All updaters are broken

2023-01-02 Thread Hartmut Goebel
Hello Ricardo, Am 02.01.23 um 14:16 schrieb Ricardo Wurmus: Attached is a crude implementation of that. I just consed the lists together instead of returning multiple values, because the compound value is to be used inside the store monad where we can’t easily access multiple values. Thanks

Re: All updaters are broken

2023-01-02 Thread Ricardo Wurmus
Ricardo Wurmus writes: > It’s a bit messy because options->update-specs is poorly typed now. We > could also have it return a compound value (or a union type) with a list > of values and a list of values, and process the > components separately. Attached is a crude implementation of that.

Re: All updaters are broken

2023-01-02 Thread Ricardo Wurmus
Hartmut Goebel writes: > I managed working on this this evening already. Thank you for taking the time! > Am 31.12.22 um 15:27 schrieb Ricardo Wurmus: >> Commit 8aeccc6240ec45f0bc7bed655e0c8149ae4253eb seems like the problem >> here. Hartmut, can you please fix this? Otherwise I’d like to

Re: All updaters are broken

2023-01-01 Thread Hartmut Goebel
Hi Ricardo, I managed working on this this evening already. Am 31.12.22 um 15:27 schrieb Ricardo Wurmus: Commit 8aeccc6240ec45f0bc7bed655e0c8149ae4253eb seems like the problem here. Hartmut, can you please fix this? Otherwise I’d like to revert this and related commits ASAP. I fixed he

Re: All updaters are broken

2023-01-01 Thread Hartmut Goebel
Hi Ricardo, my fault, I missed running the tests again after the latest changes. I'll work on fixing this tomorrow (Monday). -- Regards Hartmut Goebel | Hartmut Goebel | h.goe...@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are

Re: All updaters are broken

2022-12-31 Thread Ricardo Wurmus
Ricardo Wurmus writes: > I haven’t seen these patches on the mailing list or the issue tracker. > Have they been reviewed? These changes also break existing tests, which > should have been run before merging. > > Let us please do better and avoid breaking the master branch by > discussing

All updaters are broken

2022-12-31 Thread Ricardo Wurmus
Hi Guix, Running “guix refresh -t cran -u” I get this error: --8<---cut here---start->8--- Backtrace: In ice-9/boot-9.scm: 1752:10 18 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _) In unknown file: 17 (apply-smob/0 #) In