Re: GNU Guix (pull?) on i686 broke after zstd grafting
On Thu, 2021-03-11 at 10:58 +0100, zimoun wrote: > Well, IMHO 1) «not durable» could mean months and 2) disabling all > the > tests for all the architectures is wrong especially when only one > test > is failing for only one architecture. I know that, I was tired yesterday and didnt want to block anyone running i686-linux or aarch64-linux/armhf-linux (it looked to fail there also?). Please fix the situation if you can, or I'll try and do it at some point but can't say when, lots of things going on now. signature.asc Description: This is a digitally signed message part
Re: GNU Guix (pull?) on i686 broke after zstd grafting
On Thu, 11 Mar 2021 at 10:40, Léo Le Bouter wrote: > On Thu, 2021-03-11 at 10:37 +0100, zimoun wrote: >> This disable the complete test suite for all the architecture. I >> have >> not look into the details but it seems better to only disable the >> offending test only the architecture affected. > > Yes it does that and it would be better not to but zstd 1.4.9 (without > disabled tests) is in core-updates and we are waiting for upstream to > fix the test-suite, this change is not durable as it's a graft for a > security update. Well, IMHO 1) «not durable» could mean months and 2) disabling all the tests for all the architectures is wrong especially when only one test is failing for only one architecture. Cheers, simon
Re: GNU Guix (pull?) on i686 broke after zstd grafting
On Thu, 2021-03-11 at 10:37 +0100, zimoun wrote: > This disable the complete test suite for all the architecture. I > have > not look into the details but it seems better to only disable the > offending test only the architecture affected. Yes it does that and it would be better not to but zstd 1.4.9 (without disabled tests) is in core-updates and we are waiting for upstream to fix the test-suite, this change is not durable as it's a graft for a security update. signature.asc Description: This is a digitally signed message part
Re: GNU Guix (pull?) on i686 broke after zstd grafting
Hi, On Thu, 11 Mar 2021 at 03:11, Léo Le Bouter wrote: > On Wed, 2021-03-10 at 11:37 +0100, Ludovic Courtès wrote: >> So I think there’s a genuine bug here. Could you take a look? At >> worst, we should skip the offending test on i686 (and perhaps >> ARMv7?). > > I pushed 2bcfb944bdd2f476ef8d34802fed436e4fdda0ab which disables tests > entirely in the graft. This disable the complete test suite for all the architecture. I have not look into the details but it seems better to only disable the offending test only the architecture affected. Cheers, simon
Re: GNU Guix (pull?) on i686 broke after zstd grafting
On Wed, 2021-03-10 at 11:37 +0100, Ludovic Courtès wrote: > So I think there’s a genuine bug here. Could you take a look? At > worst, we should skip the offending test on i686 (and perhaps > ARMv7?). I pushed 2bcfb944bdd2f476ef8d34802fed436e4fdda0ab which disables tests entirely in the graft. At least this fixes the issue, if anyone wants to still enable tests, feel free, no energy for that myself now. This will do while we wait for an upstream patch. Léo signature.asc Description: This is a digitally signed message part
Re: GNU Guix (pull?) on i686 broke after zstd grafting
On Wed, 2021-03-10 at 11:37 +0100, Ludovic Courtès wrote: > Hi Léo, Hi Ludo! > So I think there’s a genuine bug here. Could you take a look? At > worst, we should skip the offending test on i686 (and perhaps > ARMv7?). I reported upstream and I got an answer, waiting for fix but also we could do something based on their comment: > So now that we have plausible explanation, what can be done about it > ? > > - Ignore this test. It's a just test error. Disable it. > - Change the test, so that it passes. For example, use a fixed nb of > threads, like -T4. > - Update the rule regulating -T0, determining automatically a nb of > threads based on present nb of cores. Make it conditional for 32-bit > systems, select a limit for this case (slightly more complex, will > take time). > - Update the thread-pool policy to allocate new threads only when > needed, instead of up front (definitely more complex, will take even > more time). I am very tired now however, also not sure how to disable individual tests there. Léo signature.asc Description: This is a digitally signed message part
Re: GNU Guix (pull?) on i686 broke after zstd grafting
Hi Léo, Léo Le Bouter skribis: > After commit: > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6f873731a030dd7ecbd8a5e756b38b26306f6966 > > This happened: > https://ci.guix.gnu.org/build/369538/details > > I made the commit, and not sure what to do here. > > The test suite seems to fail on i686..? I’ve retried this i686-linux build and it seems to fail consistently: --8<---cut here---start->8--- *** zstd command line interface 32-bits v1.4.9, by Yann Collet *** (L3) Buffered : 0 MB - Consumed : 0 MB - Compressed : 0 MB => 0.00% roundTripTest: datagen -g8M | zstd -v19 -T0 --long | zstd -d19 -T0 --long *** zstd command line interface 32-bits v1.4.9, by Yann Collet *** Note: 48 physical core(s) detected zstd: error 11 : Allocation error : not enough memory zstd: /*stdin*\: unexpected end of file Files tmp1 and tmp2 differ make[1]: *** [Makefile:329: test-zstd] Error 1 make[1]: Leaving directory '/tmp/guix-build-zstd-1.4.9.drv-0/zstd-1.4.9/tests' make: *** [Makefile:90: shortest] Error 2 Test suite failed, dumping logs. command "make" "check" "-j" "4" "CC=gcc" "PREFIX=/gnu/store/krx4mfj2yyg099kr1bj9pg0rs03fnymb-zstd-1.4.9" "LIBDIR=/gnu/store/la177xpxz00biapfhrrnx51pf1d9r8r3-zstd-1.4.9-lib/lib" "INCLUDEDIR=/gnu/store/la177xpxz00biapfhrrnx51pf1d9r8r3-zstd-1.4.9-lib/include" "HAVE_LZMA=0" "HAVE_LZ4=0" "HAVE_ZLIB=0" failed with status 2 builder for `/gnu/store/w0lbczib88vv83id42i2dx05v84fmpbv-zstd-1.4.9.drv' failed with exit code 1 build of /gnu/store/w0lbczib88vv83id42i2dx05v84fmpbv-zstd-1.4.9.drv failed --8<---cut here---end--->8--- So I think there’s a genuine bug here. Could you take a look? At worst, we should skip the offending test on i686 (and perhaps ARMv7?). Thanks, Ludo’.
Re: GNU Guix (pull?) on i686 broke after zstd grafting
On Sat, 2021-03-06 at 06:09 +0100, Léo Le Bouter wrote: > Hello! > > After commit: > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6f873731a030dd7ecbd8a5e756b38b26306f6966 > > This happened: > https://ci.guix.gnu.org/build/369538/details > > I made the commit, and not sure what to do here. > > The test suite seems to fail on i686..? > > Sorry for any inconvenience caused. > > Thank you I think it is an error from ci.guix.gnu.org workers actually running out of memory because: guix build --system=i686-linux --no-grafts zstd@1.4.9 succeeded locally for me. So please restart the job, scared me a bit there. signature.asc Description: This is a digitally signed message part
GNU Guix (pull?) on i686 broke after zstd grafting
Hello! After commit: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6f873731a030dd7ecbd8a5e756b38b26306f6966 This happened: https://ci.guix.gnu.org/build/369538/details I made the commit, and not sure what to do here. The test suite seems to fail on i686..? Sorry for any inconvenience caused. Thank you signature.asc Description: This is a digitally signed message part
