Re: [PATCH 2/2] gnu: Add emacs-evil.

2016-10-13 Thread Alex Kost
ng0 (2016-10-12 23:00 +) wrote:

> * gnu/packages/emacs.scm (emacs-evil): New variable.
> ---
>  gnu/packages/emacs.scm | 24 
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index f04b71d..7ea7035 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -2981,6 +2981,30 @@ Lua programing language}.")
>  news items, openrc and runscripts.")
>  (license license:gpl2+)))
>  
> +(define-public emacs-evil
> +  (package
> +(name "emacs-evil")
> +(version "20160827.1510")
> +(source
> + (origin
> +   (method url-fetch)
> +   (uri (string-append "https://melpa.org/packages/evil-;
> +   version ".tar"))

We don't use tarballs from MELPA.  The problem is: when there will be a
new commit in the upstream repo, the tarball on melpa will be changed,
and the old source will be removed, and this package could not be built
anymore.  So I replaced it with the tarball from bitbucket.

> +   (sha256
> +(base32
> + "1lq8b3yf4z6h0pgy80jk22q922d4l4pazbcrfyqyq9rfl34g8jvi"
> +(build-system emacs-build-system)
> +(inputs

These should be 'propagated-inputs'.

> + `(("emacs-undo-tree" ,emacs-undo-tree)
> +   ("emacs-goto-chg" ,emacs-goto-chg)))
> +(home-page "https://bitbucket.com/lyro/evil;)
> +(synopsis "Extensible Vi layer for Emacs.")

"guix lint" tells about this period ---^

> +(description
> + "Evil is an extensible vi layer for Emacs.  It emulates the
> +main features of Vim, and provides facilities for writing custom
> +extensions.")
> +(license license:gpl3+)))
> +
>  (define-public emacs-goto-chg
>(package
>  (name "emacs-goto-chg")

Applied as 2edbfbf58843f20114d555445d38f6e0ffd1f4e7, thanks!

-- 
Alex



[PATCH 2/2] gnu: Add emacs-evil.

2016-10-12 Thread ng0
* gnu/packages/emacs.scm (emacs-evil): New variable.
---
 gnu/packages/emacs.scm | 24 
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index f04b71d..7ea7035 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2981,6 +2981,30 @@ Lua programing language}.")
 news items, openrc and runscripts.")
 (license license:gpl2+)))
 
+(define-public emacs-evil
+  (package
+(name "emacs-evil")
+(version "20160827.1510")
+(source
+ (origin
+   (method url-fetch)
+   (uri (string-append "https://melpa.org/packages/evil-;
+   version ".tar"))
+   (sha256
+(base32
+ "1lq8b3yf4z6h0pgy80jk22q922d4l4pazbcrfyqyq9rfl34g8jvi"
+(build-system emacs-build-system)
+(inputs
+ `(("emacs-undo-tree" ,emacs-undo-tree)
+   ("emacs-goto-chg" ,emacs-goto-chg)))
+(home-page "https://bitbucket.com/lyro/evil;)
+(synopsis "Extensible Vi layer for Emacs.")
+(description
+ "Evil is an extensible vi layer for Emacs.  It emulates the
+main features of Vim, and provides facilities for writing custom
+extensions.")
+(license license:gpl3+)))
+
 (define-public emacs-goto-chg
   (package
 (name "emacs-goto-chg")
-- 
2.10.1