Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-24 Thread Christopher Baines
Canan Talayhan writes: > Thanks for your quick response. It helps a lot to me. But still, I > have some confusion about the reproduction steps. As I understand it, > I can reproduce the slow query just using the pure SQL queries without > touching the code for now, right? > > Please find my

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-24 Thread Canan Talayhan
Thanks for your quick response. It helps a lot to me. But still, I have some confusion about the reproduction steps. As I understand it, I can reproduce the slow query just using the pure SQL queries without touching the code for now, right? Please find my steps below: 1. CREATE TEMPORARY TABLE

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-24 Thread Christopher Baines
Christopher Baines writes: > The approach I'd recommend is, make yourself a realistic > temp_package_metadata table by populating it with all the > package_metadata entries for a single revision already in your local > database. Then construct and try the slow query, and see how long it >

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-23 Thread Christopher Baines
Canan Talayhan writes: > It seems after testing lots of pages this one escaped me since I only > tested the working case. > > Please find the quick fix in the link below. > https://pastebin.ubuntu.com/p/s7tWyPHZ8F/ Great, that fixes the issue with the revision comparison page. > I'm looking

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-23 Thread Canan Talayhan
It seems after testing lots of pages this one escaped me since I only tested the working case. Please find the quick fix in the link below. https://pastebin.ubuntu.com/p/s7tWyPHZ8F/ I'm looking forward to making another contribution. Could you please review it as soon as possible? Thanks, Canan

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-22 Thread Christopher Baines
Canan Talayhan writes: > I've missed it unintentionally. I've not touched the "@" sign this time. :) > >>> + (define page-header "Comparing") > >> + > >> (layout > >> + #:title > >> + (string-append page-header " " (string-take base-commit 8) " and " > >> + (string-take

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-21 Thread Canan Talayhan
I've missed it unintentionally. I've not touched the "@" sign this time. :) >> + (define page-header "Comparing") >> + >> (layout >> + #:title >> + (string-append page-header " " (string-take base-commit 8) " and " >> + (string-take target-commit 8)) >>#:body >>

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-19 Thread Christopher Baines
Canan Talayhan writes: > Thanks for your quick response. > >>Why's the @ being removed here? > It interprets like an HTML code when I use the page-header like > `,page-header, so I removed it. According to your comment, I reverted > to the original version. > > " 'GET repository..." which

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-18 Thread Canan Talayhan
Thanks for your quick response. >Why's the @ being removed here? It interprets like an HTML code when I use the page-header like `,page-header, so I removed it. According to your comment, I reverted to the original version. " 'GET repository..." which includes package/package-name in the URL has

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-18 Thread Christopher Baines
Canan Talayhan writes: > I've updated the patch that contains all the suggestions. I think the patch > is ready to merge. > > One thing that I would like to ask you about the package and package-name > in web/repository/controller.scm. > > When I test the URL below I'm getting this error. ( >

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-18 Thread Canan Talayhan
Hi Chris, I've updated the patch that contains all the suggestions. I think the patch is ready to merge. One thing that I would like to ask you about the package and package-name in web/repository/controller.scm. When I test the URL below I'm getting this error. (

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-16 Thread Christopher Baines
Canan Talayhan writes: > After your suggestions, I've fixed the patch. But for the revision > part, I have a question. You said "I'd put "Channel News Entries" > first, then the Revision bit second." There are so many titles like > this structure in Revision views. > > For example : > ->System

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-16 Thread Canan Talayhan
Hi again, @Chris After your suggestions, I've fixed the patch. But for the revision part, I have a question. You said "I'd put "Channel News Entries" first, then the Revision bit second." There are so many titles like this structure in Revision views. For example : ->System tests Revision

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-15 Thread Christopher Baines
Canan Talayhan writes: > Hi team, > > Thanks for your help. > > @Chris > After all the modifications that I've made according to your comments, > I've created the latest version of my patch. > Could you please review the patch attached and share your ideas? > > Please note that a few parts are

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-15 Thread Canan Talayhan
Hi team, Thanks for your help. @Chris After all the modifications that I've made according to your comments, I've created the latest version of my patch. Could you please review the patch attached and share your ideas? Please note that a few parts are left. After your confirmation, I can handle

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-13 Thread Maxime Devos
On Tue, 2021-04-13 at 18:56 +0300, Canan Talayhan wrote: > [...] > After sending the patch I've turned the patch like below. > (title ,(if title > `,(string-append title " - Guix Data Service") > '("Guix Data Service"))) A little more simplification is possible:

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-13 Thread Canan Talayhan
Hi Maxime, Is this ‘introductory task’ publicly available? If so, could you post a > link? I'm not up-to-date with Outreachy. > It's not available under the Official Outreachy page if you're not logged in. > Typographical nitpick: I would use a proper dash here (the figure dash ‒ > or the —

Re: [Outreachy] - Guix Data Service - Set a more informative page title

2021-04-13 Thread Maxime Devos
On Tue, 2021-04-13 at 12:01 +0300, Canan Talayhan wrote: > Hi everyone, Welcome! > My name is Canan. I'm an Outreachy applicant. I'm working on the introductory > task for > Guix Data Service. Is this ‘introductory task’ publicly available? If so, could you post a link? I'm not up-to-date with