Re: [PATCH 00/13] Add a bunch of LV2 audio effects!

2016-10-14 Thread Ricardo Wurmus 

Andreas Enge  writes:

> Hello Ricardo,
>
> On Wed, Oct 12, 2016 at 08:12:36PM +0200, Ricardo Wurmus wrote:
>> here's a simple patch set to add 13 new LV2 audio plugins.
>
> the packages fail to build on arm due to their use of SSE instructions:
>http://hydra.gnu.org:3000/build/1528551
> Could these be disabled, or should the packages as a whole be disabled on arm?

These packages should now be okay on ARM.  The Makefiles contain tests
for whether SSE instructions are supported, but the tests contained
syntax errors, so they would always result in SSE instructions to be
enabled.  I reported this upstream and fixed our packages.

> Also jack-keyboard fails:
>http://hydra.gnu.org:3000/build/1532070 ,
> but here the reason is a failing dependency.

lash fails on armhf because it uses a feature that is not available on
ARM.  I guess we could patch the sources there.

~~ Ricardo

Re: [PATCH 00/13] Add a bunch of LV2 audio effects!

2016-10-14 Thread Ricardo Wurmus 

Andreas Enge  writes:

> Hello Ricardo,
>
> On Wed, Oct 12, 2016 at 08:12:36PM +0200, Ricardo Wurmus wrote:
>> here's a simple patch set to add 13 new LV2 audio plugins.
>
> the packages fail to build on arm due to their use of SSE instructions:
>http://hydra.gnu.org:3000/build/1528551
> Could these be disabled, or should the packages as a whole be disabled on arm?

That’s unfortunate.  They should work on arm.  The build system probes
for CPU features, actually, and conditionally uses extended
instructions.

I’ll investigate.

> Also jack-keyboard fails:
>http://hydra.gnu.org:3000/build/1532070 ,
> but here the reason is a failing dependency.
>
> Could you have a look, please?

Thanks for the hint.  I’ll check it out.

~~ Ricardo

Re: [PATCH 00/13] Add a bunch of LV2 audio effects!

2016-10-14 Thread Andreas Enge 
Hello Ricardo,

On Wed, Oct 12, 2016 at 08:12:36PM +0200, Ricardo Wurmus wrote:
> here's a simple patch set to add 13 new LV2 audio plugins.

the packages fail to build on arm due to their use of SSE instructions:
   http://hydra.gnu.org:3000/build/1528551
Could these be disabled, or should the packages as a whole be disabled on arm?

Also jack-keyboard fails:
   http://hydra.gnu.org:3000/build/1532070 ,
but here the reason is a failing dependency.

Could you have a look, please?

Andreas

Re: [PATCH 00/13] Add a bunch of LV2 audio effects!

2016-10-13 Thread Ricardo Wurmus 

Ricardo Wurmus  writes:

> Kei Kebreau  writes:
>
>> Ricardo Wurmus  writes:
>>
>>> Hi Guix,
>>>
>>> here's a simple patch set to add 13 new LV2 audio plugins.
>>> Have fun!
>>>
>>> ~~ Ricardo
>>>
>>>
>>> Ricardo Wurmus (13):
>>>   gnu: Add gx-guvnor-lv2.
>>>   gnu: Add gx-vbass-preamp-lv2.
>>>   gnu: Add gx-overdriver-lv2.
>>>   gnu: Add gx-tone-mender-lv2.
>>>   gnu: Add gx-push-pull-lv2.
>>>   gnu: Add gx-suppa-tone-bender-lv2.
>>>   gnu: Add gx-saturator-lv2.
>>>   gnu: Add gx-hyperion-lv2.
>>>   gnu: Add gx-voodoo-fuzz-lv2.
>>>   gnu: Add gx-super-fuzz-lv2.
>>>   gnu: Add gx-vintage-fuzz-master-lv2.
>>>   gnu: Add gx-slow-gear-lv2.
>>>   gnu: Add gx-switchless-wah-lv2.
>>>
>>>  gnu/packages/music.scm | 286 
>>> +
>>>  1 file changed, 286 insertions(+)
>>
>> Patches 01 through 10 are clean according to "guix lint" and
>> reproducible. "git am" complains about 11 through 13 being corrupt for
>> some reason.
>
> Huh, weird.  Maybe a bug in git am?
>
> FWIW, “guix lint” doesn’t complain about any of these packages.

I pushed these patches to master.  Thanks for the review!

~~ Ricardo

Re: [PATCH 00/13] Add a bunch of LV2 audio effects!

2016-10-12 Thread Ricardo Wurmus 

Kei Kebreau  writes:

> Ricardo Wurmus  writes:
>
>> Hi Guix,
>>
>> here's a simple patch set to add 13 new LV2 audio plugins.
>> Have fun!
>>
>> ~~ Ricardo
>>
>>
>> Ricardo Wurmus (13):
>>   gnu: Add gx-guvnor-lv2.
>>   gnu: Add gx-vbass-preamp-lv2.
>>   gnu: Add gx-overdriver-lv2.
>>   gnu: Add gx-tone-mender-lv2.
>>   gnu: Add gx-push-pull-lv2.
>>   gnu: Add gx-suppa-tone-bender-lv2.
>>   gnu: Add gx-saturator-lv2.
>>   gnu: Add gx-hyperion-lv2.
>>   gnu: Add gx-voodoo-fuzz-lv2.
>>   gnu: Add gx-super-fuzz-lv2.
>>   gnu: Add gx-vintage-fuzz-master-lv2.
>>   gnu: Add gx-slow-gear-lv2.
>>   gnu: Add gx-switchless-wah-lv2.
>>
>>  gnu/packages/music.scm | 286 
>> +
>>  1 file changed, 286 insertions(+)
>
> Patches 01 through 10 are clean according to "guix lint" and
> reproducible. "git am" complains about 11 through 13 being corrupt for
> some reason.

Huh, weird.  Maybe a bug in git am?

FWIW, “guix lint” doesn’t complain about any of these packages.

~~ Ricardo

Re: [PATCH 00/13] Add a bunch of LV2 audio effects!

2016-10-12 Thread Kei Kebreau 
Ricardo Wurmus  writes:

> Hi Guix,
>
> here's a simple patch set to add 13 new LV2 audio plugins.
> Have fun!
>
> ~~ Ricardo
>
>
> Ricardo Wurmus (13):
>   gnu: Add gx-guvnor-lv2.
>   gnu: Add gx-vbass-preamp-lv2.
>   gnu: Add gx-overdriver-lv2.
>   gnu: Add gx-tone-mender-lv2.
>   gnu: Add gx-push-pull-lv2.
>   gnu: Add gx-suppa-tone-bender-lv2.
>   gnu: Add gx-saturator-lv2.
>   gnu: Add gx-hyperion-lv2.
>   gnu: Add gx-voodoo-fuzz-lv2.
>   gnu: Add gx-super-fuzz-lv2.
>   gnu: Add gx-vintage-fuzz-master-lv2.
>   gnu: Add gx-slow-gear-lv2.
>   gnu: Add gx-switchless-wah-lv2.
>
>  gnu/packages/music.scm | 286 
> +
>  1 file changed, 286 insertions(+)

Patches 01 through 10 are clean according to "guix lint" and
reproducible. "git am" complains about 11 through 13 being corrupt for
some reason.


signature.asc
Description: PGP signature