Hello,
Lukas Gradl skribis:
> From 5fb85fef7b1475baca6c29beb26799ca8f3d814a Mon Sep 17 00:00:00 2001
> From: Lukas Gradl
> Date: Tue, 9 Aug 2016 16:49:19 -0500
> Subject: [PATCH 04/10] gnu: argon2: Install pkg-config file.
>
> * gnu/packages/password-utils.scm (argon2)[source]: Create pkg-confi
Hi,
Danny Milosavljevic writes:
> Yes. I think that is a good approach.
>
> Could you send an updated patchset?
The attached patch implements everything as discussed. Thank you for
your explanation and your help! I am a lot happier with this package
now than before.
Best,
Lukas
From 5fb85fe
Hi Lukas,
On Sun, 25 Sep 2016 17:45:06 -0500
Lukas Gradl wrote:
> Since the return value of "(symlink ...)" is
> unspecified, then we don't need the "(and ...)" at all, right?
Right.
> My understanding is now that if this 'dring' binary were to get
> executed, it would look for 'libargon2.so
Hi Danny,
Sorry for the delay!
Danny Milosavljevic writes:
> Hi Lukas,
>
> I thought about it some more.
>
> On Sun, 18 Sep 2016 16:43:03 -0500
> Lukas Gradl wrote:
>> + (and
>> +(install-file "argon2" (string-append out "/bin"))
>> +(install-file
Hi Lukas,
I thought about it some more.
On Sun, 18 Sep 2016 16:43:03 -0500
Lukas Gradl wrote:
> + (and
> +(install-file "argon2" (string-append out "/bin"))
> +(install-file "libargon2.a" (string-append out "/lib"))
> +(install-file "
Danny Milosavljevic writes:
>> + (snippet
>> +'(let ((p (open-file "argon2.pc" "a")))
> ... ^ why?
Sorry, I took this without thinking from another place where I did
similar things. This should be "w". The attached patch fixes that.
Thank
>>> + (zero? (system* "ln" "-s"
>>> + (string-append out "/lib/libargon2.so")
>>> + (string-append out "/lib/libargon2.so.0")))
>>
>> The result of this will be ignored. Did you mean "(and ...)"?
>
> Oops! Yes, I will send a
Thank you for your review!
Danny Milosavljevic writes:
>> + (snippet
>> +'(let ((p (open-file "argon2.pc" "a")))
> ... ^ why?
>
>> + (begin
>> + (display
>> + (string-append "prefix=/usr/local\n"
>> +
> + (snippet
> +'(let ((p (open-file "argon2.pc" "a")))
... ^ why?
> + (begin
> + (display
> + (string-append "prefix=/usr/local\n"
> + "exec_prefix=${prefix}\n"
> +
