Re: gnu: artanis: Remove implied $(DESTDIR) usage.

[Marius Bakke]

Adonay Felipe Nogueira  writes:

> Oh my! ... Sorry for being careless. I guess I was so happy to finally
> fix the problem upstream that I forgot to adapt our recipe accordingly.
>
> Thanks for testing. :)
>
> I have made the patch again, and also properly referenced the patch
> tickets from upstream.

Thanks! I made slight adjustments to the commit message and kept the
original (let* ((out ...))) to make it clearer what the patch does.

Pushed as 8a666bc5cb3c50b4b881290c7776c3f681a734bc !

Re: gnu: artanis: Remove implied $(DESTDIR) usage.

[Adonay Felipe Nogueira]

Oh my! ... Sorry for being careless. I guess I was so happy to finally
fix the problem upstream that I forgot to adapt our recipe accordingly.

Thanks for testing. :)

I have made the patch again, and also properly referenced the patch
tickets from upstream.
From 85d418a8750cb7b90cab12c5cc7687e8fd8a6981 Mon Sep 17 00:00:00 2001
From: Adonay Felipe Nogueira 
Date: Mon, 17 Oct 2016 10:47:21 -0200
Subject: [PATCH] gnu: artanis: Remove implied $(DESTDIR) usage.

* gnu/packages/patches/artanis-fix-Makefile.in.patch: New patch.
* gnu/local.mk (dist_patch_DATA): Register patch.
* gnu/packages/guile.scm (artanis)
** [source]: Use patch.
** [arguments]: Remove DESTDIR from #:make-flags.
---
 gnu/local.mk   |  2 +
 gnu/packages/guile.scm | 14 +++--
 gnu/packages/patches/artanis-fix-Makefile.in.patch | 70 ++
 3 files changed, 81 insertions(+), 5 deletions(-)
 create mode 100644 gnu/packages/patches/artanis-fix-Makefile.in.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index 27872ce..9079b42 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -5,6 +5,7 @@
 # Copyright © 2013, 2014, 2015, 2016 Mark H Weaver 
 # Copyright © 2016 Chris Marusich 
 # Copyright © 2016 Kei Kebreau 
+# Copyright © 2016 Adonay "adfeno" Felipe Nogueira  
 #
 # This file is part of GNU Guix.
 #
@@ -454,6 +455,7 @@ dist_patch_DATA =		\
   %D%/packages/patches/antiword-CVE-2014-8123.patch			\
   %D%/packages/patches/apr-skip-getservbyname-test.patch	\
   %D%/packages/patches/arb-ldconfig.patch			\
+  %D%/packages/patches/artanis-fix-Makefile.in.patch		\
   %D%/packages/patches/ath9k-htc-firmware-binutils.patch	\
   %D%/packages/patches/ath9k-htc-firmware-gcc.patch		\
   %D%/packages/patches/ath9k-htc-firmware-objcopy.patch		\
diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index 7361f1f..a99386a 100644
--- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2016 Erik Edrosa 
 ;;; Copyright © 2016 Eraim Flashner 
 ;;; Copyright © 2016 Alex Kost 
+;;; Copyright © 2016 Adonay "adfeno" Felipe Nogueira  
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -305,7 +306,8 @@ applicable."
   version ".tar.gz"))
   (sha256
(base32
-"19m3ak12cqk8js9d2mdg11kh4fjsq8frfpd10qw75h0zpr5cywpp"
+"19m3ak12cqk8js9d2mdg11kh4fjsq8frfpd10qw75h0zpr5cywpp"))
+  (patches (search-patches "artanis-fix-Makefile.in.patch"
 (build-system gnu-build-system)
 ;; TODO: Add guile-dbi and guile-dbd optional dependencies.
 (inputs `(("guile" ,guile-2.0)))
@@ -315,12 +317,14 @@ applicable."
 (arguments
  '(#:make-flags
;; TODO: The documentation must be built with the `docs' target.
-   (let* ((out (assoc-ref %outputs "out"))
-  (dir (string-append out "/share/guile/site/2.0")))
+   (let*
+   ((dir
+  (string-append
+(assoc-ref %outputs "out")
+"/share/guile/site/2.0")))
  ;; Don't use (%site-dir) for site paths.
  (list (string-append "MOD_PATH=" dir)
-   (string-append "MOD_COMPILED_PATH=" dir)
-   (string-append "DESTDIR=" out)))
+   (string-append "MOD_COMPILED_PATH=" dir)))
#:test-target "test"
#:phases
(modify-phases %standard-phases
diff --git a/gnu/packages/patches/artanis-fix-Makefile.in.patch b/gnu/packages/patches/artanis-fix-Makefile.in.patch
new file mode 100644
index 000..7e4800d
--- /dev/null
+++ b/gnu/packages/patches/artanis-fix-Makefile.in.patch
@@ -0,0 +1,70 @@
+Applies until an Artanis release comes with the following patches
+applied:
+* 
+* 
+diff -ru artanis-0.1.2/Makefile.in artanis-0.1.2.1/Makefile.in
+--- artanis-0.1.2/Makefile.in	2016-02-10 12:35:18.800490571 -0200
 artanis-0.1.2.1/Makefile.in	2016-10-15 19:44:35.140907367 -0300
+@@ -19,9 +19,18 @@
+ MOD_OBJ := $(OBJ)/artanis
+ BIN := bin
+ TEMP_LIB_PATH := $(OBJ)
+-MOD_PATH := $(shell guile -c "(display (%site-dir))")
+ MOD_COMPILED_PATH := $(shell guile -c "(display (%site-ccache-dir))")
++
++ifdef DESTDIR
++INFO_DIR := $(DESTDIR)/share/info/
++MOD_PATH := $(DESTDIR)/$(shell guile -c "(display (%site-dir))")
+ MOD_TARGET_PATH := $(DESTDIR)/$(MOD_COMPILED_PATH)
++else
++INFO_DIR := $(PREFIX)/share/info/
++MOD_PATH := $(shell guile -c "(display (%site-dir))")
++MOD_TARGET_PATH := $(MOD_COMPILED_PATH)
++endif
++
+ GUILE_CFLAGS := -Wunsupported-warning -Wunbound-variable -Warity-mismatch -Wduplicate-case-datum -Wbad-case-datum -Wformat
+ GUILEC := GUILE_LOAD_COMPILED_PATH=$(TEMP_LIB_PATH) guild compile $(GUILE_CFLAGS)
+ ARTANIS_ETC := $(SRC)/etc/artanis
+@@ -36,7 +45,6 @@
+ GENDOCS :=$(BUIL

Re: gnu: artanis: Remove implied $(DESTDIR) usage.

[Marius Bakke]

Adonay Felipe Nogueira  writes:

> My first patch to Guix project, I hope this helps. :)

Welcome and thanks for this patch! :)

The current artanis package has a bug where the install location is set
to "$out/$out/share/guile/site/2.0". This patch fixes that by installing
to "$out/share/guile/site/2.0". I can load it from the Guile REPL now.

However, the same files are still present in
/gnu/store/...-artanis-0.1.2/gnu/store/...-artanis-0.1.2 as before. It
seems to be installed to both $out and $out/$out. Do you think you can
prevent this from happening as well?

Other than that I only have one remark:

[...]

> diff --git a/gnu/packages/patches/artanis-fix-Makefile.in.patch 
> b/gnu/packages/patches/artanis-fix-Makefile.in.patch
> new file mode 100644
> index 000..d2c19f1
> --- /dev/null
> +++ b/gnu/packages/patches/artanis-fix-Makefile.in.patch
> @@ -0,0 +1,69 @@
> +Applies until an Artanis release comes with patches #9130 and #9131
> +applied.

Please mention the upstream commit hash or bug report here, so that
the next person can easily tell whether this is still needed or not.

Can you send an updated patch?

Thanks!