Re: [hackers] [slock] [PATCHSET] Some improvements and more security

2016-09-11 Thread FRIGN
On Sun, 11 Sep 2016 23:24:20 +0200 FRIGN wrote: > See attached. Most important is the patch which removes the > abomination of user $USER which actually poses quite a risk and only > is done on part of the systems. So you can test this, do the following $ unset USER $ slock

[hackers] [slock] [PATCHSET] Some improvements and more security

2016-09-11 Thread FRIGN
Good evening fellow hackers, I sat down this evening to write down some patches that have been floating around in my head for a while. See attached. Most important is the patch which removes the abomination of user $USER which actually poses quite a risk and only is done on part of the systems. T

Re: [hackers] [xssstate] Refactor xssstate.c

2016-09-11 Thread FRIGN
On Sun, 11 Sep 2016 16:46:29 -0400 Russ wrote: Hey Russ, > I agree it does some, but using strcmp allows matching the flags > exactly, and prevents things like "xssstate -v" being equivilant to > "xssstate -vxyz". And since you would only ever use one flag at a > time, arg.h seemed like it was

Re: [hackers] [xssstate] Refactor xssstate.c

2016-09-11 Thread Russ
> does it really simplify the code? I think it makes it less readable > without arg.h. I agree it does some, but using strcmp allows matching the flags exactly, and prevents things like "xssstate -v" being equivilant to "xssstate -vxyz". And since you would only ever use one flag at a time, ar

Re: [hackers] [xssstate] Refactor xssstate.c

2016-09-11 Thread FRIGN
On Sun, 11 Sep 2016 16:17:09 -0400 Russ wrote: Hey Russ, > I'd like to propose a refactoring of xssstate.c. It simplifies the > code, removing the need for arg.h, and has strict error checking and > usage rules. Thoughts? does it really simplify the code? I think it makes it less readable wit

[hackers] [xssstate] Refactor xssstate.c

2016-09-11 Thread Russ
Hello all, I'd like to propose a refactoring of xssstate.c. It simplifies the code, removing the need for arg.h, and has strict error checking and usage rules. Thoughts? ___ diff --git a/arg.h b/arg.h deleted file mode 100644 index ba3fb3f..000 --- a/arg.h +++ /dev/null @@ -1,48 +0,0 @@ -/*