commit d8656b0189220e73d3a6cd4ebeaec5091824aef1
Author: Mattias Andrée
AuthorDate: Wed Jul 11 20:53:17 2018 +0200
Commit: Michael Forney
CommitDate: Mon Sep 24 13:04:06 2018 -0700
uname: check that no operands are specified
Signed-off-by: Mattias Andrée
diff --git
commit 48d04ae446b39c0e230ec4e8c38d25865fb662db
Author: Michael Forney
AuthorDate: Tue Sep 25 17:57:51 2018 -0700
Commit: Michael Forney
CommitDate: Tue Sep 25 19:16:19 2018 -0700
find: Make -H and -L flag handling clearer
diff --git a/find.c b/find.c
index e095015..03889a8 100644
On 2018-07-08, David Phillips wrote:
> As a side note to this patch: it's been sitting in my queue for
> the better part of a year while I internally debated the
> untidiness of not being allowed to chdir. It's an unfortunate
> result of implementing this behaviour, but it's behaviour
> that
On Mon, 24 Sep 2018 at 21:14, Mario J. Rugiero wrote:
> When cleaning up the stack the stack member for the first
> monitor wasn't being updated to reflect this, with the following
> (possible) consequences:
> - An infinite loop. If things wouldn't crash, not updating the
> guard of the loop
On Mon, 24 Sep 2018 at 21:14, Mario J. Rugiero wrote:
> Continuing on '!selmon->sel' leads to a NULL pointer dereference.
???
Rejected.
-Anselm
From: Mario Rugiero
When running with root or a password for the user is missing,
authentication is bypassed.
However, it is later attempted to compare the new password
against the missing one, causing crypt to crash due to a null
salt.
In the case of a missing password, there's no prior
From: Mario Rugiero
When deciding where the previous hash should come from, is is
assumed that 'x' started strings all mean to look in shadow.
This is probably harmless in practice, since modern Linux still
use only hashes instead of raw passwords.
However, this is more robust, and more
El mar., 25 sep. 2018 02:18, Quentin Rameau escribió:
> Hey Mario,
>
> > - p = crypt(inpass, prevhash);
> > - if (!p)
> > - eprintf("crypt:");
> > - if (cryptpass1 && strcmp(cryptpass1, p) == 0)
> > - eprintf("password left unchanged\n");
> > + if
El mar., 25 sep. 2018 02:03, Quentin Rameau escribió:
> Hello Mario,
>
> > - if (pw->pw_passwd[0] == 'x')
> > + if (pw->pw_passwd[0] == 'x' &&
> > + pw->pw_passwd[0] == '\0')
>
> Did you mean “pw->pw_passwd[1] == '\0')”?
>
> Yes. I'll send a fix later.
Hi Roberto,
> If we go to increase that size, I would go to use dynamic memory. Having
> an array of 1MB statically allocated is a crazy idea
Yes it is!
> (and it is not C99 compliant, where the maximun allocated size is 128K).
That's actually 64k (“at least […] — 65535 bytes in an object (in
On Tue, Sep 25, 2018 at 10:05 AM Roberto E. Vargas Caballero
wrote:
> On Mon, Sep 24, 2018 at 05:45:29PM -0700, Eric Pruitt wrote:
> > I agree that the current buffer is too small. I'm pretty sure I've run
> > into this problem myself with Vim and Bash, but I hadn't gotten around
> > to digging
On Mon, Sep 24, 2018 at 05:45:29PM -0700, Eric Pruitt wrote:
> I agree that the current buffer is too small. I'm pretty sure I've run
> into this problem myself with Vim and Bash, but I hadn't gotten around
> to digging into the problem.
If we go to increase that size, I would go to use dynamic
On Mon, Sep 24, 2018 at 10:03 PM Michael Forney wrote:
> On 7/8/18, Silvan Jegen wrote:
> > Heyho
> >
> > Found this when running smatch on sbase.
>
> The current code is correct. -H should turn on gflags.h, and turn off
> gflags.l. POSIX says each flag should override the other. I agree that
>
13 matches
Mail list logo
