Re: [hackers] [st][patch] replace utf8strchr with wcschr

2019-03-13 Thread Lauri Tirkkonen
On Wed, Mar 13 2019 20:35:09 +0100, Hiltjo Posthuma wrote: > I don't like mixing of the existing functions with wchar_t. wcwidth() is already called with Rune argument, so I don't think my diff adds any new assumptions... -- Lauri Tirkkonen | lotheac @ IRCnet

Re: [hackers] [st][patch] replace utf8strchr with wcschr

2019-03-13 Thread Hiltjo Posthuma
On Wed, Mar 13, 2019 at 08:16:05PM +0200, Lauri Tirkkonen wrote: > Changing worddelimiters to wchar_t * allows to use wcschr() instead of > implementing utf8strchr(). > > Also, since there are so many different spaces and punctuation in > unicode, I have another diff that uses

[hackers] [sbase] sort: Use regular `double` for -n || Michael Forney

2019-03-13 Thread git
commit 6b950e436b9d81edb982d740d02198ba184402fb Author: Michael Forney AuthorDate: Fri Feb 22 14:26:39 2019 -0800 Commit: Michael Forney CommitDate: Wed Mar 13 11:59:33 2019 -0700 sort: Use regular `double` for -n `long double` may require software emulation and the

[hackers] [st][patch] use iswspace()/iswpunct() to find word delimiters

2019-03-13 Thread Lauri Tirkkonen
There are many different space characters in unicode, and even more punctuation characters. Instead of having people list them all in configuration as delimiters for double-click selection, consider all 'punct' and 'space' class characters delimiters by default (unless explicitly configured not to

[hackers] [st][patch] replace utf8strchr with wcschr

2019-03-13 Thread Lauri Tirkkonen
Changing worddelimiters to wchar_t * allows to use wcschr() instead of implementing utf8strchr(). Also, since there are so many different spaces and punctuation in unicode, I have another diff that uses iswspace()/iswpunct() to figure out delimiters, but I expect that to be a bit more

Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes

2019-03-13 Thread Hiltjo Posthuma
On Wed, Mar 13, 2019 at 05:12:54PM +0200, Lauri Tirkkonen wrote: > Currently st is outputting the following on stderr when I attach or > detach tmux (on OpenBSD): > > erresc: unknown private set/reset mode 1005 > > diff below fixes it. > > From e3ddd14bacb0037e236b5a2243120b8494c5f054 Mon

[hackers] [st] be silent about explicitly unhandled mouse modes || Lauri Tirkkonen

2019-03-13 Thread git
commit 75b4ba4b4be70a3ae429b1719d18b021839216d5 Author: Lauri Tirkkonen AuthorDate: Wed Mar 13 17:08:50 2019 +0200 Commit: Hiltjo Posthuma CommitDate: Wed Mar 13 17:51:58 2019 +0100 be silent about explicitly unhandled mouse modes diff --git a/st.c b/st.c index 379dd10..d35f89d

Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes

2019-03-13 Thread Quentin Rameau
Hello Abdullah, > it fixes this. > > see attachment. > > On 13/03, Quentin Rameau wrote: > > Hello Lauri, > > > > > diff below fixes it. > > > > What does it fix? > > Please do not send to this mailing list while being drunk.

Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes

2019-03-13 Thread Quentin Rameau
> the erroneous output on stderr. the comment reads like these escapes are > intentionally left unhandled, but in that case it doesn't make sense to > output an error about them. Ok, I thought there was actually an issue preventing tmux to work correctly.

Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes

2019-03-13 Thread Abdullah
He has explained in his patch what it fixes. On 13/03, Quentin Rameau wrote: > Hello Lauri, > > > diff below fixes it. > > What does it fix? > A K https://abdullah.today 69C8 7720 E507 86DF 1D85 EA5E FC59 7891 5CBC 7BC7 signature.asc Description: PGP signature

Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes

2019-03-13 Thread Lauri Tirkkonen
On Wed, Mar 13 2019 16:22:02 +0100, Quentin Rameau wrote: > Hello Lauri, > > > diff below fixes it. > > What does it fix? the erroneous output on stderr. the comment reads like these escapes are intentionally left unhandled, but in that case it doesn't make sense to output an error about them.

Re: [hackers] [st][patch] be silent about explicitly unhandled mouse modes

2019-03-13 Thread Quentin Rameau
Hello Lauri, > diff below fixes it. What does it fix?

[hackers] [st][patch] be silent about explicitly unhandled mouse modes

2019-03-13 Thread Lauri Tirkkonen
Currently st is outputting the following on stderr when I attach or detach tmux (on OpenBSD): erresc: unknown private set/reset mode 1005 diff below fixes it. >From e3ddd14bacb0037e236b5a2243120b8494c5f054 Mon Sep 17 00:00:00 2001 From: Lauri Tirkkonen Date: Wed, 13 Mar 2019 17:08:50