Re: [hackers] [dmenu][PATCHes] Fix truncation issues and improve performance

2022-03-23 Thread NRK
On Wed, Mar 23, 2022 at 11:13:00AM +0100, Stein Gunnar Bakkeby wrote: > Regarding the first patch I got the impression that the overflow should be > triggered if (ew + tmpw > w) { You're correct. I forgot to mention, but that was another bug I have fixed locally. > For the second patch I am not

Re: [hackers] [dmenu][PATCHes] Fix truncation issues and improve performance

2022-03-23 Thread Stein Gunnar Bakkeby
Hi NRK, I have gone through these patches again and they seem pretty solid. Regarding the first patch I got the impression that the overflow should be triggered if (ew + tmpw > w) { The reasoning is that it appears to crop 4 characters instead of 3 when it adds the ellipsis. If we try a long

Re: [hackers] Re: [dwm][PATCH v3] manage: For isfloating/oldstate check/set, ensure trans client actually exists

2022-03-23 Thread Miles Alan
On Mon, Mar 21, 2022, at 10:19 AM, Chris Down wrote: > WM_TRANSIENT_FOR is set to the root window in the pinentry's case: > > % xprop | grep TRANSIENT > WM_TRANSIENT_FOR(WINDOW): window id # 0x523 > % xwininfo -root -tree | grep 0x523 > xwininfo: Window id: 0x523 (the root

[hackers] [sbase] libutf: add some const's

2022-03-23 Thread David Demelier
--- libutf/mkrunetype.awk | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libutf/mkrunetype.awk b/libutf/mkrunetype.awk index 3736e78..e01ea2c 100644 --- a/libutf/mkrunetype.awk +++ b/libutf/mkrunetype.awk @@ -129,7 +129,7 @@ function mkis(name, runev, runec,

Re: [hackers] [dmenu][PATCHes] Fix truncation issues and improve performance

2022-03-23 Thread NRK
On Wed, Mar 23, 2022 at 09:13:52AM +0100, Hiltjo Posthuma wrote: > Please continue working on this patch, it is appreciated. > When it mostly works it can be put into libsl and dmenu and dwm. > > If possible please make the first iteration compatible with the current API. > This would make

Re: [hackers] [dmenu][PATCHes] Fix truncation issues and improve performance

2022-03-23 Thread Hiltjo Posthuma
On Wed, Mar 23, 2022 at 12:26:24AM +0600, NRK wrote: > On Tue, Mar 22, 2022 at 06:06:30PM +0100, Stein Gunnar Bakkeby wrote: > > With the first patch the text is still allowed to bleed into the right hand > > side padding as long as it fits. > > > > I worked around that by reducing w with 2 *