Re: [hackers] [dwm|dmenu|st][PATCH] strip the installed binary

2022-05-02 Thread NRK
On Mon, May 02, 2022 at 01:37:26PM +0200, Hiltjo Posthuma wrote: > LDFLAGS="-s" is practically the same as calling strip and stripping it. > > It is up to the distro package/ports maintainer to strip symbols (or not). > This can be an additional packaging step. Since many of the Makefiles have

Re: [hackers] [dwm|dmenu|st][PATCH] strip the installed binary

2022-05-02 Thread Hiltjo Posthuma
On Mon, May 02, 2022 at 01:48:05PM +0200, Quentin Rameau wrote: > Hi Hiltjo, > > > I don't like this. > > > > I'd rather have it so the Makefile respects the system or package system > > CFLAGS > > and LDFLAGS by default. Then someone can do: make CFLAGS="-Os" LDFLAGS="-s" > > etc. > > > >

Re: [hackers] [dwm|dmenu|st][PATCH] strip the installed binary

2022-05-02 Thread Quentin Rameau
Hi Hiltjo, > I don't like this. > > I'd rather have it so the Makefile respects the system or package system > CFLAGS > and LDFLAGS by default. Then someone can do: make CFLAGS="-Os" LDFLAGS="-s" > etc. > > LDFLAGS="-s" is practically the same as calling strip and stripping it. > > It is up

Re: [hackers] [dwm|dmenu|st][PATCH] strip the installed binary

2022-05-02 Thread Laslo Hunhold
On Mon, 2 May 2022 13:37:26 +0200 Hiltjo Posthuma wrote: Dear Hiltjo, > I don't like this. > > I'd rather have it so the Makefile respects the system or package > system CFLAGS and LDFLAGS by default. Then someone can do: make > CFLAGS="-Os" LDFLAGS="-s" etc. > > LDFLAGS="-s" is practically

Re: [hackers] [dwm|dmenu|st][PATCH] strip the installed binary

2022-05-02 Thread Hiltjo Posthuma
On Mon, May 02, 2022 at 02:46:27PM +0600, NRK wrote: > Hi, > > Was wondering why most suckless program doesn't seem to strip the > installed binary. strip (1p) is specified by POSIX so it should be > portable. > > I noticed the binary size dropping a fair bit after stripping; the > following

Re: [hackers] [dwm|dmenu|st][PATCH] strip the installed binary

2022-05-02 Thread Quentin Rameau
> Hi, Hi NRK, > Attached patches to strip the binary on installation for dwm, dmenu and > st. Looks good to me, thanks!