Re: [hackers] [sbase][PATCH] tar: support extracting long paths, link targets, and times.

2022-05-04 Thread Quentin Rameau
Hi Andrew, > Posix tarballs use extended headers to represent paths and values that do > not fit in the original ustar header format. This patch implements parsing > and handling of a subset of these extended headers. The motivating > tarball was the gcc source code, which exceeds the original

Re: [hackers] [surf][PATCH] Don't call setstyle with an empty path

2022-05-04 Thread Nick Hanley
On Wed, May 04, 2022 at 09:49:33AM +0200, Antonio Quartulli wrote: > On 04/05/2022 00:18, Nick Hanley wrote: > > On Tue, May 03, 2022 at 02:45:05PM -0400, fo...@dnmx.org wrote: > >> Just wondering - why not just do > >> if (*getstyle(geturi(c))) > >>setstyle(c, file); > > > > We need to pass

Re: [hackers] [surf][PATCH] Don't call setstyle with an empty path

2022-05-04 Thread Antonio Quartulli
On 04/05/2022 00:18, Nick Hanley wrote: On Tue, May 03, 2022 at 02:45:05PM -0400, fo...@dnmx.org wrote: Just wondering - why not just do if (*getstyle(geturi(c))) setstyle(c, file); We need to pass the file path returned by getstyle to setstyle. An alternative would be to keep the

Re: [hackers] [surf][PATCH] Don't call setstyle with an empty path

2022-05-04 Thread Nick Hanley
On Tue, May 03, 2022 at 02:45:05PM -0400, fo...@dnmx.org wrote: > Just wondering - why not just do > if (*getstyle(geturi(c))) > setstyle(c, file); We need to pass the file path returned by getstyle to setstyle.