Re: [hackers] [sent] [PATCH] treewide: Improve compliance with our coding style

2022-06-25 Thread Tom Schwindl
On Sat, Jun 25, 2022 at 11:38:20PM +0600, NRK wrote: > On Sat, Jun 25, 2022 at 05:25:54PM +, Tom Schwindl wrote: > > -static void run(); > > -static void usage(); > > -static void xdraw(); > > -static void xhints(); > > -static void xinit(); > > -static void xloadfonts(); > > +static void

Re: [hackers] [sent] [PATCH] treewide: Improve compliance with our coding style

2022-06-25 Thread NRK
On Sat, Jun 25, 2022 at 05:25:54PM +, Tom Schwindl wrote: > -static void run(); > -static void usage(); > -static void xdraw(); > -static void xhints(); > -static void xinit(); > -static void xloadfonts(); > +static void run(void); > +static void usage(void); > +static void xdraw(void); >

[hackers] [sent] [PATCH] treewide: Improve compliance with our coding style

2022-06-25 Thread Tom Schwindl
- Add `void` as parameter for functions which do not take any Arguments - Use a block if the body of a loop consists of an `if` statement - A few changes such as moving a curley bracket --- diff --git a/drw.c b/drw.c index c1582e746cc5..84f87b972384 100644 --- a/drw.c +++ b/drw.c @@ -19,9 +19,10

[hackers] [lsw] Makefile: Add POSIX target || Tom Schwindl

2022-06-25 Thread git
commit 830c93ee64fe931136eb842a7ed89af5199d8655 Author: Tom Schwindl AuthorDate: Sat Jun 25 12:03:26 2022 + Commit: Hiltjo Posthuma CommitDate: Sat Jun 25 15:13:44 2022 +0200 Makefile: Add POSIX target Since no extensions are used in the Makefile, add the .POSIX target.

[hackers] [lsw] [PATCH] Makefile: Add POSIX target

2022-06-25 Thread Tom Schwindl
Since no extensions are used in the Makefile, add the .POSIX target. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index b37fa6412ee5..7d7e00dfb370 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,6 @@ # lsw - list window names # See LICENSE file for

[hackers] [lsw] fix segfault after querying window with no children || Hiltjo Posthuma

2022-06-25 Thread git
commit a2e5856f22739a9056fa41789369948450cd7e36 Author: Hiltjo Posthuma AuthorDate: Sat Jun 25 10:11:26 2022 +0200 Commit: Hiltjo Posthuma CommitDate: Sat Jun 25 10:11:26 2022 +0200 fix segfault after querying window with no children Reported by Augusto Castelo , thanks!

[hackers] [lsw] code-style improvements || Hiltjo Posthuma

2022-06-25 Thread git
commit 8d5beffdb4522df02fc5b80003de94a248b20e70 Author: Hiltjo Posthuma AuthorDate: Sat Jun 25 10:19:04 2022 +0200 Commit: Hiltjo Posthuma CommitDate: Sat Jun 25 10:19:04 2022 +0200 code-style improvements diff --git a/lsw.c b/lsw.c index 8b04ef2..c7d5171 100644 --- a/lsw.c +++

[hackers] [lsw] improve Makefile: be verbose || Hiltjo Posthuma

2022-06-25 Thread git
commit b3a8bc86130458152e7700ffe690ef64bca98288 Author: Hiltjo Posthuma AuthorDate: Sat Jun 25 10:19:41 2022 +0200 Commit: Hiltjo Posthuma CommitDate: Sat Jun 25 10:19:41 2022 +0200 improve Makefile: be verbose Using @ to hide output makes debugging slightly harder. Do