Re: [hackers] [dwm] [PATCH] add a comment to clarify a potential overflow of ltsymbol

On Wed, Feb 15, 2023 at 05:28:43PM +, Tom Schwindl wrote: > Hi Hiltjo, > > > Hi, > > > > I think it is too verbose and don't think the comment is neccesary. > > > > I can understand the verbosity part, but that's something I can change. > My point here was more that bug reports get posted to

Re: [hackers] [dwm] [PATCH] add a comment to clarify a potential overflow of ltsymbol

Hi Hiltjo, > Hi, > > I think it is too verbose and don't think the comment is neccesary. > I can understand the verbosity part, but that's something I can change. My point here was more that bug reports get posted to the ML and I even get them in private or from people I know in person. So I

Re: [hackers] [dwm] [PATCH] add a comment to clarify a potential overflow of ltsymbol

On Wed, Feb 15, 2023 at 11:29:26AM +, Tom Schwindl wrote: > In case the strncpy() call is advised to copy >=16 characters, ltsymbol > overflows. > As dwm does not expect to have a ltsymbol bigger than 15 characters, there > will be > no length check[0]. Our target audience are programmers,

[hackers] [dwm] [PATCH] add a comment to clarify a potential overflow of ltsymbol

In case the strncpy() call is advised to copy >=16 characters, ltsymbol overflows. As dwm does not expect to have a ltsymbol bigger than 15 characters, there will be no length check[0]. Our target audience are programmers, they should be able to figure out how to extend the length by themselves.

[hackers] [lchat] update copyright || Tom Schwindl

commit e413932d58bda64d7e9e34ca1e455d13bad17a3e Author: Tom Schwindl AuthorDate: Sat Jan 14 18:35:52 2023 +0100 Commit: Jan Klemkow CommitDate: Tue Jan 24 17:00:30 2023 +0100 update copyright diff --git a/lchat.c b/lchat.c index 4a59760..0df653d 100644 --- a/lchat.c +++ b/lchat.c

[hackers] [lchat] slackline.h: fix typo in include guard || Tom Schwindl

commit d9d4077f33f59df8579af2866cea73d0664e9add Author: Tom Schwindl AuthorDate: Sun Jan 15 01:01:06 2023 +0100 Commit: Jan Klemkow CommitDate: Tue Jan 24 16:59:40 2023 +0100 slackline.h: fix typo in include guard diff --git a/slackline.h b/slackline.h index 5039704..d2e0334 100644

[hackers] [lchat] slackline: restore some comments || Tom Schwindl

commit 8ce1eb2bb5bac39ed33dd3aace28d40a53878c16 Author: Tom Schwindl AuthorDate: Wed Jan 11 16:08:36 2023 +0100 Commit: Jan Klemkow CommitDate: Tue Jan 24 16:59:40 2023 +0100 slackline: restore some comments diff --git a/slackline.c b/slackline.c index 4573899..a56c030 100644 ---

[hackers] [lchat] slackline: ctrl+w: stop deleting when certain characters occur || Tom Schwindl

commit 9778b6b675462220fa133aa7a13fe8e5d45be6d1 Author: Tom Schwindl AuthorDate: Mon Feb 6 15:42:58 2023 +0100 Commit: Jan Klemkow CommitDate: Wed Feb 15 09:30:17 2023 +0100 slackline: ctrl+w: stop deleting when certain characters occur diff --git a/slackline.c b/slackline.c index

[hackers] [lchat] replace "magic"-numbers with symbolic constants || Tom Schwindl

commit 6d306ad60a3ed0d9e721a43fb121804974a41b6c Author: Tom Schwindl AuthorDate: Wed Jan 11 09:05:39 2023 +0100 Commit: Jan Klemkow CommitDate: Tue Jan 24 16:59:40 2023 +0100 replace "magic"-numbers with symbolic constants diff --git a/slackline.c b/slackline.c index

[hackers] [lchat] slackline: do not include slackline.h in slackline_internals.h || Tom Schwindl

commit f730489e0a632bd738ade1e91c85c6ffdad21ba8 Author: Tom Schwindl AuthorDate: Wed Jan 11 09:17:47 2023 +0100 Commit: Jan Klemkow CommitDate: Tue Jan 24 16:59:40 2023 +0100 slackline: do not include slackline.h in slackline_internals.h Although it's likely that

[hackers] [lchat] lchat: in case the `-m` flag receives an invalid mode, abort || Tom Schwindl

commit 3fc9c4d7ee1bd9a05b7bed3e835861923b6c9b28 Author: Tom Schwindl AuthorDate: Wed Jan 11 09:59:12 2023 +0100 Commit: Jan Klemkow CommitDate: Tue Jan 24 16:59:40 2023 +0100 lchat: in case the `-m` flag receives an invalid mode, abort diff --git a/lchat.c b/lchat.c index

[hackers] [lchat] lchat.1: mention modes briefly || Tom Schwindl

commit 6dd484ff2d2a417037e56a205fc5ae22adaa6335 Author: Tom Schwindl AuthorDate: Wed Jan 11 08:56:10 2023 +0100 Commit: Jan Klemkow CommitDate: Tue Jan 24 16:59:40 2023 +0100 lchat.1: mention modes briefly diff --git a/lchat.1 b/lchat.1 index df6b6ae..ebd172f 100644 --- a/lchat.1