Re: [hackers] [dwm][PATCH] spawn: reduce 2 lines, change fprintf() + perror() + exit() to die("... :")

2022-08-02 Thread Hiltjo Posthuma
On Fri, Jul 29, 2022 at 06:26:04PM -0500, explosion0men...@gmail.com wrote: > From: explosion-mental > > when calling die and the last character of the string corresponds to > ':', die() will call perror(). See util.c > > Cuz muh lines of code!1 > --- > dwm.c | 4 +--- > 1 file changed, 1

Re: [hackers] [dwm][PATCH] spawn: reduce 2 lines, change fprintf() + perror() + exit() to die("... :")

2022-07-31 Thread NRK
On Sun, Jul 31, 2022 at 01:00:27AM +0200, Laslo Hunhold wrote: > as far as I can tell this is not correct, given the program exits with > EXIT_SUCCESS, not EXIT_FAILURE. Any specific reason why this matters? If exec(3) fails, I would assume a non-zero exit status would be more appropriate.

Re: [hackers] [dwm][PATCH] spawn: reduce 2 lines, change fprintf() + perror() + exit() to die("... :")

2022-07-30 Thread Laslo Hunhold
On Fri, 29 Jul 2022 18:26:04 -0500 explosion0men...@gmail.com wrote: Dear explosion0mental, > when calling die and the last character of the string corresponds to > ':', die() will call perror(). See util.c > > Cuz muh lines of code!1 > - fprintf(stderr, "dwm: execvp %s", ((char >

Re: [hackers] [dwm][PATCH] spawn: reduce 2 lines, change fprintf() + perror() + exit() to die("... :")

2022-07-30 Thread Hiltjo Posthuma
On Fri, Jul 29, 2022 at 06:26:04PM -0500, explosion0men...@gmail.com wrote: > From: explosion-mental > > when calling die and the last character of the string corresponds to > ':', die() will call perror(). See util.c > > Cuz muh lines of code!1 > --- > dwm.c | 4 +--- > 1 file changed, 1

[hackers] [dwm][PATCH] spawn: reduce 2 lines, change fprintf() + perror() + exit() to die("... :")

2022-07-29 Thread explosion0mental
From: explosion-mental when calling die and the last character of the string corresponds to ':', die() will call perror(). See util.c Cuz muh lines of code!1 --- dwm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dwm.c b/dwm.c index b3c43ee..538b8fe 100644 --- a/dwm.c