Hey, where are you getting these e-mail diffs from? Am I not subscribed to
some Suckless mailing list?
On Sun, 21 Aug 2022 20:09:16 +
HushBugger wrote:
> On Wed, 2022-08-17 at 08:49 +0600, NRK wrote:
> > I think the `s++` should be removed from the for loop and `s` should
> > be incremented as needed inside the loop instead.
>
> Agreed. I've changed it.
Thank you for working out this patch
On Wed, 2022-08-17 at 08:49 +0600, NRK wrote:
> I think the `s++` should be removed from the for loop and `s` should
> be incremented as needed inside the loop instead.
Agreed. I've changed it.
From 4a3190695eb3f728496f7f242ab43dfe23a66518 Mon Sep 17 00:00:00 2001
From: HushBugger
Date: Tue, 16 A
On Tue, Aug 16, 2022 at 08:58:37PM +, HushBugger wrote:
> Thanks, I don't have a lot of practical C experience.
The reason for the cast is because is a poorly designed
library where the caller needs to ensure that the arg is representable
as an `unsigned char` (i.e 0 .. UCHAR_MAX) or as `EOF`
On Tue, 2022-08-16 at 21:32 +0200, Hiltjo Posthuma wrote:
> Haven't tested the patch and not sure it is correct, but if so then
> isxdigit needs a cast using (unsigned char).
Thanks, I don't have a lot of practical C experience. Or experience
with submitting code through email, I seem to have mang
On Tue, Aug 16, 2022 at 05:42:50PM +, HushBugger wrote:
> The format specifier for parsing percent-formatted characters uses
> a maximum number of digits, not an exact number of digits.
>
> If the hex number has only one digit this will skip a character,
> potentially pointing past the termina
The format specifier for parsing percent-formatted characters uses
a maximum number of digits, not an exact number of digits.
If the hex number has only one digit this will skip a character,
potentially pointing past the terminating null byte.
---
http.c | 3 ++-
1 file changed, 2 insertions(+),