Re: [hackers] [slock] [PATCHSET] Some improvements and more security

2016-09-20 Thread Markus Teich
FRIGN wrote: > I sat down this evening to write down some patches that have been floating > around in my head for a while. Heyho, thanks for the patches. > Subject: [PATCH 1/3] Localize and rework data structures > … > -typedef struct { > +struct lock { > int screen; > Window root,

Re: [hackers] [slock] [PATCHSET] Some improvements and more security

2016-09-12 Thread FRIGN
On Mon, 12 Sep 2016 13:13:39 +0200 Quentin Rameau wrote: Hey Quentin, > That was just one example of the rest of the complexity it brings in > here. it just stops hiding the fact that readpw() does many things at once. It would make sense to split this function apart a bit,

Re: [hackers] [slock] [PATCHSET] Some improvements and more security

2016-09-12 Thread Quentin Rameau
> > First patch: > > - I agree with the structuring of the xrandr part, good! > > - But not with the localization of every data, they're used across > > the whole program and you're just over-complicating functions here > > imho. The program is simple and clear enough not to have to get > > triple

Re: [hackers] [slock] [PATCHSET] Some improvements and more security

2016-09-12 Thread FRIGN
On Mon, 12 Sep 2016 12:20:51 +0200 Quentin Rameau wrote: Hey Quentin, > First patch: > - I agree with the structuring of the xrandr part, good! > - But not with the localization of every data, they're used across the > whole program and you're just over-complicating

Re: [hackers] [slock] [PATCHSET] Some improvements and more security

2016-09-11 Thread FRIGN
On Sun, 11 Sep 2016 23:24:20 +0200 FRIGN wrote: > See attached. Most important is the patch which removes the > abomination of user $USER which actually poses quite a risk and only > is done on part of the systems. So you can test this, do the following $ unset USER

[hackers] [slock] [PATCHSET] Some improvements and more security

2016-09-11 Thread FRIGN
Good evening fellow hackers, I sat down this evening to write down some patches that have been floating around in my head for a while. See attached. Most important is the patch which removes the abomination of user $USER which actually poses quite a risk and only is done on part of the systems.