Re: [hackers] [slstatus][PATCH] backlight: implemented openbsd support

2018-05-25 Thread David Demelier
On Thu, 2018-05-24 at 14:55 +0200, Aaron Marcher wrote: > Hi, > > > i have implemented basic support for the backlight function on > > OpenBSD. The problem here is that /dev/ttyC0 permission is 600 > > (root:wheel) so a user cannot read from the device without > > changing > > the permission

Re: [hackers] [slstatus][PATCH] backlight: implemented openbsd support

2018-05-24 Thread Tobias Tschinkowitz
On Thu, May 24, 2018 at 02:55:28PM +0200, Aaron Marcher wrote: > Hi, > > > i have implemented basic support for the backlight function on OpenBSD. > > The problem here is that /dev/ttyC0 permission is 600 (root:wheel) so a > > user cannot read from the device without changing the permission or >

Re: [hackers] [slstatus][PATCH] backlight: implemented openbsd support

2018-05-24 Thread Aaron Marcher
Hi, i have implemented basic support for the backlight function on OpenBSD. The problem here is that /dev/ttyC0 permission is 600 (root:wheel) so a user cannot read from the device without changing the permission or running slstatus as root. Running slstatus as root is no real option -

Re: [hackers] [slstatus][PATCH] backlight: implemented openbsd support

2018-05-24 Thread David Demelier
On Wed, May 23, 2018 at 08:41:17PM +0200, Tobias Tschinkowitz wrote: > Anyway, this is just an proposal. Hopefully there is > another solution to solve this. I know that we could also do this by > linking against xcb-xrandr (like xbacklight does) but i think we should > not do this for now.

Re: [hackers] [slstatus][PATCH] backlight: implemented openbsd support

2018-05-23 Thread Tobias Tschinkowitz
On Wed, May 23, 2018 at 04:30:41PM -0300, lucas wrote: Lucas, > Tobias, > > > See my notes below the commit message of the patch. > > I saw the note just after sending the email. My bad. Still, I think that > slstatus shouldn't be run as root. It would be nice to find a workaround > when

Re: [hackers] [slstatus][PATCH] backlight: implemented openbsd support

2018-05-23 Thread lucas
Tobias, > See my notes below the commit message of the patch. I saw the note just after sending the email. My bad. Still, I think that slstatus shouldn't be run as root. It would be nice to find a workaround when launching X from xenodm. > Updated diff below. > > diff --git

Re: [hackers] [slstatus][PATCH] backlight: implemented openbsd support

2018-05-23 Thread Tobias Tschinkowitz
On Wed, May 23, 2018 at 03:57:37PM -0300, lucas wrote: > Hi Tobias, > > Two notes below > > > diff --git a/components/backlight.c b/components/backlight.c > > index f9c4096..21e06a1 100644 > > --- a/components/backlight.c > > +++ b/components/backlight.c > > @@ -29,4 +29,30 @@ > > > >

Re: [hackers] [slstatus][PATCH] backlight: implemented openbsd support

2018-05-23 Thread lucas
Hi Tobias, Two notes below > diff --git a/components/backlight.c b/components/backlight.c > index f9c4096..21e06a1 100644 > --- a/components/backlight.c > +++ b/components/backlight.c > @@ -29,4 +29,30 @@ > > return bprintf("%d", cur * 100 / max); > } > + > +#elif

[hackers] [slstatus][PATCH] backlight: implemented openbsd support

2018-05-23 Thread Tobias Tschinkowitz
implemented openbsd support for the backlight function. this only works when running slstatus as superuser. --- Hi Guys, i have implemented basic support for the backlight function on OpenBSD. The problem here is that /dev/ttyC0 permission is 600 (root:wheel) so a user cannot read from the