Re: [hackers] [slstatus] Simplify Makefile

2017-09-18 Thread Quentin Rameau
> Dear Laslo, dear Quentin, Hi Aaron, > > why not just the following? Thanks for bringing the topic up; for > > some reason I had in mind that it was necessary to list the > > dependencies explicitly. > > I will merge this patch as it has the required dependency on > slstatus.o and it is

[hackers] [slstatus] Simplify Makefile || Laslo Hunhold

2017-09-18 Thread git
commit f56e50a2694e92d972a060d71b2f80c72fd23365 Author: Laslo Hunhold AuthorDate: Sun Sep 17 23:48:11 2017 +0200 Commit: Aaron Marcher CommitDate: Mon Sep 18 08:47:54 2017 +0200 Simplify Makefile diff --git a/Makefile b/Makefile index d657981..505b526

Re: [hackers] [slstatus] Simplify Makefile

2017-09-18 Thread Aaron Marcher
Dear Laslo, dear Quentin, why not just the following? Thanks for bringing the topic up; for some reason I had in mind that it was necessary to list the dependencies explicitly. I will merge this patch as it has the required dependency on slstatus.o and it is generally simpler. Thank you

Re: [hackers] [slstatus] Simplify Makefile

2017-09-17 Thread Laslo Hunhold
On Sun, 17 Sep 2017 23:02:43 +0200 Quentin Rameau wrote: Dear Quentin, > why not just the following? Thanks for bringing the topic up; for some reason I had in mind that it was necessary to list the dependencies explicitly. With best regards Laslo Hunhold -- Laslo

Re: [hackers] [slstatus] Simplify Makefile

2017-09-17 Thread Quentin Rameau
On Sun, 17 Sep 2017 22:29:42 +0100 Matthew Parnell wrote: > Hi Quentin, Hi Matthew, > I like this simplification a lot, I believe it covers the dependency > resolution that Laslo pointed out earlier today; and yet cleans things > up nicely. > I'd very much like to see this

[hackers] [slstatus] Simplify Makefile

2017-09-17 Thread Quentin Rameau
--- Makefile | 37 ++--- 1 file changed, 10 insertions(+), 27 deletions(-) diff --git a/Makefile b/Makefile index d657981..3d116ba 100644 --- a/Makefile +++ b/Makefile @@ -4,9 +4,10 @@ include config.mk -REQ = util HDR = arg.h config.h COM =\ + util\

Re: [hackers] [slstatus] Simplify Makefile

2017-09-17 Thread Matthew Parnell
Hi Quentin, I like this simplification a lot, I believe it covers the dependency resolution that Laslo pointed out earlier today; and yet cleans things up nicely. I'd very much like to see this merged. Cheers, -- Matthew Parnell m...@parnmatt.co.uk

[hackers] [slstatus] Simplify Makefile

2017-09-17 Thread Quentin Rameau
--- Makefile | 25 - 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/Makefile b/Makefile index d657981..fc80ab1 100644 --- a/Makefile +++ b/Makefile @@ -7,6 +7,7 @@ include config.mk REQ = util HDR = arg.h config.h COM =\ + $(REQ)\ battery\