Re: Re: [hackers] [PATCH v3][sbase] libutil/unescape.c: simplify and add \E

Mattias Andrée wrote: > On Mon, 06 Feb 2017 15:05:32 -0800 > evan.ga...@gmail.com (Evan Gates) wrote: > > > Mattias Andrée wrote: > > > > > + } else if (escapes[*r & 255]) { > > > + *w++ = escapes[*r++ & 255]; > > > > Why do you &

Re: [hackers] [PATCH v3][sbase] libutil/unescape.c: simplify and add \E

On Mon, 06 Feb 2017 15:50:04 -0800 evan.ga...@gmail.com (Evan Gates) wrote: > Mattias Andrée wrote: > > > On Mon, 06 Feb 2017 15:05:32 -0800 > > evan.ga...@gmail.com (Evan Gates) wrote: > > > > > Mattias Andrée wrote: > > > > > > > + } else

[hackers] [scc] [cc1] Remove popctx() from compound() || Roberto E. Vargas Caballero

commit a84618bba7d82a3c2cd9f96bcf12344199174761 Author: Roberto E. Vargas Caballero AuthorDate: Mon Feb 6 16:45:05 2017 +0100 Commit: Roberto E. Vargas Caballero CommitDate: Mon Feb 6 16:45:05 2017 +0100 [cc1] Remove popctx() from compound()

[hackers] [scc] [cc1] Fix code.c in linux || Roberto E. Vargas Caballero

commit eb30e9795a8b09179fac633a02d866428b7adb78 Author: Roberto E. Vargas Caballero AuthorDate: Mon Feb 6 14:21:03 2017 +0100 Commit: Roberto E. Vargas Caballero CommitDate: Mon Feb 6 14:21:03 2017 +0100 [cc1] Fix code.c in linux Stdout

Re: [hackers] [PATCH][sbase] libutil/unescape.c: only print argv0 once on error

Mattias Andrée wrote: > Signed-off-by: Mattias Andrée > --- > libutil/unescape.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libutil/unescape.c b/libutil/unescape.c > index 90a62c3..d1503e6 100644 > --- a/libutil/unescape.c

Re: [hackers] [PATCH][sbase] libutil/unescape.c: add \E and simplify \x

On Mon, Feb 6, 2017 at 1:35 PM, Mattias Andrée wrote: > > I don't really have a prefers. OK, applied with that small change. Thanks.

Re: [hackers] [PATCH v3][sbase] libutil/unescape.c: simplify and add \E

Mattias Andrée wrote: > + } else if (escapes[*r & 255]) { > + *w++ = escapes[*r++ & 255]; Why do you & 255 here? I think a cast to unsigned char would accomplish what you are trying to do and be more correct (as char can default to either signed

Re: [hackers] [PATCH v3][sbase] libutil/unescape.c: simplify and add \E

On Mon, 06 Feb 2017 15:05:32 -0800 evan.ga...@gmail.com (Evan Gates) wrote: > Mattias Andrée wrote: > > > + } else if (escapes[*r & 255]) { > > + *w++ = escapes[*r++ & 255]; > > Why do you & 255 here? I think a cast to unsigned char > would

Re: [hackers] [PATCH][sbase] libutil/unescape.c: add \E and simplify \x

On Sat, Feb 4, 2017 at 1:32 PM, Mattias Andrée wrote: > @@ -39,10 +39,8 @@ unescape(char *s) > off += m - i - 1; > for (--m, q = 0, factor = 1; m > i + 1; m--) { > - if (s[m] >= '0' && s[m] <= '9') > -

Re: [hackers] [PATCH][sbase] libutil/unescape.c: add \E and simplify \x

On Mon, 6 Feb 2017 13:29:54 -0800 Evan Gates wrote: > On Sat, Feb 4, 2017 at 1:32 PM, Mattias Andrée > wrote: > > @@ -39,10 +39,8 @@ unescape(char *s) > > off += m - i - 1; > > for (--m, q = 0, factor = 1; m

Re: Re: [hackers] [sbase][PATCH] Fixed a couple of uninitialised variable warnings from Clang

Hiltjo Posthuma wrote: > Probably a false positive, but for ed.c it looks ok to me. > > The join.c patch does not look ok to me (clang doesn't detect that > eprintf() exists the program), so it's a false positive. This is where the _Noreturn or noreturn attribute is

Re: [hackers] [PATCH][sbase] libutil/unescape.c: add \E and simplify \x

On Mon, Feb 6, 2017 at 1:38 PM, Evan Gates wrote: > On Mon, Feb 6, 2017 at 1:35 PM, Mattias Andrée wrote: >> >> I don't really have a prefers. > > OK, applied with that small change. Thanks. Sorry, I just realized I was reading through these in the wrong