Re: [hackers] More forgotten sbase/ubase patches

2017-08-22 Thread Michael Forney
On 2017-08-22, Hiltjo Posthuma wrote: > Thanks for your patches and the reminder. I've applied the patches. Thanks, Hiltjo! > Let me know if there are other patches that can be applied. I think that's all the patches I've sent to the list. > Sorry for the delay, sbase

[hackers] [blind] Add blind-peek-head || Mattias Andrée

2017-08-22 Thread git
commit 23100155b5d0ecbf95a8d1c4fa8d02557b69de94 Author: Mattias Andrée AuthorDate: Wed Aug 23 00:39:26 2017 +0200 Commit: Mattias Andrée CommitDate: Wed Aug 23 00:39:26 2017 +0200 Add blind-peek-head Signed-off-by: Mattias Andrée

Re: [hackers] [sbase][PATCH] ls: abort a directory if we cannot opendir it

2017-08-22 Thread Quentin Rameau
> Sorry, I should have made the commit message clearer. It is > not the entire operation that is being aborted, but only the > current node, if it cannot be opened. Ah, right! > Before this patch, ls will segfault since it tries to perform > operations on a (null) DIR*. After this patch, it

Re: [hackers] [sbase][PATCH] ls: abort a directory if we cannot opendir it

2017-08-22 Thread Quentin Rameau
Hello David, > We should not try and perform operations on an invalid DIR* stream. > Instead, we shall let the error message be printed, and the return > code set (existing behaviour) and abort afterwards. Any justification you could provide us with? AFAIK POSIX specifies the opposite, a

Re: [hackers] [sbase][PATCH] ls: abort a directory if we cannot opendir it

2017-08-22 Thread David Phillips
Sorry, I should have made the commit message clearer. It is not the entire operation that is being aborted, but only the current node, if it cannot be opened. Before this patch, ls will segfault since it tries to perform operations on a (null) DIR*. After this patch, it prints the message, sets

Re: [hackers] More forgotten sbase/ubase patches

2017-08-22 Thread Hiltjo Posthuma
On Fri, Aug 11, 2017 at 09:01:01PM -0700, Michael Forney wrote: > I went looking through my sbase/ubase branches and found some more > forgotten patches. > > = sbase = > * http://lists.suckless.org/hackers/1702/14283.html > > sbase tar still needs a lot of work, but currently it is frustrating >

[hackers] [ubase] passwd: Use a random salt when encrypting passwords || Michael Forney

2017-08-22 Thread git
commit fae9ca81a2eaf3534299b7ca3033b1e6605f9ab2 Author: Michael Forney AuthorDate: Sun Oct 23 20:59:51 2016 -0700 Commit: Hiltjo Posthuma CommitDate: Tue Aug 22 13:36:56 2017 +0200 passwd: Use a random salt when encrypting passwords diff

[hackers] [ubase] mount: Don't pass {,no}auto to kernel || Michael Forney

2017-08-22 Thread git
commit 3a5939e81018a05d710d0f3c8cea8794dd8a1637 Author: Michael Forney AuthorDate: Sun Oct 23 14:00:29 2016 -0700 Commit: Hiltjo Posthuma CommitDate: Tue Aug 22 13:36:28 2017 +0200 mount: Don't pass {,no}auto to kernel diff --git

[hackers] [sbase] ls: abort a directory if we cannot opendir it || David Phillips

2017-08-22 Thread git
commit 46495ea902071bd0b2397c5cad4d49ec22d491f9 Author: David Phillips AuthorDate: Tue Aug 22 16:51:37 2017 +1200 Commit: Hiltjo Posthuma CommitDate: Tue Aug 22 13:33:40 2017 +0200 ls: abort a directory if we cannot opendir it We

[hackers] [sbase] tar: Explain reason for malformed header || Michael Forney

2017-08-22 Thread git
commit 772a40188bf1c8a2612ac13967bad94228c561a4 Author: Michael Forney AuthorDate: Fri Feb 3 14:56:49 2017 -0800 Commit: Hiltjo Posthuma CommitDate: Tue Aug 22 13:35:29 2017 +0200 tar: Explain reason for malformed header diff --git

Re: [hackers] [sbase][PATCH] ls: abort a directory if we cannot opendir it

2017-08-22 Thread Hiltjo Posthuma
On Tue, Aug 22, 2017 at 04:51:37PM +1200, David Phillips wrote: > We should not try and perform operations on an invalid DIR* stream. > Instead, we shall let the error message be printed, and the return > code set (existing behaviour) and abort afterwards. > --- > ls.c | 1 + > 1 file changed, 1