[hackers] [PATCH] make: fix rogue parameter in install target

--- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 8da0106..95bb21d 100644 --- a/Makefile +++ b/Makefile @@ -219,11 +219,11 @@ getconf.h: scripts/getconf.sh > $@ install uninstall: - scripts/mkproto $@

Re: [hackers] [PATCH 2/2] scripts: Fix non-portable find -perm /mode

> > I guess that the original intent of the code here > > was to to find any executable file. > > I concur. It seems to me that the default output mode for `cc` is 755 > even if the parent directory has more restrictive permissions. So the > more concise -perm -111 should suffice. I will leave

Re: [hackers] [PATCH 2/2] scripts: Fix non-portable find -perm /mode

> Not exactly, -perm -111 matches if at least the mode has executable bit > for all (could be 751 for example), > while GNU -perm /111 matches if any bit is set (could be 500). Thanks for the info, I didn't really check the GNU manpage. > I guess that the original intent of the code here > was

[hackers] [PATCH] scripts: Force file copying on install

This would otherwise cause an issue using cp to copy cp to itself. --- scripts/install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/install b/scripts/install index b391715..ce78c1d 100755 --- a/scripts/install +++ b/scripts/install @@ -9,7 +9,7 @@ do

[hackers] [PATCH 2/2] scripts: Fix non-portable find -perm /mode

--- scripts/mkproto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mkproto b/scripts/mkproto index ab0ade4..192fe56 100755 --- a/scripts/mkproto +++ b/scripts/mkproto @@ -14,7 +14,7 @@ trap "rm -f scripts/proto" EXIT INT QUIT TERM (set -e echo d $prefix/bin

[hackers] [PATCH 1/2] scripts: Fix non-portable usage of find -maxdepth

--- scripts/mkproto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/mkproto b/scripts/mkproto index 0b2deb3..ab0ade4 100755 --- a/scripts/mkproto +++ b/scripts/mkproto @@ -14,11 +14,11 @@ trap "rm -f scripts/proto" EXIT INT QUIT TERM (set -e echo d $prefix/bin

Re: [hackers] [PATCH 2/2] scripts: Fix non-portable find -perm /mode

Hi Quentin, > -find . ! -name . -prune -type f -perm /111 | > +find . ! -name . -prune -type f \( -perm -u+x -o -perm -g+x -o -perm o+x \) | I believe `-perm -111` is equivalent and specified by POSIX. - Randy

Re: [hackers] [PATCH 2/2] scripts: Fix non-portable find -perm /mode

> Hi Quentin, Hola Randy, > > -find . ! -name . -prune -type f -perm /111 | > > +find . ! -name . -prune -type f \( -perm -u+x -o -perm -g+x -o -perm o+x > > \) | > > I believe `-perm -111` is equivalent and specified by POSIX. Not exactly, -perm -111 matches if at least the mode has

[hackers] [PATCH] find: Make parameter error messages more specific

Differenciate option operands from path operands when an error is detected on the command line parameters. --- find.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/find.c b/find.c index d4d7864..ef28232 100644 --- a/find.c +++ b/find.c @@ -809,8 +809,12 @@ parse(int

[hackers] [sbase] TODO: add replacement bug reported for ed || Hiltjo Posthuma

commit 0a82a7d91a039b41f861e399a74da8f7073ed59f Author: Hiltjo Posthuma AuthorDate: Sun Oct 29 17:48:13 2023 +0100 Commit: Hiltjo Posthuma CommitDate: Sun Oct 29 17:48:13 2023 +0100 TODO: add replacement bug reported for ed Also reported on IRC: "escaping the