Re: [hackers] [ubase][PATCH 3/5] mount: Typofix

On Mon, Jul 11, 2016 at 02:27:58PM +0200, Klemens Nanni wrote: > --- > mount.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mount.c b/mount.c > index 1f17789..1696219 100644 > --- a/mount.c > +++ b/mount.c > @@ -54,7 +54,7 @@ findtype(const char *types, const char

Re: [hackers] [ubase][PATCH 2/5] mount: Indent/align properly

Hi Klemens, > --- > mount.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/mount.c b/mount.c > index e70c7d1..1f17789 100644 > --- a/mount.c > +++ b/mount.c > @@ -47,10 +47,9 @@ findtype(const char *types, const char *t) > const char *p; > size_t

Re: [hackers] [ubase][PATCH 1/5] mount: Use ternary operators

The second hunk actually breaks it by setting either fsopts or dirname but never both, so please ignore that one. signature.asc Description: PGP signature

[hackers] [ubase][PATCH 5/5] mount: Simplify exit logic

--- mount.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mount.c b/mount.c index d0b2fd8..529ee86 100644 --- a/mount.c +++ b/mount.c @@ -124,9 +124,8 @@ mounthelper(const char *fsname, const char *dir, const char *fstype) eargv[i] = NULL;

[hackers] [ubase][PATCH 3/5] mount: Typofix

--- mount.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mount.c b/mount.c index 1f17789..1696219 100644 --- a/mount.c +++ b/mount.c @@ -54,7 +54,7 @@ findtype(const char *types, const char *t) } static void -parseopts(const char *popts, unsigned long *flags, char *d

[hackers] [ubase][PATCH 1/5] mount: Use ternary operators

--- mount.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/mount.c b/mount.c index 2eb175c..e70c7d1 100644 --- a/mount.c +++ b/mount.c @@ -64,10 +64,7 @@ parseopts(const char *popts, unsigned long *flags, char *data, size_t datasiz) name = popts;

[hackers] [ubase][PATCH 2/5] mount: Indent/align properly

--- mount.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/mount.c b/mount.c index e70c7d1..1f17789 100644 --- a/mount.c +++ b/mount.c @@ -47,10 +47,9 @@ findtype(const char *types, const char *t) const char *p; size_t len; - for (len = strl

[hackers] [ubase][PATCH 4/5] mount: Fix ambigious if statement

--- mount.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mount.c b/mount.c index 1696219..d0b2fd8 100644 --- a/mount.c +++ b/mount.c @@ -253,9 +253,10 @@ main(int argc, char *argv[]) target = me->mnt_dir;