Re: [hackers] [dmenu][PATCH] Output the element's position in the list instead of his name

2017-03-30 Thread Hiltjo Posthuma
On Thu, Mar 30, 2017 at 01:40:36PM +0200, Matteo Alessio Carrara wrote: >This patch facilitates writing wrappers to dmenu, because to understand >what has been selected by comparing strings is slower than using the >index of an array. Furthermore avoids ambiguity in the case that there

Re: [hackers] [farbfeld] Make Makefile strictly POSIX compliant || Laslo Hunhold

2017-03-30 Thread Hiltjo Posthuma
On Thu, Mar 30, 2017 at 08:44:34AM +0200, g...@suckless.org wrote: > commit bbe28227eb80da62fec59aa79ba7a97f5c3937b4 > Author: Laslo Hunhold > AuthorDate: Thu Mar 30 08:41:17 2017 +0200 > Commit: Laslo Hunhold > CommitDate: Thu Mar 30 08:43:42 2017 +0200 >

Re: [hackers] [farbfeld] Makefile: target should depend on its object

2017-03-30 Thread Laslo Hunhold
On Thu, 30 Mar 2017 15:55:25 +0200 Quentin Rameau wrote: Hey Quentin, > Well, it's not “wrong” per se, but indeed it makes binaries depend on > all objects. > That's something you can't work around with the way you seem to > want to write your Makefile. > > The more correct

Re: [hackers] [farbfeld] Makefile: target should depend on its object

2017-03-30 Thread Quentin Rameau
From 94d6e290f97b78de4c36da820f38a9b10822bda3 Mon Sep 17 00:00:00 2001 From: Quentin Rameau Date: Thu, 30 Mar 2017 15:51:28 +0200 Subject: [PATCH] Makefile: target should depend on its object --- Makefile | 29 +++-- 1 file changed, 19 insertions(+),

Re: [hackers] [farbfeld] Makefile: target should depend on its object

2017-03-30 Thread Quentin Rameau
> I think your fix is incorrect. A single program like ff2png does not > depend on ff2jpg.o or any other object other than ff2png.o. > I'll look at it later, so if I'm wrong I'll merge it. Well, it's not “wrong” per se, but indeed it makes binaries depend on all objects. That's something you

Re: [hackers] [farbfeld] Makefile: target should depend on its object

2017-03-30 Thread Laslo Hunhold
On Thu, 30 Mar 2017 11:26:39 +0200 Quentin Rameau wrote: Hey Quentin, > -$(BIN): $(REQ:=.o) > +$(BIN): $(BIN:=.o) $(REQ:=.o) I think your fix is incorrect. A single program like ff2png does not depend on ff2jpg.o or any other object other than ff2png.o. I'll look at it

[hackers] [dmenu][PATCH] Output the element's position in the list instead of his name

2017-03-30 Thread Matteo Alessio Carrara
This patch facilitates writing wrappers to dmenu,because to understand what has been selected by comparing strings is slower than using the index of an array. Furthermore avoids ambiguity in the case that there were two elements with the same name in the input elements. diff --git a/dmenu.1

Re: [hackers] [farbfeld] Overhaul Build-system || Laslo Hunhold

2017-03-30 Thread Quentin Rameau
Hi Laslo, > > > -PNGLIB = /usr/local/lib > > > -PNGINC = /usr/local/include > > > - > > > -JPGLIB = /usr/local/lib > > > -JPGINC = /usr/local/include > > > > Personally I think it's useful to have these separated. It is also > > useful to specify PNGINC, JPGINC etc separately for building in >

[hackers] [farbfeld] Add util.{c|h} to deduplicate code || Laslo Hunhold

2017-03-30 Thread git
commit d25f3c73afa5beb83121c9b033bc0146c755ca3a Author: Laslo Hunhold AuthorDate: Thu Mar 30 09:49:48 2017 +0200 Commit: Laslo Hunhold CommitDate: Thu Mar 30 09:49:48 2017 +0200 Add util.{c|h} to deduplicate code diff --git a/ff2jpg.c b/ff2jpg.c index

[hackers] [farbfeld] Mark explicit dependency on requisites for BIN || Laslo Hunhold

2017-03-30 Thread git
commit d0ce307972fbc95073666e92043fc7012ffbefdf Author: Laslo Hunhold AuthorDate: Thu Mar 30 09:29:06 2017 +0200 Commit: Laslo Hunhold CommitDate: Thu Mar 30 09:29:06 2017 +0200 Mark explicit dependency on requisites for BIN diff --git a/Makefile

[hackers] [farbfeld] No need to keep the implicit build rule || Laslo Hunhold

2017-03-30 Thread git
commit ef433a6baa3449f5a5ec7a6fd09efdd0ea6fb57b Author: Laslo Hunhold AuthorDate: Thu Mar 30 08:52:22 2017 +0200 Commit: Laslo Hunhold CommitDate: Thu Mar 30 08:52:22 2017 +0200 No need to keep the implicit build rule diff --git a/Makefile b/Makefile

[hackers] [farbfeld] Pass LDFLAGS instead of CFLAGS in the linking stage || Laslo Hunhold

2017-03-30 Thread git
commit 0aaa36464a4ad965a3d747cc6df16137c7b5d6c5 Author: Laslo Hunhold AuthorDate: Thu Mar 30 08:59:52 2017 +0200 Commit: Laslo Hunhold CommitDate: Thu Mar 30 08:59:52 2017 +0200 Pass LDFLAGS instead of CFLAGS in the linking stage diff --git a/Makefile

[hackers] [farbfeld] Make Makefile strictly POSIX compliant || Laslo Hunhold

2017-03-30 Thread git
commit bbe28227eb80da62fec59aa79ba7a97f5c3937b4 Author: Laslo Hunhold AuthorDate: Thu Mar 30 08:41:17 2017 +0200 Commit: Laslo Hunhold CommitDate: Thu Mar 30 08:43:42 2017 +0200 Make Makefile strictly POSIX compliant Thanks Hiltjo for the