Re: [hackers] [surf][PATCH 2/2] webext: use flags for gio-unix rather than gio

2022-10-23 Thread NRK
Hi Quentin, > On my system, gio-unix symbols are provided by the gio library, > is that different on your system? > If so, could you provide the contents of pkg-config cflags and libs > for gio-unix-2.0? In the "old documentation" [0] I see the following: | Note that belongs to the

Re: [hackers] [st][PATCH] Fix buffer overflow when handling composed input

2022-10-23 Thread NRK
> On Sun, Oct 23, 2022 at 04:18:42PM +, Andy Gozas wrote: > > St relies on an incorrect assumption of how XmbLookupString function > > behaves. Looking at the XmbLookupString manpage [0] reveals more trouble. It seems that `ksym` might be used uninitalized as well. Inlined a proprosed patch.

Re: [hackers] [st][PATCH] Fix buffer overflow when handling composed input

2022-10-23 Thread Andy Gozas
On 2022-10-23 05:34 PM, Hiltjo Posthuma wrote: Can you provide a minimal reproducable-case with your configuration for this issue? It would help a lot in reviewing this issue. Yes, of course. If you already have the multi-key enabled on your system, then add this line to your ~/.XCompose

Re: [hackers] [st][PATCH] Fix buffer overflow when handling composed input

2022-10-23 Thread Hiltjo Posthuma
On Sun, Oct 23, 2022 at 04:18:42PM +, Andy Gozas wrote: > This is a fix for a problem with ST that I found. > > St relies on an incorrect assumption of how XmbLookupString function > behaves. When a composed input comes with a string that can not fit into the > buffer that was given to it —

Re: [hackers] [st][PATCH] Fix buffer overflow when handling composed input

2022-10-23 Thread Andy Gozas
This is a fix for a problem with ST that I found. St relies on an incorrect assumption of how XmbLookupString function behaves. When a composed input comes with a string that can not fit into the buffer that was given to it — it doesn't fill it however much it can, and then return exactly how

[hackers] [st][PATCH] Fix buffer overflow when handling composed input

2022-10-23 Thread Andy Gozas
--- x.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/x.c b/x.c index 2a3bd38..8d14fc1 100644 --- a/x.c +++ b/x.c @@ -1834,8 +1834,10 @@ kpress(XEvent *ev) { XKeyEvent *e = >xkey; KeySym ksym; - char buf[64],