Re: [hackers] [sbase][PATCH] Add implementation of tac(1)

2024-03-07 Thread Roberto E. Vargas Caballero
Hi, As this is a topic more about sbase/ubase organization more than about patches I am going to move the discussion to the dev mailing list. Please, answer there instead of here in hackers. Regards,

Re: [hackers] [sbase][PATCH] Add implementation of tac(1)

2024-03-07 Thread Roberto E. Vargas Caballero
Hi, I was thinking about what to do with these patches adding new commands. They raised a concern about what should be the scope of sbase. The idea of sbase was to provide a minimal portable POSIX base, while having ubase for the POSIX commands that cannot be implemented in a portable way.

[hackers] [sbase][PATCH] tar: support hardlinks during compression

2024-03-07 Thread Andrea Calligaris
This patch depends on: "tar: fix long names crashing tar archiving" https://lists.suckless.org/hackers/2402/19071.html I just did the simplest possible implementation, in order to have at least something (it's a feature of 'tar' that I do actually use in my projects, so I needed it). Insights for

Re: [hackers] [ubase][PATCH 1/4] su: simplify logic

2024-03-07 Thread Roberto E. Vargas Caballero
Hi, On Thu, Mar 07, 2024 at 02:52:49PM -0500, neeshy wrote: > On Thu Mar 7, 2024 at 1:19 PM EST, Roberto E. Vargas Caballero wrote: > > I think it makes it simpler while keeping the correct behaviour that I > > broke. > > Looks good to me! Pushed!

[hackers] [ubase] su: Fix running it without arguments The commit 8f5a0c3 introduced a regression and the logic to control the number of arguments was broken after it, giving an error when su was exec

2024-03-07 Thread git
commit a570a80ed1606bed43118cb148fc83c3ac22b5c1 Author: Roberto E. Vargas Caballero AuthorDate: Thu Mar 7 22:35:31 2024 +0100 Commit: Roberto E. Vargas Caballero CommitDate: Thu Mar 7 22:35:31 2024 +0100 su: Fix running it without arguments The commit 8f5a0c3 introduced a

[hackers] [sbase][PATCH] cron: fix '~' range parsing

2024-03-07 Thread Elie Le Vaillant
'~' after number was recognized as abnormal. --- cron.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cron.c b/cron.c index 9da0c8a..18ee8b1 100644 --- a/cron.c +++ b/cron.c @@ -252,7 +252,7 @@ parserange(char *str, long low, long high, struct range *r)

Re: [hackers] [ubase][PATCH 1/4] su: simplify logic

2024-03-07 Thread neeshy
On Thu Mar 7, 2024 at 1:19 PM EST, Roberto E. Vargas Caballero wrote: > I think it makes it simpler while keeping the correct behaviour that I broke. Looks good to me!

Re: [hackers] [ubase][PATCH 1/4] su: simplify logic

2024-03-07 Thread Roberto E. Vargas Caballero
Hi, On Thu, Mar 07, 2024 at 02:18:28AM -0500, neeshy wrote: > It seems that the modifications you made break the use case where su is > called without a username. It would normally default to the root > user, but now it invokes usage() instead. My original patch worked as > intended. Could you

[hackers] [sbase][PATCH] libutil/random: cast to long to avoid overflow

2024-03-07 Thread Elie Le Vaillant
Thanks NRK --- libutil/random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libutil/random.c b/libutil/random.c index d5214ae..aa98d61 100644 --- a/libutil/random.c +++ b/libutil/random.c @@ -67,7 +67,7 @@ rng32_seed_r(uint64_t *state) { struct timespec ts;