Re: [hackers] Re: [sbase][ubase] maintainers

Hi Evan, On 8 September 2017 at 18:07, Evan Gates wrote: > And I see that maintainership has been passed to Michael Forney now > (probably should have checked that before sending the previous email. > In that case, Michael I'd like to help get up to date with patches. > Let

Re: [hackers] [dwm][PATCH] move config data to read-only sections

Hi Jo, On 6 September 2017 at 21:04, <joachim.he...@t-systems.com> wrote: >> From: Anselm R Garbe [garb...@gmail.com] >> Sent: Wednesday, September 6, 2017 7:38 PM >> To: hackers mail list >> Subject: Re: [hackers] [dwm][PATCH] move config data to read-only s

Re: [hackers] [dwm][PATCH] move config data to read-only sections

d, Sep 06, 2017 at 05:07:06PM +0200, Anselm R Garbe wrote: >> Hi Joachim, >> >> On 6 September 2017 at 17:02, <joachim.he...@t-systems.com> wrote: >> > commit 6a5056d4c919bb5ae0222b2fde0ed787d50092cf >> > Author: Joachim Henke <joachim

Re: [hackers] [dwm][PATCH] move config data to read-only sections

Hi Joachim, On 6 September 2017 at 17:02, wrote: > commit 6a5056d4c919bb5ae0222b2fde0ed787d50092cf > Author: Joachim Henke > AuthorDate: Wed, 6 Sep 2017 16:26:42 +0200 > > The configuration data is just used read-only. So making it

Re: [hackers] [scron] [PATCH 1/3] Just use simple linked list instead of queue.h

On 12 July 2017 at 12:01, Dimitris Papastamos wrote: > On Tue, Jul 11, 2017 at 10:49:53AM -0700, Michael Forney wrote: >> On 7/11/17, Laslo Hunhold wrote: >> > On Mon, 10 Jul 2017 21:55:40 -0700 >> > Michael Forney wrote: >> > >> > Hey Michael,

Re: [hackers] Pending sbase patches

Hi Michael, thanks a lot for the heads up, however I wasn't able to apply: On 14 June 2017 at 19:06, Michael Forney wrote: > # IO > concat: Use plain read/write instead of buffered stdio > http://lists.suckless.org/hackers/1701/14070.html > > cp: Only call chmod with -p or

Re: [hackers] Pending sbase patches

Hi there, On 14 June 2017 at 19:38, Wolfgang Corcoran-Mathe wrote: > Quoth Michael Forney: > It would really be nice for some maintainer to comment on the state > of sbase. Can we expect submitted patches to be evaluated/applied, > or is the project in limbo? If nobody else

Re: [hackers] [PATCH] [9base]: ed: avoid name collision with libc's getline.

On 7 June 2017 at 17:58, Christopher Brannon wrote: > Redefining getline leads to a fun bug when linking statically against musl. > --- > ed/ed.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ed/ed.c b/ed/ed.c > index 85eb455..2627059 100644 > --- a/ed/ed.c >

Re: [hackers] [9base][PATCH] apply changes from https://github.com/9fans/plan9port o

On 20 May 2017 at 10:43, <pranomes...@gmail.com> wrote: > Anselm R Garbe <garb...@gmail.com> wrote: >> Hi pranomostro, >> >> On 20 May 2017 at 01:11, pranomostro <pranomes...@gmail.com> wrote: >> > before applying those changes, rc exited with si

Re: [hackers] [quark] Rewrite quark from the ground up again || Laslo Hunhold

Hi Laslo, On 22 June 2017 at 17:29, Laslo Hunhold <d...@frign.de> wrote: > On Wed, 21 Jun 2017 10:55:20 +0200 > Anselm R Garbe <garb...@gmail.com> wrote: >> I really dislike using lowercase enum and struct names. Types should >> always be easily distinguishable from

Re: [hackers] [quark] Rewrite quark from the ground up again || Laslo Hunhold

Hi there, I appreciate that quark is progressing, however On 20 June 2017 at 21:45, wrote: > -enum stati { > +enum req_field { > +enum req_method { > +struct request { > +enum status { I really dislike using lowercase enum and struct names. Types should always be easily

Re: [hackers] [9base][PATCH] apply changes from https://github.com/9fans/plan9port on rc/havefork.c

Hi pranomostro, On 20 May 2017 at 01:11, pranomostro wrote: > before applying those changes, rc exited with sigsegv when receiving > sigint while executing a command in a subshell (example: rc -c '`{read}'). Thanks for the suggestion, I'm reviewing it. I wonder if it was

Re: [hackers] Repeated usage of m->lt[m->sellt]->arrange deduplication

On 24 April 2017 at 11:56, Snobb wrote: > Completely agree with all points. I generally prefer inline function and > const variables over defines if I can help it. General guidance is not the question here. The suggestion for syntax sugar would only justify a define in the actual

Re: [hackers] Desktop icons in dwm

On 5 April 2017 at 05:40, David Kennedy wrote: > One thing I miss with dwm is shortcut icons on my desktop. Is anyone aware of > a patch that would add those or a really simple desktop app? I found one here > but it's really old and doesn't build: >

Re: [hackers] [dwm] cleanup and bugfixes

On 27 March 2017 at 22:53, Markus Teich <markus.te...@stusta.mhn.de> wrote: > Anselm R Garbe wrote: >> I have reviewed them and I will accept them into mainline. > Great, thanks! :) > > Are you going to push them or should I do it? I git am them today. BR, Anselm

Re: [hackers] [dwm] cleanup and bugfixes

Hi Markus, On 18 March 2017 at 21:40, Markus Teich wrote: > since you seem to review patches right now, here is another reminder for this > dwm patch series. If you currently don't have time to review them, I'd just > push > them to the wiki /patches section in the

Re: [hackers] [st][PATCH] Support xterm Ms feature to set clipboard

On 18 March 2017 at 08:18, Omar Sandoval wrote: > This is used by, e.g., tmux. > --- > st.c| 57 + > st.info | 1 + > 2 files changed, 58 insertions(+) > > diff --git a/st.c b/st.c > index fbcd9e0..f3b8846 100644 >

Re: [hackers] [sic] add support for pledge()

On 8 March 2017 at 14:51, Joerg Jung <m...@umaxx.net> wrote: >> On 22 Aug 2016, at 11:19, Anselm R Garbe <garb...@gmail.com> wrote: >> On 14 August 2016 at 11:11, Hiltjo Posthuma <hil...@codemadness.org> wrote: >>> In general we should try to avoid

Re: [hackers] [dwm] [PATCH] break up long config line

On 5 December 2016 at 15:55, Markus Teich <markus.te...@stusta.mhn.de> wrote: > Markus Teich wrote: >> Anselm R Garbe wrote: >> > Why, are you entering command line options also on separate lines? >> >> Nope, but my command line input mostly is way shorter,

Re: [hackers] [dwm] applied Ivan Delalande's NET_SUPPORTING_WM_CHECK patch for gtk3 compatibility || Anselm R Garbe

Hi Hiltjo, On 5 December 2016 at 10:18, Hiltjo Posthuma wrote: > I think its better to use `git am` next time to apply the original patches. > This way the original author, commit message/reason/explanation is archived > aswell. I agree, but my MUA couldn't detect a

Re: [hackers] [dwm] [PATCH] per client resizehints

Hi Markus, On 27 October 2016 at 14:34, Markus Teich wrote: > here you go. Per client resize hints. Since the client struct is always > initialized with zeroes to preserve behaviour either the meaning has to be > reversed ("ignorehints"?) or a default rule with class,

Re: [hackers] [dwm] [PATCH] don't purge tagset of alternative view on _NET_ACTIVE_WINDOW event

On 27 October 2016 at 15:36, Markus Teich wrote: > Here is the version which sets the urgency hint on receiving > _NET_ACTIVE_WINDOW > messages. There is no real "extra code", but a small refactoring was needed to > stay sane: clearurgent() was renamed to seturgent()

Re: [hackers] [dwm][PATCH] clarify tile layout description in man page

Hi Ian, On 1 December 2016 at 04:20, Ian Remmler wrote: > --- > dwm.1 | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/dwm.1 b/dwm.1 > index 60ca1d6..e3b2c38 100644 > --- a/dwm.1 > +++ b/dwm.1 > @@ -10,8 +10,9 @@ and floating layouts. Either

Re: [hackers] [sbase] [PATCH] xinstall: Fix broken memmove with -t

Hi there, On 2 December 2016 at 13:34, Mattias Andrée wrote: > If it's actually need, the package could call strip on > the binaries that fail, or the developer can call strip > explicitly. If it's even possible symbols could be problem, > it's so rare that it wouldn't be much

Re: [hackers] [dwm] [PATCH] support the NET_SUPPORTING_WM_CHECK EWMH property

Hi there, On 1 December 2016 at 05:59, Eric Pruitt wrote: > On Sat, Nov 26, 2016 at 08:00:01AM +0100, Ivan Delalande wrote: >> This is mostly arg's 762b66a resurrected ("hack that adds >> NET_SUPPORTING_WM_CHECK handling..."), but we have to create a dedicated >> window

Re: [hackers] [dwm] [PATCH] don't purge tagset of alternative view on _NET_ACTIVE_WINDOW event

On 27 October 2016 at 13:29, Markus Teich wrote: > I just came up with an even less intrusive behavior: Instead of additionally > selecting the respective tag, just set the urgency hint on the client and let > the user decide when to handle it. This approach goes in

Re: [hackers] [dwm] [PATCH] get rid of unnecessary ternary operator

On 27 October 2016 at 12:46, Markus Teich <markus.te...@stusta.mhn.de> wrote: > Anselm R Garbe wrote: >> To me ! is logical NOT and your suggestion relies on the fact that >> XUrgencyHint is a single bit flag? no? >> >> I prefer the original code, as it doesn't

Re: [hackers] [dwm] [PATCH] clarify status text padding

Hi Markus, On 27 October 2016 at 12:26, Markus Teich wrote: > now I have. As expected an like before the patch the status bar text gets > overwritten by the tag names. This patch should not introduce new behavior at > all. OK, I will accept this patch. -Anselm

Re: [hackers] More dwm patches

On 27 October 2016 at 13:24, Markus Teich wrote: > - resizehints per client (+1 SLoC): Some old version of mplayer "forced" me to > write this. I don't know if this is still a problem, but the patch might be > usefull regardless. Show me. > - allow no tags to be

Re: [hackers] [dwm] [PATCH] decouple color-scheme count from dwm.c

On 27 October 2016 at 12:34, Markus Teich <markus.te...@stusta.mhn.de> wrote: > Anselm R Garbe wrote: >> Why wouldn't dwm just work fine without this change, if editing config.h >> would >> incorporate assigning SchemeLast with a value instead? Then all the nasty >

Re: [hackers] [dwm] [PATCH] break up long config line

Why, are you entering command line options also on separate lines? On 27 October 2016 at 01:42, Markus Teich wrote: > --- > config.def.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/config.def.h b/config.def.h > index

Re: [hackers] [dwm] [PATCH] get rid of unnecessary ternary operator

To me ! is logical NOT and your suggestion relies on the fact that XUrgencyHint is a single bit flag? no? I prefer the original code, as it doesn't use side effects of logical NOTs. -Anselm On 27 October 2016 at 01:40, Markus Teich wrote: > --- > dwm.c | 2 +- > 1

Re: [hackers] [dwm] [PATCH] decouple color-scheme count from dwm.c

Hi Markus, On 26 October 2016 at 20:30, Markus Teich wrote: > this patch allows for a flexible amount of different colorschemes in config.h > without having to edit dwm.c as well. Applying this upstream would help > patches > like urgentborder and statuscolors with

Re: [hackers] [stali][PATCH] sh is now built as mksh, not lksh

On 24 October 2016 at 15:01, Bruno Vetter wrote: > From: Bruno Vetter Thanks, will be applied today. -Anselm

Re: [hackers] Re: [stali][patch] Change dependency specifications in makefiles

On 15 September 2016 at 10:25, Anselm R Garbe <garb...@gmail.com> wrote: > Hi Evan, > > thanks, looks good. I will apply them later today, Done. -Anselm

Re: [hackers] Re: [stali][patch] Change dependency specifications in makefiles

Hi Evan, thanks, looks good. I will apply them later today, -Anselm On 15 September 2016 at 01:30, Evan Gates wrote: > On Wed, Sep 7, 2016 at 4:29 PM, Evan Gates wrote: >> I've made a lot of changes to the makefiles to specify dependencies >>

Re: [hackers] [9base][patch] check for _LARGEFILE64_SOURCE instead of __USE_LARGEFILE64

On 9 September 2016 at 21:48, Evan Gates wrote: > glibc doesn't define getdents() and requires use of the raw syscall. > As such lib9/dirread.c needed to decide whether to use SYS_getdents or > SYS_getdents64 and was checking if __USE_LARGEFILE64 was defined in > order to do

Re: [hackers] [quark] Use sizeof() instead of magic constants || FRIGN

On 5 September 2016 at 09:50, FRIGN <d...@frign.de> wrote: > On Mon, 5 Sep 2016 09:42:47 +0200 > Anselm R Garbe <garb...@gmail.com> wrote: >> Why is typedef'ing structs bad practice? > > because there's no reason for it other than syntax candy. It also hides That's

Re: [hackers] [quark] Use sizeof() instead of magic constants || FRIGN

On 5 September 2016 at 09:44, FRIGN <d...@frign.de> wrote: > On Mon, 5 Sep 2016 09:39:24 +0200 > Anselm R Garbe <garb...@gmail.com> wrote: >> I'm referring to NOT using parentheses to make it explicitely clear, >> that the expression is not referring to a type. See se

Re: [hackers] [quark] Use sizeof() instead of magic constants || FRIGN

On 5 September 2016 at 09:41, FRIGN <d...@frign.de> wrote: > On Mon, 5 Sep 2016 09:37:17 +0200 > Anselm R Garbe <garb...@gmail.com> wrote: >> I disagree. Not using parentheses as sizeof arguments makes it pretty >> clear, that the expression is *not* about the size

Re: [hackers] [quark] Use sizeof() instead of magic constants || FRIGN

On 5 September 2016 at 09:25, FRIGN <d...@frign.de> wrote: > On Mon, 5 Sep 2016 07:42:36 +0200 > Anselm R Garbe <garb...@gmail.com> wrote: >> Quick note: your syntax usage of sizeof is not 100% accurate. >> >> Use 'sizeof(type)' with brackets but 'sizeof v

Re: [hackers] [quark] Use sizeof() instead of magic constants || FRIGN

On 5 September 2016 at 07:53, Markus Teich <markus.te...@stusta.mhn.de> wrote: > Anselm R Garbe wrote: >> Use 'sizeof(type)' with brackets but 'sizeof var' without. > > Heyho Anselm, > > can you elaborate on the reasoning behind this? The styleguide says &quo

Re: [hackers] [quark] Use sizeof() instead of magic constants || FRIGN

Quick note: your syntax usage of sizeof is not 100% accurate. Use 'sizeof(type)' with brackets but 'sizeof var' without. BR, Anselm On 5 September 2016 at 00:08, wrote: > commit 5ecd11fa3d42d7d474bf08c00e074eac52124d8f > Author: FRIGN > AuthorDate: Mon

Re: [hackers] [slock] [PATCH] Refactor main()

On 22 August 2016 at 11:03, FRIGN <d...@frign.de> wrote: > On Mon, 22 Aug 2016 10:59:16 +0200 > Anselm R Garbe <garb...@gmail.com> wrote: > >> I prefer it this way. > > So is it good to merge? @Hiltjo: your opinion? BR, Anselm

Re: [hackers] [slock] [PATCH] Refactor main()

Two spots: First, why using /* * tiny comment */ instead of /* tiny comment */ Second, why introducing superfluous scope brackets? I prefer if (!(dpy = XOpenDisplay(0))) die("cannot open display\n"); to cumbersome: if (!(dpy = XOpenDisplay(NULL))) { die("slock: cannot open

Re: [hackers] [9base][patch] add bclib

Hi Evan, On 17 August 2016 at 20:57, Evan Gates wrote: > bclib, for use with bc -l, is missing from 9base. I grabbed the file > from plan 9 sources, and made some changes to the makefiles in order > to install it. > > I'm also including a patch to fix a typo I made in the

Re: [hackers] [dwm] [PATCH] Replace str[n]cpy with strlcpy

Hi FRIGN, we had this strlcpy pseudo-discussion years ago. And we concluded to avoid adopting strlcpy. The basic reason is, that the claim of strlcpy to be more secure than strncpy is a myth. Roberto has pointed this out already. In either case you should handle the retval for arbitrary source

Re: [hackers] [dmenu][PATCH] history navigation

On 3 April 2016 at 05:35, crispyf...@163.com wrote: > This patch provides the ability for history navigation similar to that of > bash. Press alt+p for the previous history and alt+n for the next. Set the > maximum number of histories with a new variable 'maxhist' in

Re: [hackers] [slock] No need for usage() || FRIGN

On 14 February 2016 at 02:00, wrote: > commit a6dc051e3744ce5b14c54d2d246d3e8258207e76 > Author: FRIGN > AuthorDate: Sun Feb 14 01:48:48 2016 +0100 > Commit: FRIGN > CommitDate: Sun Feb 14 02:00:14 2016 +0100 > > No need for usage()

Re: [hackers] [slock] Use argv0 instead of passing "slock:" to die every time || FRIGN

On 14 February 2016 at 02:14, wrote: > commit b02c4d452a7942d4be3c69e6f98dafd35a2e4e78 > Author: FRIGN > AuthorDate: Sun Feb 14 02:13:54 2016 +0100 > Commit: FRIGN > CommitDate: Sun Feb 14 02:13:54 2016 +0100 > > Use argv0 instead of

Re: [hackers] [dwm][PATCH] Set the EWMH _NET_SUPPORTING_WM_CHECK atom

Having said this, please provide a decent patch as attachment. BR, Anselm On 24 January 2016 at 15:22, Anselm R Garbe <garb...@gmail.com> wrote: > Hi Omar, > > On 24 January 2016 at 01:10, Omar Sandoval <osan...@osandov.com> wrote: >> --- >> This has been

Re: [hackers] [dwm][PATCH] Set the EWMH _NET_SUPPORTING_WM_CHECK atom

Hi Omar, On 24 January 2016 at 01:10, Omar Sandoval wrote: > --- > This has been discussed a couple of times [1][2], and I think it's about time > that it gets fixed. I noticed this issue because xfce4-screenshooter -w, which > is supposed to screenshot the active window,

Re: [hackers] [2wm][PATCH] Expose root window color in config.default.h

Hi Christian, you can add your patch to wiki[0]. Btw. what is wrong with calling xsetroot -solid '#333' prior to exec 2wm? BR, Anselm [0] http://suckless.org/wiki On 19 January 2016 at 21:23, Harry van Haaren wrote: > --- > config.default.h | 1 + > main.c |

Re: [hackers] Mailing list infiltrated?

On 11 December 2015 at 00:03, Harald Weber wrote: > I just subscribed to your mailing list and immediately got a warning > of some login tries from the US. Maybe there are some bots in your > mailing list? I don't understand. From whom did you receive such a mail? Can

Re: [hackers] Compiling stali

Hi Harald, On 11 December 2015 at 00:20, Harald Weber wrote: > Yes I think "conflicts: 43 shift/reduce, 85 reduce/reduce" results in > "/bin/sh: 1: gen/maketab: not found" Did you install flex and/or bison? -Anselm

Re: [hackers] Mailing list infiltrated?

On 11 December 2015 at 12:30, Harald Weber wrote: > Google sent me an email that someone tried to log into my account. > That was immediately after the signup to the mailing list. > > I got the welcome email from the mailing list at: Thu, 10 Dec 2015 > 14:56:31 -0800

Re: [hackers] dwm-6.0-current_desktop.diff

On 19 August 2015 at 21:31, Martti Kühne mysat...@gmail.com wrote: dwm tags != workspaces. Please attach some information about how this is compatible with both dwm's concepts and EWMH, in that it won't go up in flames for the obvious case where several workspaces are displayed at the same

Re: [hackers] [surf] Fix type of strictssl property. || Quentin Rameau

Hi Quentin, just wondering if this is actually ok. Shouldn't it pass in a pointer, like: diff --git a/surf.c b/surf.c index 87c10ef..56df724 100644 --- a/surf.c +++ b/surf.c @@ -1266,7 +1266,7 @@ setup(void) { g_error_free(error); } g_object_set(G_OBJECT(s),

Re: [hackers] Re: [dmenu] Use libsl/libdraw code and add Xft support

Hi Hiltjo, On 27 June 2015 at 19:30, Hiltjo Posthuma hil...@codemadness.org wrote: On Sat, Jun 13, 2015 at 11:51 AM, Dimitris Papastamos s...@2f30.org wrote: Anselm, can we merge this? Bump. Can this get merged to master? Done. Sorry for the delay, and thanks for the bump reminder... I've

Re: [hackers] [9base][patch] cal: Bprint format specifier

Hi Evan, On 18 June 2015 at 20:01, Evan Gates evan.ga...@gmail.com wrote: Bprint didn't seem to like %u, giving the following output: [egates-vm 9base 686]$ cal/cal June % % S M Tu W Th F S 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29