Re: [hackers] [tabbed] Move tab selection keybinding from Ctrl-t to Ctrl-` || Quentin Rameau

2017-05-09 Thread Caleb Malchik
Hi quinq, If we are bikeshedding keybindings maybe this would be a good time to ask about Ctrl-q, Ctrl-b, and Ctrl-u being default in tabbed? These all conflict with the default bindings in most shells. This was surprising to me, as I assumed most tabbed users at least use Ctrl-u in the shell.

Re: [hackers] [tabbed][PATCH] Fix crashes when nclients == 0 in movetab() and focusurgent()

2017-05-07 Thread Caleb Malchik
On Sun, May 7, 2017 at 8:28 PM, Quentin Rameau wrote: > I'd prefer to check against sel rather than nclients, as it's already > done throughout the rest of the code. > > I'll apply your patch with those changes if that's ok with you. Sounds good to me.

[hackers] [tabbed][PATCH] Fix crashes when nclients == 0 in movetab() and focusurgent()

2017-05-07 Thread Caleb Malchik
--- tabbed.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tabbed.c b/tabbed.c index 6321575..23c3b47 100644 --- a/tabbed.c +++ b/tabbed.c @@ -502,6 +502,9 @@ focusurgent(const Arg *arg) { int c; + if (nclients == 0) + return; + for (c = (sel +