Re: [hackers] [dmenu] import new drw from libsl and minor fixes.

2016-06-28 Thread Hiltjo Posthuma
On Sun, Jun 26, 2016 at 01:05:18PM -0700, Eric Pruitt wrote: > On Sun, Jun 26, 2016 at 02:53:03PM +0200, Hiltjo Posthuma wrote: > > I have pushed the drw changes to dmenu and dwm. > > > > Thanks for the contributions! > > > > It would be nice if people test it and report any regressions with their

Re: [hackers] [dmenu] import new drw from libsl and minor fixes.

2016-06-26 Thread Eric Pruitt
On Sun, Jun 26, 2016 at 02:53:03PM +0200, Hiltjo Posthuma wrote: > It would be nice if people test it and report any regressions with their > setups > (font-fallback specificly). I finished merging my changes with the upstream tree, and I have not encountered any issues with fallback fonts while

Re: [hackers] [dmenu] import new drw from libsl and minor fixes.

2016-06-26 Thread Eric Pruitt
On Sun, Jun 26, 2016 at 02:53:03PM +0200, Hiltjo Posthuma wrote: > I have pushed the drw changes to dmenu and dwm. > > Thanks for the contributions! > > It would be nice if people test it and report any regressions with their > setups > (font-fallback specificly). I'm in the process of merging

Re: [hackers] [dmenu] import new drw from libsl and minor fixes.

2016-06-26 Thread Hiltjo Posthuma
On Fri, Jun 03, 2016 at 09:12:11PM +0200, Markus Teich wrote: > Hiltjo Posthuma wrote: > > Fair enough, I think I'll apply it with the (temporary fix), since the > > current > > width is also less accurate and the speed trade-off is not worth it. > > > > Again: thanks for the patches! I'll also

[hackers] [dmenu] import new drw from libsl and minor fixes. || Markus Teich

2016-06-26 Thread git
commit 44c7de3dcf49ee568863f55610f40c7a05b4dfe7 Author: Markus Teich AuthorDate: Sat May 21 21:51:14 2016 +0200 Commit: Hiltjo Posthuma CommitDate: Fri Jun 3 19:13:15 2016 +0200 import new drw from libsl and minor fixes. -

Re: [hackers] [dmenu] import new drw from libsl and minor fixes.

2016-06-03 Thread Markus Teich
Hiltjo Posthuma wrote: > Fair enough, I think I'll apply it with the (temporary fix), since the current > width is also less accurate and the speed trade-off is not worth it. > > Again: thanks for the patches! I'll also review the patch for dwm soon(tm). Heyho, Thanks, I'll push the sent patch

Re: [hackers] [dmenu] import new drw from libsl and minor fixes.

2016-06-03 Thread Hiltjo Posthuma
On Fri, Jun 03, 2016 at 07:42:37PM +0200, Markus Teich wrote: > Hiltjo Posthuma wrote: > > Your patch fixes the slowness for me, but we need to think of a more > > accurate > > but faster way indeed. > > Heyho, > > I plan to clean up the drw_text function some time in the future. I think it >

Re: [hackers] [dmenu] import new drw from libsl and minor fixes.

2016-06-03 Thread Markus Teich
Hiltjo Posthuma wrote: > Your patch fixes the slowness for me, but we need to think of a more accurate > but faster way indeed. Heyho, I plan to clean up the drw_text function some time in the future. I think it is possible to split the string into chunks which are drawn by the same font

Re: [hackers] [dmenu] import new drw from libsl and minor fixes.

2016-06-03 Thread Hiltjo Posthuma
On Fri, Jun 03, 2016 at 06:55:36PM +0200, Markus Teich wrote: > Hiltjo Posthuma wrote: > > I noticed a regression, dmenu seems really slow to load on my machine in the > > function readstdin(). Was the font cache behaviour removed from drw? > > Heyho, > Heya!, > that is probably because of the

Re: [hackers] [dmenu] import new drw from libsl and minor fixes.

2016-06-03 Thread Markus Teich
Hiltjo Posthuma wrote: > I noticed a regression, dmenu seems really slow to load on my machine in the > function readstdin(). Was the font cache behaviour removed from drw? Heyho, that is probably because of the second change noted from readstdin(): > > - fix bug where inputw was not correctly

Re: [hackers] [dmenu] import new drw from libsl and minor fixes.

2016-06-03 Thread Hiltjo Posthuma
On Sun, May 22, 2016 at 10:34:30PM +0200, Markus Teich wrote: > - extract drawitem function (code deduplication) > - fix bug where inputw was not correctly calculated from the widest item, but > just from the one with the longest strlen() which is not the same. > - minor code style fixes

[hackers] [dmenu] import new drw from libsl and minor fixes.

2016-05-22 Thread Markus Teich
- extract drawitem function (code deduplication) - fix bug where inputw was not correctly calculated from the widest item, but just from the one with the longest strlen() which is not the same. - minor code style fixes (indentation, useless line breaks) --- config.def.h | 12 +-- dmenu.c