Re: [hackers] [libgrapheme] [PATCH] Remove dead file `src/util.c'

[Laslo Hunhold]

On Wed, 10 Aug 2022 15:03:06 +
Tom Schwindl  wrote:

Dear Tom,

> Since commit 072bb271868a3583da1f ("Introduce mostly branchless
> character break detection") removed the code from the file, it no
> longer serves a purpose.

while it was true, it now is used again. :) It often makes more sense
to keep util-stubs that are guaranteed to be used later rather than
ripping it out of the build-system only having to include it later
again.

With best regards

Laslo

[hackers] [libgrapheme] [PATCH] Remove dead file `src/util.c'

[Tom Schwindl]

Since commit 072bb271868a3583da1f ("Introduce mostly branchless character
break detection") removed the code from the file, it no longer serves
a purpose.
---
 Makefile   | 2 --
 src/util.c | 8 
 2 files changed, 10 deletions(-)
 delete mode 100644 src/util.c

diff --git a/Makefile b/Makefile
index 1eb9507bb752..ac73ab9b1d0e 100644
--- a/Makefile
+++ b/Makefile
@@ -45,7 +45,6 @@ SRC =\
src/line\
src/sentence\
src/utf8\
-   src/util\
src/word\
 
 TEST =\
@@ -87,7 +86,6 @@ src/character.o: src/character.c config.mk gen/character.h 
grapheme.h src/util.h
 src/line.o: src/line.c config.mk gen/line.h grapheme.h src/util.h
 src/sentence.o: src/sentence.c config.mk gen/sentence.h grapheme.h src/util.h
 src/utf8.o: src/utf8.c config.mk grapheme.h
-src/util.o: src/util.c config.mk gen/types.h grapheme.h src/util.h
 src/word.o: src/word.c config.mk gen/word.h grapheme.h src/util.h
 test/character.o: test/character.c config.mk gen/character-test.h grapheme.h 
test/util.h
 test/line.o: test/line.c config.mk gen/line-test.h grapheme.h test/util.h
diff --git a/src/util.c b/src/util.c
deleted file mode 100644
index 7b8e176e535d..
--- a/src/util.c
+++ /dev/null
@@ -1,8 +0,0 @@
-/* See LICENSE file for copyright and license details. */
-#include 
-#include 
-#include 
-
-#include "../gen/types.h"
-#include "../grapheme.h"
-#include "util.h"
-- 
2.37.1