Re: [hackers] [tabbed][PATCH] Removes recursion while mouse is over window

2022-04-19 Thread Hiltjo Posthuma
On Tue, Apr 19, 2022 at 11:18:07AM +0100, big toaster wrote: > Hi, > > Looks like you're right. It occurs on lwm, but not dwm. > > I'm using the unpatched latest git version. > > I've also found that sometimes with surf I'll have to move my mouse > off the window and back on to get text boxes

Re: [hackers] [tabbed][PATCH] Removes recursion while mouse is over window

2022-04-19 Thread big toaster
Hi, Looks like you're right. It occurs on lwm, but not dwm. I'm using the unpatched latest git version. I've also found that sometimes with surf I'll have to move my mouse off the window and back on to get text boxes to work, so I think we should just stop it from calling itself rather than not

Re: [hackers] [tabbed][PATCH] Removes recursion while mouse is over window

2022-04-19 Thread Stein Gunnar Bakkeby
Yes I don't think this is correct. All tabbed is doing here is receiving a FocusIn event for the main (parent) window and giving focus to the window on the currently selected tab. I believe this is more of an edge case that is specifically related to dwm in relation to using tabbed and having

Re: [hackers] [tabbed][PATCH] Removes recursion while mouse is over window

2022-04-19 Thread Hiltjo Posthuma
On Mon, Apr 18, 2022 at 05:12:35PM +0100, bolshoytoster wrote: > In the focusin function, it calls focus, which calls > XSetInputFocus, which sends the focusin event. > > This can cause consistent ~90% cpu usage fo Xorg while the mouse > is over the window. > > This patch just gets rid of the

[hackers] [tabbed][PATCH] Removes recursion while mouse is over window

2022-04-18 Thread bolshoytoster
In the focusin function, it calls focus, which calls XSetInputFocus, which sends the focusin event. This can cause consistent ~90% cpu usage fo Xorg while the mouse is over the window. This patch just gets rid of the call to XSetInputFocus and breaks the recursion. I'm not sure what the call