Re: [hackers] [ubase][PATCH] Explicitly include sys/sysmacros.h for makedev etc

[Roberto E. Vargas Caballero]

On Sun, Aug 06, 2023 at 03:03:21PM +0200, Markus Rudy wrote:
> This header used to be included by sys/types.h in glibc, and musl
> adopted the behaviour. However, this dependency was never desired, so
> glibc deprecated it in 2016 and finally removed it in 2019, and so

Applied.

[hackers] [ubase][PATCH] Explicitly include sys/sysmacros.h for makedev etc

[Markus Rudy]

This header used to be included by sys/types.h in glibc, and musl
adopted the behaviour. However, this dependency was never desired, so
glibc deprecated it in 2016 and finally removed it in 2019, and so did
musl. Explicitly including the header should be a no-op on older libc
versions and fixes the build on newer versions.

https://sourceware.org/bugzilla/show_bug.cgi?id=19239
https://git.musl-libc.org/cgit/musl/commit/?id=f552c79
---
 libutil/tty.c | 1 +
 mknod.c   | 1 +
 mountpoint.c  | 1 +
 stat.c| 1 +
 4 files changed, 4 insertions(+)

diff --git a/libutil/tty.c b/libutil/tty.c
index bceb01e..3cb3b70 100644
--- a/libutil/tty.c
+++ b/libutil/tty.c
@@ -1,4 +1,5 @@
 /* See LICENSE file for copyright and license details. */
+#include 
 #include 
 #include 
 
diff --git a/mknod.c b/mknod.c
index 8de35c7..518ecb0 100644
--- a/mknod.c
+++ b/mknod.c
@@ -1,5 +1,6 @@
 /* See LICENSE file for copyright and license details. */
 #include 
+#include 
 #include 
 
 #include 
diff --git a/mountpoint.c b/mountpoint.c
index 8f205a2..9a31bbe 100644
--- a/mountpoint.c
+++ b/mountpoint.c
@@ -1,5 +1,6 @@
 /* See LICENSE file for copyright and license details. */
 #include 
+#include 
 #include 
 
 #include 
diff --git a/stat.c b/stat.c
index 220a659..9e96d80 100644
--- a/stat.c
+++ b/stat.c
@@ -1,5 +1,6 @@
 /* See LICENSE file for copyright and license details. */
 #include 
+#include 
 #include 
 
 #include 
-- 
2.41.0