Re: [hackers] [PATCH] [sbase] Include sysmacros.h directly rather than types.h

2018-07-02 Thread David Phillips
On Mon, Jul 02, 2018 at 10:02:09AM +0200, Hiltjo Posthuma wrote: > > Did you test it with musl too and preferably other platforms? Unfortunately not; I don't currently have access to non-glibc Linux installations at the moment, nor BSDs. Perhaps users of those systems might be able to chime in at

Re: [hackers] [PATCH] [sbase] Include sysmacros.h directly rather than types.h

2018-07-02 Thread David Phillips
On Mon, Jul 02, 2018 at 10:16:50AM +0200, Quentin Rameau wrote: > > On glibc, major, minor, and makedev are all defined in > > sys/sysmacros.h with types.h only including this for historical > > reasons. A future release of glibc will remove this behaviour, > > meaning that major, minor, and

Re: [hackers] [PATCH] [sbase] Include sysmacros.h directly rather than types.h

2018-07-02 Thread Quentin Rameau
> > On glibc, major, minor, and makedev are all defined in > > sys/sysmacros.h with types.h only including this for historical > > reasons. A future release of glibc will remove this behaviour, > > meaning that major, minor, and makedev will no longer be defined > > for us without including

Re: [hackers] [PATCH] [sbase] Include sysmacros.h directly rather than types.h

2018-07-02 Thread David Phillips
On Mon, Jul 02, 2018 at 01:20:42PM +0200, Quentin Rameau wrote: > Ok, the makedev(3) manpage from the man-pages states this indeed: > > The BSDs expose the definitions for these macros via . > Depending on the version, glibc also exposes definitions for these > macros from that header file if

Re: [hackers] [PATCH] [sbase] Include sysmacros.h directly rather than types.h

2018-07-02 Thread Hiltjo Posthuma
On Mon, Jul 02, 2018 at 07:48:03PM +1200, David Phillips wrote: > On glibc, major, minor, and makedev are all defined in > sys/sysmacros.h with types.h only including this for historical > reasons. A future release of glibc will remove this behaviour, > meaning that major, minor, and makedev will

Re: [hackers] [PATCH] [sbase] Include sysmacros.h directly rather than types.h

2018-07-02 Thread Quentin Rameau
> On glibc, major, minor, and makedev are all defined in > sys/sysmacros.h with types.h only including this for historical > reasons. A future release of glibc will remove this behaviour, > meaning that major, minor, and makedev will no longer be defined > for us without including sysmacros.h.

[hackers] [PATCH] [sbase] Include sysmacros.h directly rather than types.h

2018-07-02 Thread David Phillips
On glibc, major, minor, and makedev are all defined in sys/sysmacros.h with types.h only including this for historical reasons. A future release of glibc will remove this behaviour, meaning that major, minor, and makedev will no longer be defined for us without including sysmacros.h. --- ls.c |

[hackers] [ubase] Add blkdiscard(8) || sin

2018-07-02 Thread git
commit 604b66ae8b4005d89eed1cbab45a64cb57e75390 Author: sin AuthorDate: Mon Jul 2 14:03:49 2018 +0100 Commit: sin CommitDate: Mon Jul 2 14:03:57 2018 +0100 Add blkdiscard(8) diff --git a/Makefile b/Makefile index 453607c..b526421 100644 --- a/Makefile +++ b/Makefile @@ -37,6 +37,7

[hackers] [quark] Use sizeof() - 1 rather than strlen() || Laslo Hunhold

2018-07-02 Thread git
commit 34189e0a1f288e05ce528bcab28b922d53d5e471 Author: Laslo Hunhold AuthorDate: Mon Jul 2 18:41:29 2018 +0200 Commit: Laslo Hunhold CommitDate: Mon Jul 2 18:41:29 2018 +0200 Use sizeof() - 1 rather than strlen() I know, most compiler probably optimize this anyway, but why