Re: [hackers] [sent] Bail out before allocating slides if file is empty

2015-11-18 Thread Quentin Rameau
> Heyho, Hi :) > of course that is another fix Yeah, I saw your patch after having sent mine, sorry about that, I didn't mean to redo the work. > I merged it, thanks. Thanks!

Re: [hackers] [scc] Revert "[driver] use pointers in tools lookup table" || Quentin Rameau

2016-06-07 Thread Quentin Rameau
> if you look at the type-translation-tables, there > is kind of a "hack" to support the Plan 9 compiler > as well. The idiom of making a pointer struct-array > was circumvented to avoid doing that. I didn't understand what you meant by “make the changes in the arch-code-lookup-tables”, I thought

Re: [hackers] [sbase] ls: fix segfault when timestamp is negative

2016-03-27 Thread Quentin Rameau
Hi Mattias, > + if (ent->t.tv_sec < 0) Can it be? Could you provide me with a reproducible case? Thanks.

Re: [hackers] [sbase][PATCH v2.1] ls: fix segfault when timestamp is out of range for struct tm

2016-03-27 Thread Quentin Rameau
Looks fine for me. > + snprintf(buf, sizeof(buf), "%lli", (long Could you use d instead of i, just to be consistant with the rest of sbase? Thanks!

Re: [hackers] [tabbed] add -k to close tabbed foreground client on WMDelete

2016-04-24 Thread Quentin Rameau
On Fri, 25 Mar 2016 07:42:13 +0100 Christoph Lohmann <2...@r-36.net> wrote: > Greetings. > > On Fri, 25 Mar 2016 07:42:13 +0100 Justin Keogh > wrote: > > Hello, this is useful when you want to use the same key binding > > that closes windows to close tabs. I got tired of

Re: [hackers] [ubase][PATCH 2/5] mount: Indent/align properly

2016-07-11 Thread Quentin Rameau
Hi Klemens, > --- > mount.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/mount.c b/mount.c > index e70c7d1..1f17789 100644 > --- a/mount.c > +++ b/mount.c > @@ -47,10 +47,9 @@ findtype(const char *types, const char *t) > const char *p; >

Re: [hackers] Updating SSL patch for ii.

2017-01-29 Thread Quentin Rameau
On Sun, 29 Jan 2017 23:38:17 +0100 Laslo Hunhold wrote: > On Sun, 29 Jan 2017 17:16:55 -0500 > "S. Gilles" wrote: > > Hey, > > > On my Linux system (Gentoo), it's available as part of the libressl > > package. It even seems to have manpages taken directly

Re: [hackers] [scc] [libc] Add memmove() || Roberto E. Vargas Caballero

2017-02-19 Thread Quentin Rameau
> Yo! Yo, > > +memmove(void *dst, const void *src, size_t n) > > I'm a bit confused. Don't be, that's how the standard specifies it.

Re: [hackers] [scc] [cc1] Fix valid_va_list || Quentin Rameau

2017-02-15 Thread Quentin Rameau
Hi Michael, > I'm not sure of how to fix eqtype for STRUCT or UNION types, but I > think that this is the root cause of the problem you ran into. I think > this workaround just masks the real issue. We may have been quick to fix this, I'll have a closer look into it. > (I spent a while

Re: [hackers] [quark] Use sizeof() instead of magic constants || FRIGN

2016-09-06 Thread Quentin Rameau
> I think using goto loops sometimes is good, depend on the use case. Obviously > For example in spt.c: > > run: > notify_send(timers[i].cmt); > > for (timecount = 0; timecount < timers[i].tmr; timecount += > inc) sleep(1); > > if (++i >= LEN(timers)) i = 0; /* i

Re: [hackers] [slock] Fix my previous commit and some light refactoring

2016-09-01 Thread Quentin Rameau
> Heyho Quentin, Hi Markus, > in the commit message you mentioned spawning slock from other GUI > applications via keybindings as the case where it won't work. If this > is the only case, I think it would be cleaner to add a command line > switch where the user can specify a wait time and after

Re: [hackers] [slock] Fix my previous commit and some light refactoring

2016-09-02 Thread Quentin Rameau
> Heyho Quentin, Yo Markus, > After some reconsidering, I merged the patch as you proposed it. The > other three are merged as well. Thanks for the contribution. Thanks!

Re: [hackers] [slock] Unify how we check passwords between different OSes

2016-09-07 Thread Quentin Rameau
> thanks again for the simplification. I've just merged the patch. No prob, thanks to you (more to come, k0ga spotted some config.mk issues)! > --Markus >

Re: [hackers] [slock] Unify how we check passwords between different OSes

2016-09-07 Thread Quentin Rameau
> Heyho Quentin, Hey Markus, > I think it's a good simplification, but does it still work on the > other BSDs as well, not just OpenBSD? Well, yes it does :) (at least should, testing is welcomed to confirm that, following documentation it's ok for NetBSD, FreeBSD, DragonFlyBSD) > The commented

Re: [hackers] [slock] Exit as soon as possible on input grabbing error

2016-08-30 Thread Quentin Rameau
> since there are multiple other lines even longer than those two > fprintf calls, I'd just put them in one line and address the issue on > a project level in a separate patch when the community has agreed on > the definition on "reasonable" used in the style guide[0]. > > fprintf(stderr,

Re: [hackers] [slock] Exit as soon as possible on input grabbing error

2016-08-30 Thread Quentin Rameau
> if you guys really care that much about line length and other vague > points from the style guide, please start another thread and I'll be > happy to participate in the discussion and help to update projects > after a decision is made. As I said, I don't really mind. :) Of course, amend the

Re: [hackers] [slock] [PATCH] Properly drop privileges

2016-09-07 Thread Quentin Rameau
Hi, patch tested here and seconded! Just a question though, do we need to set a group to drop privileges to? Wouldn't getting the gid out of the user name sufficient? Actually two questions, why the nogroup group instead of the nobody group? I know that nogroup is present on OpenBSD, but the

Re: [hackers] [slock] [PATCH] Properly drop privileges

2016-09-07 Thread Quentin Rameau
> Hey Quentin, > > > Just a question though, do we need to set a group to drop privileges > > to? Wouldn't getting the gid out of the user name sufficient? > > why cut the flexibility there? It looks more simple to me to just give a user to drop privileges to. A user always has a group

Re: [hackers] [slock] Fix my previous commit and some light refactoring

2016-09-01 Thread Quentin Rameau
> I don't think a config.h variable is the best option. When starting > slock from the terminal the problem does not occur, so you don't want > a timeout in this case. I don't really understand what you mean by that. Why wouldn't you want a timeout then? Even when started from a terminal, the

Re: [hackers] [slock] [PATCHSET] Some improvements and more security

2016-09-12 Thread Quentin Rameau
> Good evening fellow hackers, Hi FRIGN, > I sat down this evening to write down some patches that have been > floating around in my head for a while. > > See attached. Most important is the patch which removes the > abomination of user $USER which actually poses quite a risk and only > is done

Re: [hackers] [slock] [PATCHSET] Some improvements and more security

2016-09-12 Thread Quentin Rameau
> > First patch: > > - I agree with the structuring of the xrandr part, good! > > - But not with the localization of every data, they're used across > > the whole program and you're just over-complicating functions here > > imho. The program is simple and clear enough not to have to get > > triple

Re: [hackers] [slock] [PATCH] Properly drop privileges

2016-09-08 Thread Quentin Rameau
> I don't have a clear opinion on the nogroup vs. nobody matter, but > since it is just a default and can easily be changed I just merged > the patch for now (I hope I got the correct version). If somebody[0] > gives a good argument, we'll just change the default. > > 0:

Re: [hackers] [slock] [PATCH] Properly drop privileges

2016-09-09 Thread Quentin Rameau
> it is always recommended to read the motivation for doas and why sudo > was invented in the first place. I wrote this patch under two > assumptions > - in most cases, the slock post-lock-cmd wouldn't need > permissions > - if it needs permissions, we can't just not drop

Re: [hackers] Re: [sbase][patch] respect -q handling with -l and -R

2016-10-06 Thread Quentin Rameau
Hi Evan, > > sbase-ls_-lq.diff: respect -q flag when using -l flag > > sbase-ls_-qR.diff: respect -q flag when printing directory headings > > with -R flag > > Updated versions. Add "ls: " to commit messages and malloc later/free > earlier in lsdir (thanks quinq). Those two look correct to me,

Re: [hackers] [dwm][PATCH] Do not call die() upon '-v' invocation

2016-10-29 Thread Quentin Rameau
> I agree, but we should get rid of this EXIT_* stuff altogether. > My proposal: > > if (argc == 2 && !strcmp("-v", argv[1])) { > fputs("dwm-"VERSION, stdout); > return 0; > } else if (argc != 1) > die("usage: dwm [-v]"); > > What do you guys

Re: [hackers] [sbase] [PATCH] tr: Fix multiple ranges with different lengths

2016-10-22 Thread Quentin Rameau
Hi Michael, > A bug was introduced in bc4c293fe59de042c1ac71793d33bb685c4fb915 > causing the range length for the next set to be used instead of the > first one. This causes issues when choosing the replacement rune when > the ranges are of different lengths. > > This also fixes range

Re: [hackers] [PATCH][dmenu] Xinerama: correct variable declarations in preprocessor conditional

2016-11-25 Thread Quentin Rameau
> Greetings, Hi, > The config.mk option must never have been rigorously tested. Thank you for spotting that, but maybe the description, if any, could be a little more constructive? > --- > dmenu.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/dmenu.c

Re: [hackers] [dmenu] [PATCH v2] Xinerama: correct variable declarations in preprocessor conditional

2016-11-25 Thread Quentin Rameau
> Sorry Quentin, I know now that this is where to include remarks. No problem, thanks for correcting! > dmenu.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/dmenu.c b/dmenu.c > index 9278e91..1cfefcd 100644 > --- a/dmenu.c > +++ b/dmenu.c > @@ -539,15

Re: [hackers] [dwm][PATCH] Do not call die() upon '-v' invocation

2016-10-28 Thread Quentin Rameau
> On 2016-10-28 13:02, Quentin Rameau wrote: > > On Fri, Oct 28, 2016 at 12:45:14PM +, Ali H. Fardan wrote: > >> actually, imo, I think > >> usage() should return success. > > Surely not. > > The call to usage() is made when wrong options have be

Re: [hackers] [st][PATCH] Add missing device path to '-l' example

2016-10-13 Thread Quentin Rameau
Thanks, applied!

Re: [hackers] [dmenu][PATCH] Revert "fix input text matching"

2016-12-07 Thread Quentin Rameau
Hi Andrew, > This reverts commit 09d0a36e0370f7ca9bdb171bf93c5ac3131c5a92. > > Using strncmp with the length of the user input turns it into a prefix > match rather than an exact match as it's supposed to be. Indeed your right, my error, thanks for catching that! Ok for me.

Re: [hackers] [ubase] [PATCH] install: ignore -s

2016-12-03 Thread Quentin Rameau
> diff --git a/xinstall.1 b/xinstall.1 > index 1a727d3..bda4d42 100644 > --- a/xinstall.1 > +++ b/xinstall.1 > @@ -12,7 +12,7 @@ > .Po > .Fl d Ar dir ... > | > -.Op Fl sD > +.Op Fl D > .Po > .Fl t Ar dest > .Ar source ... > @@ -62,10 +62,6 @@ is copied with > Change the installed files'

Re: [hackers] [sbase] [PATCH 10/10] cp: Check result of utimensat

2016-12-05 Thread Quentin Rameau
> LGTM Please stop writing that, full sentences are clearer.

Re: [hackers] [sxiv] Pass given file names to key-handler instead of real paths || Bert Münnich

2017-01-07 Thread Quentin Rameau
> diff --git a/exec/key-handler b/exec/key-handler > index 03d7499..439ab2e 100644 > --- a/exec/key-handler > +++ b/exec/key-handler > @@ -18,7 +18,7 @@ readonly TMPFILE="/tmp/sxiv.$$" > > rotate() { > degree="$1" > - while read file; do > + tr '\n' \0' | xargs -0 realpath | sort

Re: [hackers] [sbase] ls: print filenames on the fly rather than in a buffer

2016-12-28 Thread Quentin Rameau
> Thanks. Changed to const as discussed on IRC and applied. Thank you!

Re: [hackers] [farbfeld] Overhaul Build-system || Laslo Hunhold

2017-03-30 Thread Quentin Rameau
Hi Laslo, > > > -PNGLIB = /usr/local/lib > > > -PNGINC = /usr/local/include > > > - > > > -JPGLIB = /usr/local/lib > > > -JPGINC = /usr/local/include > > > > Personally I think it's useful to have these separated. It is also > > useful to specify PNGINC, JPGINC etc separately for building in >

Re: [hackers] [farbfeld] Makefile: target should depend on its object

2017-03-30 Thread Quentin Rameau
> I think your fix is incorrect. A single program like ff2png does not > depend on ff2jpg.o or any other object other than ff2png.o. > I'll look at it later, so if I'm wrong I'll merge it. Well, it's not “wrong” per se, but indeed it makes binaries depend on all objects. That's something you

Re: [hackers] [farbfeld] Makefile: target should depend on its object

2017-03-30 Thread Quentin Rameau
From 94d6e290f97b78de4c36da820f38a9b10822bda3 Mon Sep 17 00:00:00 2001 From: Quentin Rameau <quinq@fifth.space> Date: Thu, 30 Mar 2017 15:51:28 +0200 Subject: [PATCH] Makefile: target should depend on its object --- Makefile | 29 +++-- 1 file changed, 19 inse

Re: [hackers] [st][PATCH] Support xterm Ms feature to set clipboard

2017-03-18 Thread Quentin Rameau
On Sat, 18 Mar 2017 19:27:58 +0100 Anselm R Garbe wrote: > On 18 March 2017 at 08:18, Omar Sandoval wrote: > > This is used by, e.g., tmux. > > From my perspective ok. > > @frign? Did you mean k0ga?

Re: [hackers] [scc] [tests] Don't quote what doesn't need to be quoted || Roberto E. Vargas Caballero

2017-03-22 Thread Quentin Rameau
> [tests] Don't quote what doesn't need to be quoted :(

Re: [hackers] [sbase] tail: Process bytes with -c option, and add -m option for runes || Michael Forney

2017-07-14 Thread Quentin Rameau
> tail: Process bytes with -c option, and add -m option for runes > > POSIX says that -c specifies a number of bytes, not characters. > This flag is commonly used by scripts that operate on binary files to > things like extract a header. Treating the offsets as character > offsets

Re: [hackers] [surf] Simplify DOWNLOAD macro || Quentin Rameau

2017-05-11 Thread Quentin Rameau
Hi Pickfire, > I prefer it to close automatically after a timeout AND interactively > with: > > timeout 5 read Thanks for the suggestion, but timeout is GNU-specific, and I actually find the mix of both pretty redundant and even less supple.

Re: [hackers] [tabbed] Move tab selection keybinding from Ctrl-t to Ctrl-` || Quentin Rameau

2017-05-10 Thread Quentin Rameau
r to your experience, but I would at least like to hear the > thinking behind this. > > Best, > Caleb > >From f6560fb3ce7283564fcce2f245b3f0acd8cb5ad1 Mon Sep 17 00:00:00 2001 From: Quentin Rameau <quinq@fifth.space> Date: Thu, 11 May 2017 00:07:46 +0200 Subject: [PA

Re: [hackers] [surf] Add prompts for SETPROP || Quentin Rameau

2017-05-09 Thread Quentin Rameau
> Hi, Hi ssd, thanks for the feedback. > * g...@suckless.org 2017-05-08 14:08 > > commit 47b145f2ec79ce79172bcd4fd36149c34d9085df > > Author: Quentin Rameau <quinq@fifth.space> > > [...] > > -#define SETPROP(r, s) { \ > > +#define PROMPT_

Re: [hackers] [PATCH] Honor SURF_USERAGENT evironment variable

2017-05-13 Thread Quentin Rameau
> From: Vasily Kolobkov <> Hi Vasily, > + > + if ((envuseragent = getenv("SURF_USERAGENT"))) > + fulluseragent = envuseragent; There is already a flag for this (surf -u "$SURF_USERAGENT"), could you explain why you need this? Thanks!

Re: [hackers] [PATCH] Honor SURF_USERAGENT evironment variable

2017-05-13 Thread Quentin Rameau
> If nobody's using the SURF_USERAGENT (which seem to be the case :), > i'd rip it out and will submit a man patch (which still mentions > this env var) instead. Erf, you're right, I forgot it was mentioned in the manpage. It's been historically there, so I'll apply your patch, thank you!

Re: [hackers] [surf] Add prompts for SETPROP || Quentin Rameau

2017-05-10 Thread Quentin Rameau
> I'd have `Go:` rather than `URL:` here. Fine, do you want to write a patch for it? I you don't I'll commit it myself.

Re: [hackers] [surf] Simplify DOWNLOAD macro || Quentin Rameau

2017-05-10 Thread Quentin Rameau
> I found it very beneficial to go a step further: rather than just > asking for confirmation with `read`, I drop the user in a shell, > after the download is complete. They see what file was downloaded, a > `pwd` gives them even more context and they can right away do > whatever they intended

Re: [hackers] [dwm] azertykey patch

2017-06-22 Thread Quentin Rameau
> Hi, > > Re: http://bbs.archlinux.org/viewtopic.php?pid=1332805#p1332805 >-> http://dwm.suckless.org/patches/azertykey > > The azertykey patch link is not listed amongst > http://dwm.suckless.org/patches/ > > Where can I find it? Ask your archlinux friend who linked it. You could

Re: [hackers] [farbfeld] Makefile-workaround for OpenBSD || Laslo Hunhold

2017-05-29 Thread Quentin Rameau
> Makefile-workaround for OpenBSD At last! > Thanks Hiltjo for reporting this! Well, I've been warning you with the first patch long ago. > For some reason, OpenBSD make does not add $(BIN).o to the > dependency list when it sees the $(BIN) target rule. It does so > however

Re: [hackers] [tabbed] Move tab selection keybinding from Ctrl-t to Ctrl-` || Quentin Rameau

2017-05-08 Thread Quentin Rameau
> g...@suckless.org wrote: > > Move tab selection keybinding from Ctrl-t to Ctrl-` > > Heyho, Hi Markus, > what is the reason for this change? In some keyboard layouts the > grave accent is on the shift-layer, so it needs an extra key press. > Of course you can personalize the keybindings

Re: [hackers] [tabbed][PATCH] Fix crashes when nclients == 0 in movetab() and focusurgent()

2017-05-07 Thread Quentin Rameau
Hi Caleb, good catch and thanks for the patch! > + if (nclients == 0) > + return; > + I'd prefer to check against sel rather than nclients, as it's already done throughout the rest of the code. I'll apply your patch with those changes if that's ok with you.

Re: [hackers] [surf][PATCH] Match showcert key with man and surf pop-up

2017-05-02 Thread Quentin Rameau
Thanks, I have applied the modified patch we discussed on IRC

[hackers] [slstatus] Simplify Makefile

2017-09-17 Thread Quentin Rameau
--- Makefile | 25 - 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/Makefile b/Makefile index d657981..fc80ab1 100644 --- a/Makefile +++ b/Makefile @@ -7,6 +7,7 @@ include config.mk REQ = util HDR = arg.h config.h COM =\ + $(REQ)\ battery\

[hackers] [slstatus] Simplify Makefile

2017-09-17 Thread Quentin Rameau
--- Makefile | 37 ++--- 1 file changed, 10 insertions(+), 27 deletions(-) diff --git a/Makefile b/Makefile index d657981..3d116ba 100644 --- a/Makefile +++ b/Makefile @@ -4,9 +4,10 @@ include config.mk -REQ = util HDR = arg.h config.h COM =\ + util\

Re: [hackers] [slstatus] Simplify Makefile

2017-09-17 Thread Quentin Rameau
On Sun, 17 Sep 2017 22:29:42 +0100 Matthew Parnell wrote: > Hi Quentin, Hi Matthew, > I like this simplification a lot, I believe it covers the dependency > resolution that Laslo pointed out earlier today; and yet cleans things > up nicely. > I'd very much like to see this

[hackers] [slstatus] Fix missing config.h in Makefile

2017-09-17 Thread Quentin Rameau
--- Makefile | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d690612..d657981 100644 --- a/Makefile +++ b/Makefile @@ -5,7 +5,7 @@ include config.mk REQ = util -HDR = arg.h +HDR = arg.h config.h COM =\ battery\ cpu\ @@ -52,6

Re: [hackers] [slstatus] Simplify Makefile

2017-09-18 Thread Quentin Rameau
> Dear Laslo, dear Quentin, Hi Aaron, > > why not just the following? Thanks for bringing the topic up; for > > some reason I had in mind that it was necessary to list the > > dependencies explicitly. > > I will merge this patch as it has the required dependency on > slstatus.o and it is

Re: [hackers] [surf][PATCH] add support for WebGL

2017-09-29 Thread Quentin Rameau
Hi Eon, Thank you for your patch, I'll push it soon. > + [WebGl] = { { .i = 1 }, }, Looks like you sent the same patch again. Don't worry though, I can modify it before pushing it, I'll take care of it. -- Quentin

Re: [hackers] [sbase][PATCH] ls: abort a directory if we cannot opendir it

2017-08-22 Thread Quentin Rameau
> Sorry, I should have made the commit message clearer. It is > not the entire operation that is being aborted, but only the > current node, if it cannot be opened. Ah, right! > Before this patch, ls will segfault since it tries to perform > operations on a (null) DIR*. After this patch, it

Re: [hackers] [sbase][PATCH] ls: abort a directory if we cannot opendir it

2017-08-22 Thread Quentin Rameau
Hello David, > We should not try and perform operations on an invalid DIR* stream. > Instead, we shall let the error message be printed, and the return > code set (existing behaviour) and abort afterwards. Any justification you could provide us with? AFAIK POSIX specifies the opposite, a

Re: [hackers] [surf] modal browsing

2017-09-03 Thread Quentin Rameau
> Hi, Hi ssd, > modal browsing hasn't been first class citizen in surf. but given the > recent activity in adding features and webkit2 may be there is a > slightly better chance now. Nope. > attached is another rewrite of the modal browsing patch. > > I find particularly appealing the fact

Re: [hackers] [PATCH] Install LICENSE and BUGS

2018-05-11 Thread Quentin Rameau
Hi David, > - @sed "s/VERSION/${VERSION}/g" < dwm.1 > > ${DESTDIR}${MANPREFIX}/man1/dwm.1 > + @cp -f dwm.1 ${DESTDIR}${MANPREFIX}/man1/dwm.1 > + @sed -i "s|VERSION|${VERSION}|g" ${DESTDIR}${MANPREFIX}/man1/dwm.1 > + @sed -i "s|DOCPREFIX|${DESTDIR}${DOCPREFIX}|g" >

Re: [hackers] [slstatus] Explicitly list component-objects in the Makefile || Laslo Hunhold

2018-05-28 Thread Quentin Rameau
>$(COM:=.o): config.mk $(REQ:=.h) > > omits the dependency on the c-file itself, which incurs that strictly > speaking the object file is not depending on the source file, which is > nonsense. Come on... This is suckless, read and try understanding the standard. >

Re: [hackers] [PATCH] [sbase] Include sysmacros.h directly rather than types.h

2018-07-02 Thread Quentin Rameau
> > On glibc, major, minor, and makedev are all defined in > > sys/sysmacros.h with types.h only including this for historical > > reasons. A future release of glibc will remove this behaviour, > > meaning that major, minor, and makedev will no longer be defined > > for us without including

Re: [hackers] [PATCH] [sbase] Include sysmacros.h directly rather than types.h

2018-07-02 Thread Quentin Rameau
> On glibc, major, minor, and makedev are all defined in > sys/sysmacros.h with types.h only including this for historical > reasons. A future release of glibc will remove this behaviour, > meaning that major, minor, and makedev will no longer be defined > for us without including sysmacros.h.

Re: [hackers] [slstatus] Revert component-split || Laslo Hunhold

2018-05-03 Thread Quentin Rameau
> Revert component-split What the hell, > After heavy consideration, the component split has more disadvantages > than advantages, especially given there will be utility-functions > sharing quite a lot of code that would then need to be duplicated, as it > does not fit into

[hackers] [PATCH 5/9] ram: OS split

2018-04-30 Thread Quentin Rameau
--- Makefile | 2 +- components/Linux/ram.c | 52 +++ components/OpenBSD/ram.c | 77 components/ram.c | 129 --- 4 files changed, 130 insertions(+), 130 deletions(-) create mode

[hackers] [PATCH 6/9] swap: OS split

2018-04-30 Thread Quentin Rameau
--- Makefile | 2 +- components/{ => Linux}/swap.c | 4 +--- components/OpenBSD/swap.c | 0 3 files changed, 2 insertions(+), 4 deletions(-) rename components/{ => Linux}/swap.c (98%) create mode 100644 components/OpenBSD/swap.c diff --git a/Makefile b/Makefile index

[hackers] [PATCH 7/9] temperature: OS split

2018-04-30 Thread Quentin Rameau
--- Makefile | 2 +- components/Linux/temperature.c | 15 +++ components/{ => OpenBSD}/temperature.c | 15 +-- 3 files changed, 17 insertions(+), 15 deletions(-) create mode 100644 components/Linux/temperature.c rename components/{

[hackers] [PATCH 4/9] entropy: OS split

2018-04-30 Thread Quentin Rameau
--- Makefile | 2 +- components/{ => Linux}/entropy.c | 4 +--- components/OpenBSD/entropy.c | 0 3 files changed, 2 insertions(+), 4 deletions(-) rename components/{ => Linux}/entropy.c (82%) create mode 100644 components/OpenBSD/entropy.c diff --git a/Makefile

[hackers] [PATCH 2/9] battery: OS split

2018-04-30 Thread Quentin Rameau
--- Makefile | 2 +- components/{ => Linux}/battery.c | 35 +-- components/OpenBSD/battery.c | 32 3 files changed, 34 insertions(+), 35 deletions(-) rename components/{ => Linux}/battery.c (63%)

[hackers] Split component sources per OS

2018-04-30 Thread Quentin Rameau
I think we reached the point, it's time now to separate sources in their own OS-specific directories. Feel free to squash the whole set if you prefer.

[hackers] [PATCH 8/9] uptime: OS split

2018-04-30 Thread Quentin Rameau
--- Makefile | 2 +- components/Linux/uptime.c | 24 components/{ => OpenBSD}/uptime.c | 25 + 3 files changed, 26 insertions(+), 25 deletions(-) create mode 100644 components/Linux/uptime.c rename components/{

[hackers] [PATCH 3/9] cpu: OS split

2018-04-30 Thread Quentin Rameau
--- Makefile | 2 +- components/{ => Linux}/cpu.c | 26 +- components/OpenBSD/cpu.c | 26 ++ 3 files changed, 28 insertions(+), 26 deletions(-) rename components/{ => Linux}/cpu.c (75%) create mode 100644

[hackers] [PATCH 9/9] wifi: OS split

2018-04-30 Thread Quentin Rameau
--- Makefile | 2 +- components/{ => Linux}/wifi.c | 4 +--- components/OpenBSD/wifi.c | 0 3 files changed, 2 insertions(+), 4 deletions(-) rename components/{ => Linux}/wifi.c (97%) create mode 100644 components/OpenBSD/wifi.c diff --git a/Makefile b/Makefile index

Re: [hackers] [sites][PATCH] Surf link_hints script supports pages without predefined styles.

2018-02-23 Thread Quentin Rameau
> done! :) Thank you for taking the time :)

Re: [hackers] [sites][PATCH] Surf link_hints script supports pages without predefined styles.

2018-02-23 Thread Quentin Rameau
Yes, please push this to the wiki

Re: [hackers] [surf][PATCH] Document SIGHUP in manpage

2018-02-23 Thread Quentin Rameau
Hi Jochen, Thank you for the patch. > --- > surf.1 | 8 > 1 file changed, 8 insertions(+) > > diff --git a/surf.1 b/surf.1 > index 711a9aa..f8ff74e 100644 > --- a/surf.1 > +++ b/surf.1 > @@ -306,6 +306,14 @@ string. > .TP > .B http_proxy > If this variable is set and not empty upon

Re: [hackers] [PATCH] Script text shouldn't go through formatted conversion

2018-02-23 Thread Quentin Rameau
Thanks, applied!

Re: [hackers] [surf][PATCH] Add support for WebGL

2018-02-23 Thread Quentin Rameau
> Allows enabling and disabling WebGL support built into WebKit. > The feature is turned off by default. Thanks, applied! (sorry for the delay)

Re: [hackers] [surf][PATCH] Document SIGHUP in manpage

2018-02-25 Thread Quentin Rameau
> Fine with me as well. Thanks for taking care of this. Thank you, pushed!

Re: [hackers] [sbase][PATCH v2] Support -- in all utilities except echo(1)

2018-07-08 Thread Quentin Rameau
> In POSIX-2017 it was clarified via the documentation for > basename(1) and dirname(1) that all programs should support > -- unless specified otherwise. Humm, this has been specified since SUSv2 at least in the utility description defaults, not sure why you should mention basename or dirname or

[hackers] [dmenu] add key bindings Mod1+b and Mod1+f for moving to the prev or next word

2018-03-13 Thread Quentin Rameau
--- dmenu.c | 16 1 file changed, 16 insertions(+) diff --git a/dmenu.c b/dmenu.c index a246111..90feea5 100644 --- a/dmenu.c +++ b/dmenu.c @@ -345,6 +345,20 @@ keypress(XKeyEvent *ev) } else if (ev->state & Mod1Mask) switch(ksym) { +

Re: [hackers] [dmenu][PATCH] fix a bug introduced by e2a2805 that that ignores composed characters

2018-03-15 Thread Quentin Rameau
> XmbLookupString may not return a keysym, but only a string for > composed characters. Ah, could you provide a test-case for this? > --- > dmenu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/dmenu.c b/dmenu.c > index 5e9c367..3a3f8e4 100644 > --- a/dmenu.c > +++

Re: [hackers] [dmenu] add key bindings for moving to the word start or end || Quentin Rameau

2018-03-13 Thread Quentin Rameau
> Commit: Hiltjo Posthuma > CommitDate: Tue Mar 13 20:10:46 2018 +0100 Gracias Hiltjo

Re: [hackers] [st] Proposed makefile tweak for debugging

2018-04-23 Thread Quentin Rameau
> Hey, Hi, > Any thoughts on adding following to the config.mk?: > > #·flags > STCFLAGS = $(INCS) $(CPPFLAGS) $(CFLAGS) > ifneq "$(ST_DEBUG)" "" >STCFLAGS += -g -O0 > endif No [0]. > I found myself often adding flags to the makefile locally in order for me > to debug some of the patches

Re: [hackers] [dmenu][PATCH] fix a bug introduced by e2a2805 that that ignores composed characters

2018-03-16 Thread Quentin Rameau
> > Ah, could you provide a test-case for this? > > It stops input from IME, and I tested the status returned from > XmbLookupString was XLookupChars. Which IME method are you using? I confess I don't use IME and didn't think about testing it, but now I did with fcitx and while it seems to

Re: [hackers] [sent] [PATCH] Add toggle fullscreen shortcut: f

2018-03-19 Thread Quentin Rameau
> > Don't you think it's worth it? > > I don't think so, but at the end of the day, Markus will make the > decision and that's what matters. The maintainer decides what to merge > and what not. Same as Lalso on this.

Re: [hackers] [slstatus] battery_perc: Port to OpenBSD. || Aaron Marcher

2018-03-20 Thread Quentin Rameau
> Hello, > > > If you're going to do this for every module for every OS you're > > planning on supporting, this is a bad start imho. > > Well, i will only support Linux and OpenBSD - and almost half of the > modules is POSIX-compliant anyway. > > > What would you think about rather

Re: [hackers] [slstatus] battery_perc: Port to OpenBSD. || Aaron Marcher

2018-03-20 Thread Quentin Rameau
> +#elif __OpenBSD__ > +#elif __OpenBSD__ Also, for more robustness you should use #elif defined(__OpenBSD__) You shouldn't test its evaluated expanded value, but only if it is defined or not. (then I'd replace matching #ifdef with #if defined(), but I guess that's more a matter of taste)

Re: [hackers] [slstatus] battery_perc: Port to OpenBSD. || Aaron Marcher

2018-03-19 Thread Quentin Rameau
Hello Aaron, > battery_perc: Port to OpenBSD. > +#elif __OpenBSD__ > +#ifdef __linux__ > +#elif __OpenBSD__ > +#endif > +#ifdef __linux__ If you're going to do this for every module for every OS you're planning on supporting, this is a bad start imho. What would you think about rather

Re: [hackers] [st][patch] bottom scratches

2018-03-17 Thread Quentin Rameau
Hi Victor, > Bottom_scratches is an optional numeric value that is useful if you > have a damage area in the bottom of your screen. For example, you can > bypass 128 pixels lines of your bottom screen by recompiling: > > BOTTOM_SCRATCHES=128 make install > > For sure you can compile as

Re: [hackers] [ubase][PATCH] passwd: fix crashes when authentication is unnecessary.

2018-09-24 Thread Quentin Rameau
Hey Mario, > - p = crypt(inpass, prevhash); > - if (!p) > - eprintf("crypt:"); > - if (cryptpass1 && strcmp(cryptpass1, p) == 0) > - eprintf("password left unchanged\n"); > + if (cryptpass1) { ^--- for more clarity, maybe check against prevhash

Re: [hackers] [ubase][PATCH] passwd: fix crashes for unencrypted passwords starting with 'x'.

2018-09-24 Thread Quentin Rameau
Hello Mario, > - if (pw->pw_passwd[0] == 'x') > + if (pw->pw_passwd[0] == 'x' && > + pw->pw_passwd[0] == '\0') Did you mean “pw->pw_passwd[1] == '\0')”?

Re: [hackers] [st][patch] Increase the buffer size for escape sequences

2018-09-25 Thread Quentin Rameau
Hi Roberto, > If we go to increase that size, I would go to use dynamic memory. Having > an array of 1MB statically allocated is a crazy idea Yes it is! > (and it is not C99 compliant, where the maximun allocated size is 128K). That's actually 64k (“at least […] — 65535 bytes in an object (in

Re: [hackers] [sbase] [PATCH] ed: Changed delimiter to fix unterminated TODO comment

2018-09-23 Thread Quentin Rameau
Hello Firasuke, > 1 file changed, 1 insertion(+), 1 deletion(-) . > - *s/ *// > + *s# *## Applied, thanks!

Re: [hackers] [ii][patch] add support for OpenBSD unveil(2)

2018-09-12 Thread Quentin Rameau
> > […] All these > > patches must go to the patches section and not in the main > > repo. > > I think you have a good point. Maybe we should revert the pledge(2) changes > and > put them on the wiki. The patches could be maintained separately and added to > the OS ports. > > What is the