Re: [hackers] [st][PATCH] sgr-patch

2024-04-19 Thread Quentin Rameau
Hi Mikhail, > Colon-separated SGR (new version; ':' is the legacy one) Could explain a bit more what this patch is about, with some context and telling the goal?

Re: [hackers] [st][PATCH] Reset title when an empty title string is given

2024-04-03 Thread Hiltjo Posthuma
On Tue, Apr 02, 2024 at 09:41:15PM -0400, DOGMAN wrote: > With this patch, st will reset its window title when an empty string is > given as the terminal title. For example: > printf "\033]0;\007" > > Some applications, like termdown, expect this functionality. xterm > implements it, but it

Re: [hackers] [st] Fix cursor move with wide glyphs || Quentin Rameau

2024-03-30 Thread Hiltjo Posthuma
On Sat, Mar 30, 2024 at 01:59:28AM +0100, Storkman wrote: > On Fri, Mar 29, 2024 at 07:27:43PM +0100, Hiltjo Posthuma wrote: > > On Wed, Mar 27, 2024 at 04:11:27PM +0100, Storkman wrote: > > > On Sun, Feb 25, 2024 at 11:57:03AM +0100, g...@suckless.org wrote: > > > > commit

Re: [hackers] [st] Fix cursor move with wide glyphs || Quentin Rameau

2024-03-30 Thread Страхиња Радић
On 24/03/30 01:59AM, Storkman wrote: > For a specific example, copy text followed by a wide glyph into bash > or mksh, e.g. > A字 > and press backspace once. Both characters will be erased. Or, when using tmux, split vertically, then in the right pane copy the above text and press left

Re: [hackers] [st] Fix cursor move with wide glyphs || Quentin Rameau

2024-03-29 Thread Storkman
On Fri, Mar 29, 2024 at 07:27:43PM +0100, Hiltjo Posthuma wrote: > On Wed, Mar 27, 2024 at 04:11:27PM +0100, Storkman wrote: > > On Sun, Feb 25, 2024 at 11:57:03AM +0100, g...@suckless.org wrote: > > > commit 7473a8d1a57e5f9aba41b953f4e498c35e1c9dc5 > > > Author: Quentin Rameau > > >

Re: [hackers] [st] Fix cursor move with wide glyphs || Quentin Rameau

2024-03-29 Thread Hiltjo Posthuma
On Wed, Mar 27, 2024 at 04:11:27PM +0100, Storkman wrote: > On Sun, Feb 25, 2024 at 11:57:03AM +0100, g...@suckless.org wrote: > > commit 7473a8d1a57e5f9aba41b953f4e498c35e1c9dc5 > > Author: Quentin Rameau > > AuthorDate: Sun Feb 25 01:31:31 2024 +0100 > > Commit: Hiltjo Posthuma > >

Re: [hackers] [st] Fix cursor move with wide glyphs || Quentin Rameau

2024-03-27 Thread Storkman
On Sun, Feb 25, 2024 at 11:57:03AM +0100, g...@suckless.org wrote: > commit 7473a8d1a57e5f9aba41b953f4e498c35e1c9dc5 > Author: Quentin Rameau > AuthorDate: Sun Feb 25 01:31:31 2024 +0100 > Commit: Hiltjo Posthuma > CommitDate: Sun Feb 25 11:56:43 2024 +0100 > > Fix cursor move with

Re: [hackers] [sbase][PATCH] Add implementation of tac(1)

2024-03-07 Thread Roberto E. Vargas Caballero
Hi, As this is a topic more about sbase/ubase organization more than about patches I am going to move the discussion to the dev mailing list. Please, answer there instead of here in hackers. Regards,

Re: [hackers] [sbase][PATCH] Add implementation of tac(1)

2024-03-07 Thread Roberto E. Vargas Caballero
Hi, I was thinking about what to do with these patches adding new commands. They raised a concern about what should be the scope of sbase. The idea of sbase was to provide a minimal portable POSIX base, while having ubase for the POSIX commands that cannot be implemented in a portable way.

Re: [hackers] [ubase][PATCH 1/4] su: simplify logic

2024-03-07 Thread Roberto E. Vargas Caballero
Hi, On Thu, Mar 07, 2024 at 02:52:49PM -0500, neeshy wrote: > On Thu Mar 7, 2024 at 1:19 PM EST, Roberto E. Vargas Caballero wrote: > > I think it makes it simpler while keeping the correct behaviour that I > > broke. > > Looks good to me! Pushed!

Re: [hackers] [ubase][PATCH 1/4] su: simplify logic

2024-03-07 Thread neeshy
On Thu Mar 7, 2024 at 1:19 PM EST, Roberto E. Vargas Caballero wrote: > I think it makes it simpler while keeping the correct behaviour that I broke. Looks good to me!

Re: [hackers] [ubase][PATCH 1/4] su: simplify logic

2024-03-07 Thread Roberto E. Vargas Caballero
Hi, On Thu, Mar 07, 2024 at 02:18:28AM -0500, neeshy wrote: > It seems that the modifications you made break the use case where su is > called without a username. It would normally default to the root > user, but now it invokes usage() instead. My original patch worked as > intended. Could you

Re: [hackers] [ubase][PATCH 1/4] su: simplify logic

2024-03-06 Thread neeshy
On Wed Mar 6, 2024 at 4:14 AM EST, Roberto E. Vargas Caballero wrote: > Hi, > > > On Mon, Feb 12, 2024 at 04:25:49PM -0500, neeshy wrote: > > Inline dologin, and simplify common code > > I have applied the 4 patches with a minor modification to the 1st > one. > > Kind regards, > Roberto Vargas.

Re: [hackers] [sbase][PATCH] tar: chktar: fix conditional typo

2024-03-06 Thread Roberto E. Vargas Caballero
Hi, On Tue, Mar 05, 2024 at 09:20:57PM +0100, Elie Le Vaillant wrote: > --- > tar.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tar.c b/tar.c > index 0361b63..405b8d9 100644 > --- a/tar.c > +++ b/tar.c > @@ -423,7 +423,7 @@ chktar(struct header *h) >

Re: [hackers] [ubase][PATCH 1/4] su: simplify logic

2024-03-06 Thread Roberto E. Vargas Caballero
Hi, On Mon, Feb 12, 2024 at 04:25:49PM -0500, neeshy wrote: > Inline dologin, and simplify common code I have applied the 4 patches with a minor modification to the 1st one. Kind regards, Roberto Vargas.

Re: [hackers] [sbase][PATCH] libutil/random: better random seed

2024-03-05 Thread NRK
> - *state = ts.tv_nsec; > + *state = (intptr_t) ^ time(NULL) ^ (ts.tv_nsec * 0xAC5533CD); tv_nsec is `long` which is signed. Signed interger overflow is undefined. You need to cast it to `unsigned long` before multiply: ... ^ ((unsigned long)ts.tv_nsec * 0xAC5533CD) - NRK

Re: [hackers] [sbase][PATCH] libutil/random: better random seed

2024-03-05 Thread Steve Ward
On Mon, Mar 4, 2024 at 5:03 PM Elie Le Vaillant wrote: > > Thanks NRK > --- > libutil/random.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libutil/random.c b/libutil/random.c > index 780ba29..6b795a9 100644 > --- a/libutil/random.c > +++ b/libutil/random.c > @@

Re: [hackers] [sbase][PATCH] head: remove useless buffering

2024-03-05 Thread NRK
> + while (i < n && (c = fgetc(fp)) != EOF) { > + if (fputc(c, stdout) == EOF) I don't see this as an improvement. Each one of the fgetc and fputc are going to go through a mutex lock (along with possibly going through a call into a dynamic function). I think the current solution

Re: [hackers] [sbase][PATCH] Add implementation of tac(1)

2024-03-05 Thread Eric Pruitt
On Sun, Mar 03, 2024 at 12:34:16AM +0100, Elie Le Vaillant wrote: > +static void > +tac(FILE *fp) > +{ > + struct linebuf buf = EMPTY_LINEBUF; > + struct line line; > + getlines(fp, ); > + > + if (buf.nolf) { > + /* If the last line is not LF-terminated, the > +

Re: [hackers] [sbase][PATCH v3] tar: sanitize, chktar: leading spaces should be skipped over

2024-03-05 Thread Roberto E. Vargas Caballero
Hi, On Sun, Feb 11, 2024 at 09:26:14AM +0100, Elie Le Vaillant wrote: > Some tar archives (eg. ftp://ftp.gnu.org/gnu/shtool/shtool-2.0.8.tar.gz) > use leading spaces instead of leading zeroes for numeric fields. > Although it is not allowed by the ustar specification, most tar > implementations

Re: [hackers] [sbase][PATCH v2] tar: sanitize: leading zeros should be recognized

2024-03-05 Thread Roberto E. Vargas Caballero
On Tue, Mar 05, 2024 at 01:16:36PM +0100, Roberto E. Vargas Caballero wrote: > Hi, > > On Sat, Feb 10, 2024 at 11:57:38PM +0100, Elie Le Vaillant wrote: > > @@ -399,10 +400,17 @@ sanitize(struct header *h) > > for (i = 0; i < LEN(fields); i++) > > - for (j = 0; j < fields[i].l; j++)

Re: [hackers] [sbase][PATCH v2] tar: sanitize: leading zeros should be recognized

2024-03-05 Thread Roberto E. Vargas Caballero
Hi, On Sat, Feb 10, 2024 at 11:57:38PM +0100, Elie Le Vaillant wrote: > @@ -399,10 +400,17 @@ sanitize(struct header *h) > for (i = 0; i < LEN(fields); i++) > - for (j = 0; j < fields[i].l; j++) > + for (leading = 1, j = 0; j < fields[i].l; j++) >

Re: [hackers] [sbase][PATCH] Add implementation of tac(1)

2024-03-04 Thread Eolien55
Eric Pruitt wrote: > I think there should be separate implementations for seekable vs > non-seekable files to avoid buffering the entire contents of > the file in memory unnecessarily. In fact, performance could be also improved for non-seekable files by forcing a seekable context, ie. use a

Re: [hackers] [st][PATCH] set upper limit for REP escape sequence argument

2024-03-04 Thread Hiltjo Posthuma
On Mon, Mar 04, 2024 at 10:24:36PM +0200, Tommi Hirvola wrote: > On Mon, Mar 04, 2024 at 01:55:29PM +0100, Hiltjo Posthuma wrote: > > I'm not sure about it. You could still chain REP sequences and "DoS" it. > > Fortunately, chained REP sequences can be terminated with ^C. You can > try this by

Re: [hackers] [st][PATCH] set upper limit for REP escape sequence argument

2024-03-04 Thread Tommi Hirvola
On Mon, Mar 04, 2024 at 01:55:29PM +0100, Hiltjo Posthuma wrote: > I'm not sure about it. You could still chain REP sequences and "DoS" it. Fortunately, chained REP sequences can be terminated with ^C. You can try this by copy-pasting the following line into st and pressing CTRL+C: $ for i in

Re: [hackers] [st][PATCH] set upper limit for REP escape sequence argument

2024-03-04 Thread Hiltjo Posthuma
On Mon, Mar 04, 2024 at 12:56:30PM +0200, Tommi Hirvola wrote: > Previously, printf 'L\033[2147483647b' would call tputc('L') 2^31 times, > making st unresponsive. This commit allows repeating the last character > at most 65535 times in order to prevent freezing and DoS attacks. > --- > st.c | 2

Re: [hackers] Re: [sbase] Orphan patches and unsent patches

2024-03-03 Thread NRK
On Sun, Mar 03, 2024 at 03:05:47PM +0100, Eolien55 wrote: > but should we not rather implement "Debiased Int Mult (t-opt)"? Both should be fine. The integer mul method avoids clz() so that could be a reason to prefer it. > arc4random(3) doesn't uses seeds, which means that I cannot initialize >

Re: [hackers] Re: [sbase] Orphan patches and unsent patches

2024-03-03 Thread Eolien55
NRK wrote: > I'd recommend using the bitmask approach described in here: > https://www.pcg-random.org/posts/bounded-rands.html#bitmask-with-rejection-unbiased-apples-method I thought the approach used by OpenBSD was simpler, and performed better, becaused it avoided the loop, which might cause

Re: [hackers] Re: [sbase] Orphan patches and unsent patches

2024-03-02 Thread NRK
On Sun, Mar 03, 2024 at 12:58:20AM +0100, Elie Le Vaillant wrote: > I'm using the web interface to the mailing list to check what has been > sent, and these patches were not sent. The web archive is not reliable and often drops mails. > + * Copied off OpenBSD (original is arc4random_uniform) > +

Re: [hackers] Penfing patches for sbase and ubase

2024-02-27 Thread Elie Le Vaillant
"Roberto E. Vargas Caballero" wrote: > I know that there are some pending patches for sbase and ubase, > but I am a bit busy these days and I will not be able to look > a bit deeper on them until next week. Be patient until then :) > > Thank you Sure, no problem! I've sent most of the patches

Re: [hackers] [st] Fix cursor move with wide glyphs || Quentin Rameau

2024-02-25 Thread Tim Culverhouse
On Sun Feb 25, 2024 at 8:13 AM CST, Quentin Rameau wrote: > Would you have a suggestion about how to handle cursor absolute > position with text position, maybe we need some addition state? I would suggest that cursor position control sequences should always operate on a single-column basis. This

Re: [hackers] [st] Fix cursor move with wide glyphs || Quentin Rameau

2024-02-25 Thread Quentin Rameau
> Hi, Hola k0ga, > > st would always move back 1 column, > > even with wide glyhps (using more than a single column). > > > > The glyph rune is set on its first column, > > and the other ones are to 0, > > so loop until we detect the start of the previous glyph. > >

Re: [hackers] [st] Fix cursor move with wide glyphs || Quentin Rameau

2024-02-25 Thread Roberto E. Vargas Caballero
Hi, On Sun, Feb 25, 2024 at 11:57:03AM +0100, g...@suckless.org wrote: > st would always move back 1 column, > even with wide glyhps (using more than a single column). > > The glyph rune is set on its first column, > and the other ones are to 0, > so loop until we detect

Re: [hackers] [st][PATCH] csi: check for private marker in 'S' case

2024-02-18 Thread Hiltjo Posthuma
On Sun, Feb 18, 2024 at 06:56:49AM -0600, Tim Culverhouse wrote: > The handler for 'S' final character does not check for a private > marker. This can cause a conflict with a sequence called 'XTSMGRAPHICS' > which also has an 'S' final character, but uses the private marker '?'. > Without checking

Re: [hackers] [sbase][PATCH] expr: tonum: handle case where result was previously calculated

2024-01-30 Thread Roberto E. Vargas Caballero
Hi, On Mon, Jan 22, 2024 at 02:18:10PM -0700, Randy Palamar wrote: > As pointed out in a mail to dev expr was segfaulting when multiple > math operations were specified on the command line: eg. 'expr 3 \* > 2 + 1'. This happens because the tonum(), introduced in e50d533, > assumed that v->str was

Re: [hackers] [sbase][PATCH 2/2] expr: don't evaluate matched substr as a number

2024-01-16 Thread Roberto E. Vargas Caballero
Hi, On Sun, Jan 07, 2024 at 11:02:18AM -0700, Randy Palamar wrote: > POSIX specifies that if the pattern contains a subexpression then > the first matched subexpression should be returned if it exists. > > This fixes things like the following: > > ./expr 3 : '\(.*\)' > Before: 3 > After:

Re: [hackers] [sbase][PATCH 1/2] expr: treat expressions as strs until evaluation

2024-01-16 Thread Roberto E. Vargas Caballero
Hi On Sun, Jan 07, 2024 at 11:02:17AM -0700, Randy Palamar wrote: > Comparison operations (>, <, =, etc.) and matching operations must > operate originally provided string not one that has gone back and > forth through string formatting. This caused operations such as > the following to give

Re: [hackers] ed: Enable multi line commands

2023-12-28 Thread Roberto E. Vargas Caballero
Hi, On Sun, Dec 24, 2023 at 12:07:44PM +0100, Rene Kita wrote: > On Wed, Dec 13, 2023 at 12:55:26PM +0100, Roberto E. Vargas Caballero wrote: > > It changes to read full lines before executing commands, escaping > > newlines when it is needed. It solves 2 different cases: > > > > -

Re: [hackers] [PATCH 1/6] ed: Add optional parameter to string()

2023-12-28 Thread Roberto E. Vargas Caballero
Hi, On Tue, Dec 26, 2023 at 03:40:36PM +0100, Страхиња Радић wrote: > On 23/12/24 11:46AM, Rene Kita wrote: > > > + if (!from) { > > > + len = 0; > > > + t = NULL; > > > + } else { > > This seems redundant. Normally, NULL shouldn't be passed, and even if it is, > it > is the

Re: [hackers] [PATCH 1/6] ed: Add optional parameter to string()

2023-12-28 Thread Roberto E. Vargas Caballero
Hi, On Sun, Dec 24, 2023 at 11:46:26AM +0100, Rene Kita wrote: > Nit as it's more a matter of style: I'd prefer to have one function to > create a String and another function to create a String from a char > array. This would make a cleaner interface and avoids passing and > dealing with NULL all

Re: [hackers] [PATCH 1/6] ed: Add optional parameter to string()

2023-12-26 Thread Страхиња Радић
On 23/12/24 11:46AM, Rene Kita wrote: > > + if (!from) { > > + len = 0; > > + t = NULL; > > + } else { This seems redundant. Normally, NULL shouldn't be passed, and even if it is, it is the responsibility of the "user-programmer" (think libc functions). This is further

Re: [hackers] ed: Enable multi line commands

2023-12-24 Thread Rene Kita
On Wed, Dec 13, 2023 at 12:55:26PM +0100, Roberto E. Vargas Caballero wrote: > It changes to read full lines before executing commands, escaping > newlines when it is needed. It solves 2 different cases: > > - Substitution commands with newlines in the replace part This does not work with

Re: [hackers] [PATCH 1/6] ed: Add optional parameter to string()

2023-12-24 Thread Rene Kita
Comment inline. On Wed, Dec 13, 2023 at 12:55:27PM +0100, Roberto E. Vargas Caballero wrote: > This makes possible to use the function to initialize the string from > an existing char array. > --- > ed.c | 30 +- > 1 file changed, 21 insertions(+), 9 deletions(-) > >

Re: [hackers] [svkbd][PATCH] this patch fixes uppercase in armenian (and perhaps some other) layouts. svkbd was previously registering a key in one modification (xorg accepts up to 4 modifications). w

2023-12-14 Thread նորայր
good, thank you. (: On Wed, 13 Dec 2023 19:12:00 +0100 Hiltjo Posthuma wrote: > Hi, > > Thanks, I've applied the patch and fixed a tiny typo in the debug message. > > I haven't tested the patch, but I trust you that it works. > > Of course if people notice bugs, feel free to report them. >

Re: [hackers] [svkbd][PATCH] this patch fixes uppercase in armenian (and perhaps some other) layouts. svkbd was previously registering a key in one modification (xorg accepts up to 4 modifications). w

2023-12-13 Thread Hiltjo Posthuma
Hi, Thanks, I've applied the patch and fixed a tiny typo in the debug message. I haven't tested the patch, but I trust you that it works. Of course if people notice bugs, feel free to report them. On Wed, Dec 13, 2023 at 04:30:17PM +0400, նորայր wrote: > also no need to know armenian to test.

Re: [hackers] [svkbd][PATCH] this patch fixes uppercase in armenian (and perhaps some other) layouts. svkbd was previously registering a key in one modification (xorg accepts up to 4 modifications). w

2023-12-13 Thread նորայր
also no need to know armenian to test. just run ./svkbd-mobile-intl and type lowercase and uppercase in armenian layout. do that for the patched version and you'll see the difference. for some reason on sxmo/postmarketos i have to restart the device in order to run a newer binary. though i

Re: [hackers] [svkbd][PATCH] this patch fixes uppercase in armenian (and perhaps some other) layouts. svkbd was previously registering a key in one modification (xorg accepts up to 4 modifications). w

2023-12-13 Thread նորայր
ok let me try to explain this very simply. some time ago i have added armenian and dvorak layouts. i have noticed that in dvorak and all other layouts uppercase characters work. while you don't have to do any extra effort for that. let's say: ``` { 0, 0, XK_a, 1 }, { 0, 0, XK_o, 1

Re: [hackers] [sbase] sbase-box: Fix segmentation fault when exe without args

2023-12-05 Thread Roberto E. Vargas Caballero
Hi, On Fri, Dec 01, 2023 at 01:33:36PM +0100, Jules Maselbas wrote: > when sbase-box is executed without argument, the check sbase-box > options doesn't verify the argument count leading to a segfault. > > Add a check on the argc before parsing sbase-box options (currently > only `-i`) Applied,

Re: [hackers] [sbase][PATCH] ed: Allow newlines in a Substitute Command

2023-12-05 Thread Roberto E. Vargas Caballero
Hi, On Wed, Nov 15, 2023 at 08:56:56AM +0100, Rene Kita wrote: > > I think the way to fix this problem is reading the full command before > > executing it, otherwise there are so many traps. I am going to try to > > fix this in th enext days. > > I had the same idea. Reading the full command

Re: [hackers] [svkbd][PATCH] this patch fixes uppercase in armenian (and perhaps some other) layouts. svkbd was previously registering a key in one modification (xorg accepts up to 4 modifications). w

2023-12-03 Thread Hiltjo Posthuma
On Sun, Dec 03, 2023 at 08:22:04PM +0400, norayr chilingarian wrote: > --- > svkbd.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/svkbd.c b/svkbd.c > index e4dbd15..cce2463 100644 > --- a/svkbd.c > +++ b/svkbd.c > @@ -481,9 +481,18 @@ press(Key *k, KeySym

Re: [hackers] [sbase][PATCH] ed: Allow newlines in a Substitute Command

2023-11-15 Thread Rene Kita
On Tue, Nov 14, 2023 at 07:42:03PM +0100, Roberto E. Vargas Caballero wrote: > Hi, > > On Sun, Nov 05, 2023 at 02:38:20PM +0100, Rene Kita wrote: > > On Fri, Nov 03, 2023 at 01:32:37PM +0100, Rene Kita wrote: > > > borked patch > > > > Patch is not sufficient, sorry for the noise. > [...] > I

Re: [hackers] [sbase][PATCH] ed: Allow newlines in a Substitute Command

2023-11-14 Thread Roberto E. Vargas Caballero
Hi, On Sun, Nov 05, 2023 at 02:38:20PM +0100, Rene Kita wrote: > On Fri, Nov 03, 2023 at 01:32:37PM +0100, Rene Kita wrote: > > borked patch > > Patch is not sufficient, sorry for the noise. I have this problem in my radar. I began to write a solution for it, but I had to switch to implement

Re: [hackers] [sbase] TODO: add replacement bug reported for ed || Hiltjo Posthuma

2023-11-14 Thread Roberto E. Vargas Caballero
Applied, thanks.

Re: [hackers] [PATCH] find: Make parameter error messages more specific

2023-11-14 Thread Roberto E. Vargas Caballero
Applied, thanks.

Re: [hackers] [PATCH 2/2] scripts: Fix non-portable find -perm /mode

2023-11-14 Thread Roberto E. Vargas Caballero
Applied, thanks.

Re: [hackers] [PATCH 1/2] scripts: Fix non-portable usage of find -maxdepth

2023-11-14 Thread Roberto E. Vargas Caballero
Applied, thanks.

Re: [hackers] [PATCH] scripts: Force file copying on install

2023-11-14 Thread Roberto E. Vargas Caballero
Applied, thanks.

Re: [hackers] [PATCH] make: fix rogue parameter in install target

2023-11-14 Thread Roberto E. Vargas Caballero
Applied, thanks.

Re: [hackers] [sbase][PATCH] ed: Allow newlines in a Substitute Command

2023-11-05 Thread Rene Kita
On Fri, Nov 03, 2023 at 01:32:37PM +0100, Rene Kita wrote: > borked patch Patch is not sufficient, sorry for the noise.

Re: [hackers] [PATCH 2/2] scripts: Fix non-portable find -perm /mode

2023-10-29 Thread Quentin Rameau
> > I guess that the original intent of the code here > > was to to find any executable file. > > I concur. It seems to me that the default output mode for `cc` is 755 > even if the parent directory has more restrictive permissions. So the > more concise -perm -111 should suffice. I will leave

Re: [hackers] [PATCH 2/2] scripts: Fix non-portable find -perm /mode

2023-10-29 Thread Randy Palamar
> Not exactly, -perm -111 matches if at least the mode has executable bit > for all (could be 751 for example), > while GNU -perm /111 matches if any bit is set (could be 500). Thanks for the info, I didn't really check the GNU manpage. > I guess that the original intent of the code here > was

Re: [hackers] [PATCH 2/2] scripts: Fix non-portable find -perm /mode

2023-10-29 Thread Quentin Rameau
> Hi Quentin, Hola Randy, > > -find . ! -name . -prune -type f -perm /111 | > > +find . ! -name . -prune -type f \( -perm -u+x -o -perm -g+x -o -perm o+x > > \) | > > I believe `-perm -111` is equivalent and specified by POSIX. Not exactly, -perm -111 matches if at least the mode has

Re: [hackers] [PATCH 2/2] scripts: Fix non-portable find -perm /mode

2023-10-29 Thread Randy Palamar
Hi Quentin, > -find . ! -name . -prune -type f -perm /111 | > +find . ! -name . -prune -type f \( -perm -u+x -o -perm -g+x -o -perm o+x \) | I believe `-perm -111` is equivalent and specified by POSIX. - Randy

Re: [hackers] [st][PATCH] Add terminfo entries for bracketed paste mode

2023-10-12 Thread Hiltjo Posthuma
On Thu, Oct 12, 2023 at 12:40:15PM +0200, Peter Hofmann wrote: > It has been brought to my attention that this patch breaks pasting text > in older versions of Vim, e.g. the ones coming with OpenBSD 7.2 or > Ubuntu 22.04. The ncurses terminfo db mentions that Vim 9.0.1117 or > newer is needed. >

Re: [hackers] [st][PATCH] Add terminfo entries for bracketed paste mode

2023-10-12 Thread Peter Hofmann
It has been brought to my attention that this patch breaks pasting text in older versions of Vim, e.g. the ones coming with OpenBSD 7.2 or Ubuntu 22.04. The ncurses terminfo db mentions that Vim 9.0.1117 or newer is needed. IIUC, old Vim doesn't read PS/PE from terminfo but it does read BE/BD, so

Re: [hackers] [st][PATCH] Unhide cursor on RIS (\033c)

2023-10-08 Thread Peter Hofmann
Hi Hiltjo, you're welcome, and thanks for merging. Cheers Peter

Re: [hackers] [st][PATCH] Unhide cursor on RIS (\033c)

2023-10-08 Thread Hiltjo Posthuma
On Sat, Oct 07, 2023 at 07:40:45AM +0200, Peter Hofmann wrote: > From: Peter Hofmann > > It is unclear if it's "required" to do this on RIS, but it's useful when > calling reset(1) after interactive programs have crashed and garbled up > the screen. > > FWIW, other terminals do it as well

Re: [hackers] [dwm][PATCH] Implement key shortcut mapping

2023-09-26 Thread suiso67
On 230924-093006, Hiltjo Posthuma 'hil...@codemadness.org' wrote: > > >On Sun, Sep 24, 2023 at 05:34:48AM +, suiso67@macadamia.rocks wrote: >> From: suiso67 >> >> --- >> config.def.h | 43 +++ >> dwm.c| 47

Re: [hackers] [sbase][PATCH] Ensure commands are followed by a blank

2023-09-26 Thread Roberto E. Vargas Caballero
Applied.

Re: [hackers] [st] [PATCH] Makefile: always output the build options, even when building with install

2023-09-25 Thread David Demelier
On Fri, 2023-09-22 at 15:12 +0200, Hiltjo Posthuma wrote: > On Sun, Sep 17, 2023 at 12:11:28AM +, Tom Schwindl wrote: > > --- > >  Makefile | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index 470ac86407bb..6eb2d9d04852 100644 > > ---

Re: [hackers] [dwm][PATCH] Implement key shortcut mapping

2023-09-24 Thread Hiltjo Posthuma
On Sun, Sep 24, 2023 at 05:34:48AM +, suiso67@macadamia.rocks wrote: > From: suiso67 > > --- > config.def.h | 43 +++ > dwm.c| 47 +++ > 2 files changed, 90 insertions(+) > > diff --git

Re: [hackers] [st] [PATCH] Makefile: always output the build options, even when building with install

2023-09-22 Thread Hiltjo Posthuma
On Sun, Sep 17, 2023 at 12:11:28AM +, Tom Schwindl wrote: > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 470ac86407bb..6eb2d9d04852 100644 > --- a/Makefile > +++ b/Makefile > @@ -40,7 +40,7 @@ dist: clean > tar -cf

Re: [hackers] [sbase][PATCH] xargs: implement -I flag

2023-09-22 Thread Roberto E. Vargas Caballero
Hi, On Sun, Jul 30, 2023 at 10:15:49AM +0300, sewn wrote: > From 9f4be567ff25fee986976c6afa193223496013a6 Mon Sep 17 00:00:00 2001 > From: sewn > Date: Fri, 28 Jul 2023 18:58:37 +0300 > Subject: [PATCH] xargs: add replace string flag (-I) I have applied the patch with some small modifications

Re: [hackers] [ubase][PATCH] Explicitly include sys/sysmacros.h for makedev etc

2023-09-21 Thread Roberto E. Vargas Caballero
On Sun, Aug 06, 2023 at 03:03:21PM +0200, Markus Rudy wrote: > This header used to be included by sys/types.h in glibc, and musl > adopted the behaviour. However, this dependency was never desired, so > glibc deprecated it in 2016 and finally removed it in 2019, and so Applied.

Re: [hackers] [sbase][PATCH] tr: fix behavior of cflag when using character classes

2023-09-21 Thread Roberto E. Vargas Caballero
Hi, On Sun, Aug 06, 2023 at 10:50:25PM +0200, noneofyourbusin...@danwin1210.de wrote: > a simple test case: > > printf ab3 | tr -c '[:alpha:]' '\n' Applied.

Re: [hackers] [dwm][PATCH] gruvbok dark hard color scheme

2023-09-04 Thread Chris Down
Open source writes: Some people like me find it beautiful, simple, and comfortable eye, It's a personal preference at the end of the day, it's just a simple patch for those who want it. This mailing list is for mainline patch submissions and discussion, please submit other things to the

Re: [hackers] [dwm][PATCH] gruvbok dark hard color scheme

2023-09-03 Thread Open source
On 9/1/23 23:16, Ethan Marshall wrote: I do not like this color scheme, the old iconic suckless blue is much better! Why does it need changing? Some people like me find it beautiful, simple, and comfortable eye, It's a personal preference at the end of the day, it's just a simple patch for

Re: [hackers] [dwm][PATCH] gruvbok dark hard color scheme

2023-09-01 Thread Ethan Marshall
> I do not like this color scheme, the old iconic suckless blue is much > better! Why does it need changing? It is possible that this was intended to be submitted to the wiki instead. In which case, http://suckless.org/hacking/. Ethan

Re: [hackers] [dwm][PATCH] gruvbok dark hard color scheme

2023-09-01 Thread Christopher Lang
On Fri, Sep 01, 2023 at 08:44:50PM +0300, anas.elgarhy@gmail.com wrote: > From: Anas Elgarhy > > --- > config.def.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/config.def.h b/config.def.h > index 9efa774..d357f2c 100644 > --- a/config.def.h > +++

Re: [hackers] [dmenu][PATCH] Allow only one dmenu_run selection

2023-08-30 Thread Hiltjo Posthuma
On Wed, Aug 30, 2023 at 11:25:18AM -0700, Jeremy wrote: > On 08/30/23 05:41PM, Christopher Lang wrote: > > This would be my implementation for executing all selected commands: > > > > #!/bin/sh > > for x in $(dmenu_path | dmenu "$@"); do > > echo "$x" | ${SHELL:-"/bin/sh"} & > > done > > > > I

Re: [hackers] [dmenu][PATCH] Allow only one dmenu_run selection

2023-08-30 Thread Hiltjo Posthuma
On Wed, Aug 30, 2023 at 05:41:28PM +0100, Christopher Lang wrote: > On Wed, Aug 30, 2023 at 05:48:13PM +0200, Страхиња Радић wrote: > > On 23/08/30 09:43AM, Randy Palamar wrote: > > > Personally I see little need for such a patch. I don't really > > > think anyone is pressing + by mistake; they >

Re: [hackers] [dmenu][PATCH] Allow only one dmenu_run selection

2023-08-30 Thread Jeremy
On 08/30/23 05:41PM, Christopher Lang wrote: > This would be my implementation for executing all selected commands: > > #!/bin/sh > for x in $(dmenu_path | dmenu "$@"); do > echo "$x" | ${SHELL:-"/bin/sh"} & > done > > I suppose this behaviour is more intuitive, but it is a little more >

Re: [hackers] [dmenu][PATCH] Allow only one dmenu_run selection

2023-08-30 Thread Christopher Lang
On Wed, Aug 30, 2023 at 05:48:13PM +0200, Страхиња Радић wrote: > On 23/08/30 09:43AM, Randy Palamar wrote: > > Personally I see little need for such a patch. I don't really > > think anyone is pressing + by mistake; they > > are nowhere near each other on most (all?) keyboard layouts. A dmenu

Re: [hackers] [dmenu][PATCH] Allow only one dmenu_run selection

2023-08-30 Thread Страхиња Радић
On 23/08/30 09:43AM, Randy Palamar wrote: > Personally I see little need for such a patch. I don't really > think anyone is pressing + by mistake; they > are nowhere near each other on most (all?) keyboard layouts. > > Actually I didn't even know about this feature despite using > dmenu in a

Re: [hackers] [dmenu][PATCH] Allow only one dmenu_run selection

2023-08-30 Thread Randy Palamar
On Wed, Aug 30, 2023 at 6:13 AM Christopher Lang wrote: > > Using +, multiple selections can be make in dmenu, each > outputting on a new line. If multiple selections are made in dmenu_run > then multiple lines will be piped to $SHELL which will not be properly > handled. > > This patch only

Re: [hackers] [dwm][patch] Stop input focus on pointers unselected monitor

2023-08-27 Thread Hiltjo Posthuma
On Sun, Aug 27, 2023 at 08:09:47PM +0100, Christopher Lang wrote: > To get more feedback on this patch, I will submit it to the wiki under > the name fixmultimon. In the patch wiki page, I will add a message > explaining it is intended for the mainline but is waiting for more > feedback. > > -- >

Re: [hackers] [dwm][patch] Stop input focus on pointers unselected monitor

2023-08-27 Thread Christopher Lang
To get more feedback on this patch, I will submit it to the wiki under the name fixmultimon. In the patch wiki page, I will add a message explaining it is intended for the mainline but is waiting for more feedback. -- Christopher

Re: [hackers] [dwm][patch] Stop input focus on pointers unselected monitor

2023-08-17 Thread Страхиња Радић
On 23/08/17 09:22, Christopher Lang wrote: > Say you have two tiled monitors: M1 and M2. M1 and M2 each contain a > single client occupying their full area. M1 is selected, the pointer is > in M2. If a keybinding is pressed that moves M1's client to M2, then the > new monitor selected depends on

Re: [hackers] [dwm][patch] Stop input focus on pointers unselected monitor

2023-08-17 Thread Christopher Lang
On Wed, Aug 16, 2023 at 07:30:05PM +0200, Hiltjo Posthuma wrote: > On Wed, Aug 16, 2023 at 06:06:40PM +0200, Storkman wrote: > > On Wed, Aug 16, 2023 at 10:07:16AM +0200, Hiltjo Posthuma wrote: > > > On Tue, Aug 15, 2023 at 10:43:32AM +0100, Christopher Lang wrote: > > > > When the pointer is on

Re: [hackers] [dwm][patch] Stop input focus on pointers unselected monitor

2023-08-16 Thread Hiltjo Posthuma
On Wed, Aug 16, 2023 at 06:06:40PM +0200, Storkman wrote: > On Wed, Aug 16, 2023 at 10:07:16AM +0200, Hiltjo Posthuma wrote: > > On Tue, Aug 15, 2023 at 10:43:32AM +0100, Christopher Lang wrote: > > > When the pointer is on an unselected monitor and is not moving, it > > > should not interfere

Re: [hackers] [dwm][patch] Stop input focus on pointers unselected monitor

2023-08-16 Thread Storkman
On Wed, Aug 16, 2023 at 10:07:16AM +0200, Hiltjo Posthuma wrote: > On Tue, Aug 15, 2023 at 10:43:32AM +0100, Christopher Lang wrote: > > When the pointer is on an unselected monitor and is not moving, it > > should not interfere what window is selected/focused. > > [...] > > If focusmon selects a

Re: [hackers] [dwm][patch] Stop input focus on pointers unselected monitor

2023-08-16 Thread Hiltjo Posthuma
On Tue, Aug 15, 2023 at 10:43:32AM +0100, Christopher Lang wrote: > When the pointer is on an unselected monitor and is not moving, it > should not interfere what window is selected/focused. > > 1: > > From > https://tronche.com/gui/x/xlib/events/input-focus/normal-and-grabbed.html: > When the

Re: [hackers] help

2023-08-05 Thread Raheman Vaiya
Perhaps his kidnappers have forced him to write this email 樂. On Thu, Aug 3, 2023 at 3:20 PM Dr. André Desgualdo Pereira wrote: > > That's a huge relief! > > On 03/08/2023 12:29, Christopher Lang wrote: > > I was trying to subscribe to the mailing list but didn't get a response > > from so I

Re: [hackers] help

2023-08-03 Thread Dr . André Desgualdo Pereira
That's a huge relief! On 03/08/2023 12:29, Christopher Lang wrote: > I was trying to subscribe to the mailing list but didn't get a response > from so I tried this. I think I have figured it > out not though. > Sorry if I pinged you. And I'm fine haha. > PS. I'm sorry if this is html mail, still

Re: [hackers] help

2023-08-03 Thread Laslo Hunhold
On Thu, 3 Aug 2023 12:29:04 +0100 Christopher Lang wrote: Dear Christopher, > I was trying to subscribe to the mailing list but didn't get a > response from so I tried this. I think I > have figured it out not though. > Sorry if I pinged you. And I'm fine haha. > PS. I'm sorry if this is html

Re: [hackers] help

2023-08-03 Thread Christopher Lang
I was trying to subscribe to the mailing list but didn't get a response from so I tried this. I think I have figured it out not though. Sorry if I pinged you. And I'm fine haha. PS. I'm sorry if this is html mail, still trying to set up a better email client. On Thu, 3 Aug 2023 at 12:14, Dr.

Re: [hackers] help

2023-08-03 Thread Dr . André Desgualdo Pereira
Can anyone track where Christopher is? Does anyone know a friend of him? Maybe he was kidnapped or in risk of suicide. Maybe call local police? On 02/08/2023 23:10, Christopher Lang wrote: > help

Re: [hackers] [dwm][patch] ISO 8859-1-only window name bugfix

2023-07-13 Thread Страхиња Радић
On 23/07/12 10:28PM, Hiltjo Posthuma wrote: > Unless I'm missing something. It seems like an application or environment > issue. > > For dwm it is assumed the environment is utf-8 and application should use it. Sorry, I forgot to list my locale-related variables. They are set up as such:

Re: [hackers] [dwm][patch] ISO 8859-1-only window name bugfix

2023-07-12 Thread Hiltjo Posthuma
On Wed, Jul 12, 2023 at 06:48:45PM +0200, Страхиња Радић wrote: > Hi, recently André Desgualdo Pereira reported a bug in dwm when window names > consist only of characters in ISO 8859-1. In short, windows with such names > had their names broken at the place of ISO 8859-1-specific characters

Re: [hackers] [dmenu][PATCH] minor improvement to the nomatches cache

2023-07-07 Thread NRK
Hi Hiltjo, On Thu, Jul 06, 2023 at 07:08:57PM +0200, Hiltjo Posthuma wrote: > What hash algorithm is this exactly, it looks interesting? I've found it at: > > https://github.com/skeeto/hash-prospector > > Is that the one? The "xor-shift multiply" construct itself is fairly popular and can

  1   2   3   4   5   6   7   8   9   10   >