Re: [hackers] [surf][PATCH] Add support for WebGL

[Quentin Rameau]

> Allows enabling and disabling WebGL support built into WebKit.
> The feature is turned off by default.

Thanks, applied!
(sorry for the delay)

Re: [hackers] [surf][PATCH] add support for WebGL

[Quentin Rameau]

Hi Eon,

Thank you for your patch, I'll push it soon.

> + [WebGl]   =   { { .i = 1 }, },

Looks like you sent the same patch again.
Don't worry though, I can modify it before pushing it, I'll take care
of it.

-- Quentin

Re: Re: [hackers] [surf][PATCH] add support for WebGL

[Eon S. Jeon]

On 09/26/2017 01:24 AM, Hiltjo Posthuma wrote:


The default should be off (0) imho.

Ya, I totally agree with you. I was just trying to get the patch 
reviewed before putting it on the wiki. But, now, I'm just gonna submit 
a new one with the default flipped, and get this thing applied. :)

Re: [hackers] [surf][PATCH] add support for WebGL

[Hiltjo Posthuma]

On Sun, Sep 24, 2017 at 10:35:45PM +0900, Eon S. Jeon wrote:
> ---
>  config.def.h | 1 +
>  surf.c   | 5 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/config.def.h b/config.def.h
> index 2e735bf..ec99e27 100644
> --- a/config.def.h
> +++ b/config.def.h
> @@ -46,6 +46,7 @@ static Parameter defconfig[ParameterLast] = {
>   [SpellLanguages]  =   { { .v = ((char *[]){ "en_US", NULL }) }, 
> },
>   [StrictTLS]   =   { { .i = 1 }, },
>   [Style]   =   { { .i = 1 }, },
> + [WebGl]   =   { { .i = 1 }, },
>   [ZoomLevel]   =   { { .f = 1.0 },   },
>  };
>  
> diff --git a/surf.c b/surf.c
> index 0f8b9c9..65b2aeb 100644
> --- a/surf.c
> +++ b/surf.c
> @@ -79,6 +79,7 @@ typedef enum {
>   SpellLanguages,
>   StrictTLS,
>   Style,
> + WebGl,
>   ZoomLevel,
>   ParameterLast
>  } ParamName;
> @@ -820,6 +821,9 @@ setparameter(Client *c, int refresh, ParamName p, const 
> Arg *a)
>   setstyle(c, getstyle(geturi(c)));
>   refresh = 0;
>   break;
> + case WebGl:
> + webkit_settings_set_enable_webgl(s, a->i);
> + break;
>   case ZoomLevel:
>   webkit_web_view_set_zoom_level(c->view, a->f);
>   return; /* do not update */
> @@ -1079,6 +1083,7 @@ newview(Client *c, WebKitWebView *rv)
>  "enable-accelerated-2d-canvas", 
> curconfig[AcceleratedCanvas].val.i,
>  "enable-site-specific-quirks", curconfig[SiteQuirks].val.i,
>  "enable-smooth-scrolling", curconfig[SmoothScrolling].val.i,
> +"enable-webgl", curconfig[WebGl].val.i,
>  "media-playback-requires-user-gesture", 
> curconfig[MediaManualPlay].val.i,
>  NULL);
>  /* For more interesting settings, have a look at
> -- 
> 2.11.0
> 
> 

The default should be off (0) imho.

-- 
Kind regards,
Hiltjo