Re: [PATCH] cld: use XDR for all messages

2010-01-13 Thread Pete Zaitcev
On Wed, 13 Jan 2010 16:03:45 -0500 Jeff Garzik j...@garzik.org wrote: Well, this definitely does not build as-is. lib/Makefile.am needs BUILT_SOURCES = cld_msg_rpc.h otherwise nothing builds at all, because cld_msg_rpc.h does not exist. test/Makefile.am and

Re: [PATCH] cld: use XDR for all messages

2010-01-13 Thread Jeff Garzik
On 01/10/2010 10:00 AM, Colin McCabe wrote: This patch moves CLD from using manual data serialization to using XDR (via rpcgen). Both the packet header and the message body are now serialized and deserialized using XDR. This makes it easy to have a variable-length packet header, as well as a

Re: [PATCH] cld: use XDR for all messages

2010-01-13 Thread Colin McCabe
On Wed, Jan 13, 2010 at 4:10 PM, Jeff Garzik j...@garzik.org wrote: OK, final review. Please fix these problems and resend (some of these repeated from other emails; putting here to consolidate): * needs to build patch builds and runs against a fresh git repo clone + ./autogen.sh +

Re: [PATCH] cld: use XDR for all messages

2010-01-11 Thread Jeff Garzik
On 01/10/2010 10:00 AM, Colin McCabe wrote: This patch moves CLD from using manual data serialization to using XDR (via rpcgen). Both the packet header and the message body are now serialized and deserialized using XDR. This makes it easy to have a variable-length packet header, as well as a