Re: [PATCH 0/6 v2] logging refactoring

2009-12-15 Thread Jeff Garzik
On 12/15/2009 05:47 PM, Pete Zaitcev wrote: On Tue, 15 Dec 2009 17:38:18 -0500 Jeff Garzik wrote: In fact, does anyone even understand why we continue to split LOG_WARNING and LOG_ERR? We really have three log levels: - debug - info (which is actually an error) - error (not really all

Re: [PATCH 0/6 v2] logging refactoring

2009-12-15 Thread Pete Zaitcev
On Tue, 15 Dec 2009 17:38:18 -0500 Jeff Garzik wrote: > > In fact, does anyone even understand why we continue to split > > LOG_WARNING and LOG_ERR? We really have three log levels: > > - debug > > - info (which is actually an error) > > - error (not really all that different from info actu

Re: [PATCH 0/6 v2] logging refactoring

2009-12-15 Thread Jeff Garzik
On 12/15/2009 01:19 PM, Pete Zaitcev wrote: On Mon, 14 Dec 2009 18:18:47 -0800 Colin McCabe wrote: Also my new patch creates a hail_log.h. It didn't really seem right to force everyone who wanted to use HAIL_LOG to include cldc.h. I'll convert over the rest of chunkd and tabled to the new mac

Re: [PATCH 0/6 v2] logging refactoring

2009-12-15 Thread Pete Zaitcev
On Mon, 14 Dec 2009 18:18:47 -0800 Colin McCabe wrote: > Also my new patch creates a hail_log.h. It didn't really seem right to > force everyone who wanted to use HAIL_LOG to include cldc.h. > > I'll convert over the rest of chunkd and tabled to the new macros if > this patch series gets accepte

Re: [PATCH 0/6 v2] logging refactoring

2009-12-14 Thread Colin McCabe
On Mon, Dec 14, 2009 at 12:36 PM, Jeff Garzik wrote: > On 12/14/2009 02:23 AM, Colin McCabe wrote: >> >> Hi all, >> >> I think I'm going to respin this patch to be a lot smaller. Just >> refactor one or two things, but leave the existing "verbose" and >> "applog" system in place. Let me know what

Re: [PATCH 0/6 v2] logging refactoring

2009-12-14 Thread Jeff Garzik
On 12/14/2009 02:23 AM, Colin McCabe wrote: Hi all, I think I'm going to respin this patch to be a lot smaller. Just refactor one or two things, but leave the existing "verbose" and "applog" system in place. Let me know what you think-- do you think I should push ahead with HAIL_DEBUG etc., We

Re: [PATCH 0/6 v2] logging refactoring

2009-12-13 Thread Colin McCabe
Hi all, I think I'm going to respin this patch to be a lot smaller. Just refactor one or two things, but leave the existing "verbose" and "applog" system in place. Let me know what you think-- do you think I should push ahead with HAIL_DEBUG etc., cheers. Colin On Tue, Dec 8, 2009 at 4:11 PM, C

[PATCH 0/6 v2] logging refactoring

2009-12-09 Thread Colin McCabe
This patch series creates a common.h and populates it with some function prototypes and logging stuff. version 2: * Rename CLD_DEBUG, etc. to HAIL_DEBUG * use angle brackets for including common.h from include/ Colin McCabe (6): cld: Declare common.c functions in common.h cld: create logging