Re: [PATCH v2 2/2] cld: read the cld.port file using g_file_get_contents

On 11/27/2009 09:23 PM, Colin McCabe wrote: Signed-off-by: Colin McCabecmcc...@alumni.cmu.edu --- lib/common.c | 29 +++-- 1 files changed, 15 insertions(+), 14 deletions(-) diff --git a/lib/common.c b/lib/common.c index 68f60f8..db20e2a 100644 --- a/lib/common.c

Re: [PATCH v2 2/2] cld: read the cld.port file using g_file_get_contents

On 11/28/2009 05:37 AM, Jeff Garzik wrote: 1) 'buf' is no longer nul-terminated, which means strtol() has become a buffer overrun. Whoops, it seems I am incorrect on this, according to http://library.gnome.org/devel/glib/stable/glib-File-Utilities.html#g-file-get-contents Ignore that point.