Re: [Patch 1/1] CLD: Introduce the New CLD API

2010-02-17 Thread Jeff Garzik
On 02/17/2010 07:05 PM, Pete Zaitcev wrote: On Sat, 13 Feb 2010 19:52:18 -0500 Jeff Garzikj...@garzik.org wrote: A point of style: the 'p' suffix is discouraged. I'll batch-rename it when I get better. Get well soon... Since it sounds like there will be no conflicting patches, I went

Re: [Patch 1/1] CLD: Introduce the New CLD API

2010-02-08 Thread Jeff Garzik
On 02/07/2010 02:15 PM, Pete Zaitcev wrote: The traditional CLD API is too difficult to program. In particular, switching from a rigid Group policy to arbitrary paths in existing clients in Chunk and tabled turned out to be next to impossible. The issue is due to the fundamental nature of the

Re: [Patch 1/1] CLD: Introduce the New CLD API

2010-02-08 Thread Jeff Garzik
On 02/08/2010 08:46 PM, Pete Zaitcev wrote: On Mon, 08 Feb 2010 07:32:56 -0500 Jeff Garzikj...@garzik.org wrote: - log param in cldc-dns should not be made conditional as an undocumented side effect of ncld I pulled, and it appears that you merged a code that crashes at the first error

Re: [Patch 1/1] CLD: Introduce the New CLD API

2010-02-08 Thread Pete Zaitcev
On Mon, 08 Feb 2010 21:06:17 -0500 Jeff Garzik j...@garzik.org wrote: - if (cldc_getaddr(host_list, hostb, NULL)) + if (cldc_getaddr(host_list, hostb, ncld_log)) return 1001; Logging pointer should be supplied by the caller... that is the larger bug. Needing a no-op

Re: [Patch 1/1] CLD: Introduce the New CLD API

2010-02-08 Thread Jeff Garzik
On 02/08/2010 09:17 PM, Pete Zaitcev wrote: On Mon, 08 Feb 2010 21:06:17 -0500 Jeff Garzikj...@garzik.org wrote: - if (cldc_getaddr(host_list, hostb, NULL)) + if (cldc_getaddr(host_list, hostb,ncld_log)) return 1001; Logging pointer should be supplied by the

Re: [Patch 1/1] CLD: Introduce the New CLD API

2010-02-08 Thread Pete Zaitcev
On Mon, 08 Feb 2010 23:55:03 -0500 Jeff Garzik j...@garzik.org wrote: - if (cldc_getaddr(host_list, hostb, NULL)) + if (cldc_getaddr(host_list, hostb,ncld_log)) return 1001; Logging pointer should be supplied by the caller... that is the larger bug. Needing a no-op