Jeff Garzik wrote:
On 09/10/2010 08:55 AM, Jim Meyering wrote:
* server/msg.c (msg_get): Copy only name_len bytes, then NUL-terminate,
rather than using snprintf to copy up to and including nonexistent NUL.
---
valgrind exposed this. The use of snprintf would have been
correct
Jeff Garzik wrote:
On 09/23/2010 04:43 AM, Jim Meyering wrote:
From fb7865d158b0d32907dde703c4d37c70a26e738c Mon Sep 17 00:00:00 2001
From: Jim Meyeringmeyer...@redhat.com
Date: Thu, 23 Sep 2010 10:11:44 +0200
Subject: [PATCH tabled 1/2] server/config.c: don't dereference NULL on OOM
(see
do another round.
Otherwise, I can send a patch to update all of the
remaining ones to include 2010 so this won't be an
issue for 3 more months.
$ git shortlog HEAD ^origin/master
Jim Meyering (4):
server/server.c: use sizeof(s) rather than equivalent 64
don't dereference NULL on OOM
Jeff Garzik wrote:
On 09/24/2010 07:32 AM, Jim Meyering wrote:
You can pull from the oom branch here:
git://git.infradead.org/users/meyering/tabled.git
Got nearly everything perfect. Need one more minor yet important
change. As described in doc/contributions.txt, every changeset MUST
Signed-off-by: Jim Meyering meyer...@redhat.com
---
I would have preferred to insert a single line right before the
huri_field_escape call:
char *v = strdup(val);
[would result in a more compact, single-hunk patch]
but it looks like hail uses the anachronistic (pre-C99)
declare all vars
Pete Zaitcev wrote:
On Mon, 27 Sep 2010 10:53:06 +0200
Jim Meyering j...@meyering.net wrote:
-stmp = huri_field_escape(strdup(val), QUERY_ESCAPE_MASK);
+v = strdup(val);
+stmp = huri_field_escape(v, QUERY_ESCAPE_MASK);
str = g_string_append(str, stmp);
free(stmp
(gthread.c:1893)
by 0x31BB407760: start_thread (pthread_create.c:301)
by 0x31BA8E151C: clone (clone.S:115)
Signed-off-by: Jim Meyering meyer...@redhat.com
---
Thanks to Pete for catching my error.
To make up for that, here's a real leak fix:
chunkd/selfcheck.c |1 +
1 files changed, 1
Make write_cb callback's buffer parameter const, like all write-like
functions.
Give a few char * parameters the const attribute.
Signed-off-by: Jim Meyering meyer...@redhat.com
---
It looks like most of hail's interfaces are const-correct,
but one stood out because it provokes a warning when I
Jeff Garzik wrote:
On 10/06/2010 08:07 AM, Jim Meyering wrote:
...
It looks like most of hail's interfaces are const-correct,
but one stood out because it provokes a warning when I tried to
pass a const-correct write_cb function to hstor_get from iwhd:
...
include/hstor.h |4 ++--
lib
buffer.
Signed-off-by: Jim Meyering meyer...@redhat.com
---
test/large-object.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/test/large-object.c b/test/large-object.c
index dbe2027..fc7d03c 100644
--- a/test/large-object.c
+++ b/test/large-object.c
@@ -1,6 +1,6
Jeff Garzik wrote:
On 10/06/2010 08:07 AM, Jim Meyering wrote:
Make write_cb callback's buffer parameter const, like all write-like
functions.
Give a few char * parameters the const attribute.
Signed-off-by: Jim Meyeringmeyer...@redhat.com
---
It looks like most of hail's interfaces
Jeff Garzik wrote:
...
Hi Jeff.
Sorry I didn't notice that the first time.
I built with ./autogen.sh ./configure make.
It looks like you recommend -Wall -Wshadow.
The two warnings above are the only ones I see with the patch,
and they're easy to fix. When storing const pointer params
Jeff Garzik wrote:
...
But even if curl were requiring some suboptimal signature,
it would be nice not to impose that on all projects that use hail.
Are there older curl headers that do require the const-free signature?
If there are and you want to support them, too, let me know -- maybe
I
Pete Zaitcev wrote:
Hi, Jim:
Autoconf printed a warning when reconfiguting Hail, so I gave up and
added this:
diff --git a/configure.ac b/configure.ac
index 9cfad23..d378854 100644
--- a/configure.ac
+++ b/configure.ac
@@ -62,6 +62,8 @@ AC_PROG_GCC_TRADITIONAL
AM_PROG_CC_C_O
Jeff Garzik wrote:
On 12/06/2010 12:44 PM, Pete Zaitcev wrote:
On Mon, 06 Dec 2010 12:32:22 -0500
Jeff Garzikj...@garzik.org wrote:
Keeping the correct libtool macros in-tree implies adding a pointless
maintenance burden. The distro always gives us correct, up-to-date
files. Why would
FYI, /usr/include/rpc/ no longer exists, as of F15's glibc-headers-2.13.90-10,
so hail's lib/cld_msg_rpc.h will have to do something about this #include:
$ grep rpc.h lib/cld_msg_rpc.h
#include rpc/rpc.h
--
To unsubscribe from this list: send the line unsubscribe hail-devel in
the body of
16 matches
Mail list logo
