Re: [PATCH v2] MINOR: http: Log warning if (add|set)-header fails

2018-05-28 Thread Willy Tarreau
On Mon, May 28, 2018 at 09:19:11PM +0200, Tim Düsterhus wrote: > Willy, > > Am 28.05.2018 um 14:59 schrieb Willy Tarreau: > > OK this was fine. I noticed that you also emitted the value for the servers > > but that this one was not filled in the code, and that there was almost > > nothing to do

Re: [PATCH v2] MINOR: http: Log warning if (add|set)-header fails

2018-05-28 Thread Tim Düsterhus
Willy, Am 28.05.2018 um 14:59 schrieb Willy Tarreau: > OK this was fine. I noticed that you also emitted the value for the servers > but that this one was not filled in the code, and that there was almost > nothing to do to get it, for the response case, which is useful because if > you see that

Re: JWT payloads break b64dec convertor

2018-05-28 Thread Benoît GARNIER
Le 28/05/2018 à 10:19, Adis Nezirovic a écrit : > On 05/26/2018 04:27 PM, Jonathan Matthews wrote: >> Hello folks, >> >> The payload (and other parts) of a JSON Web Token (JWT, a popular and >> growing auth standard: https://tools.ietf.org/html/rfc7519) is base64 >> encoded. >> >> Unfortunately,

Re: JWT payloads break b64dec convertor

2018-05-28 Thread Aleksandar Lazic
On 28/05/2018 17:42, Norman Branitsky wrote: https://en.wikipedia.org/wiki/The_C_Programming_Language Oh, of course *clap on head* how embarrassing 8-O. I haven't thought to THIS Book, sorry. Best regards Aleks -Original Message- From: Aleksandar Lazic Sent: Monday, May 28, 2018

RE: JWT payloads break b64dec convertor

2018-05-28 Thread Norman Branitsky
https://en.wikipedia.org/wiki/The_C_Programming_Language -Original Message- From: Aleksandar Lazic Sent: Monday, May 28, 2018 12:34 PM To: Jonathan Matthews Cc: Willy Tarreau ; haproxy Subject: Re: JWT payloads break b64dec convertor On 28/05/2018 15:10, Jonathan Matthews wrote: >On

Re: JWT payloads break b64dec convertor

2018-05-28 Thread Aleksandar Lazic
On 28/05/2018 15:10, Jonathan Matthews wrote: On Mon, 28 May 2018 at 14:26, Willy Tarreau wrote: On Mon, May 28, 2018 at 01:43:41PM +0100, Jonathan Matthews wrote: > Improvements and suggestions welcome; flames and horror -> /dev/null ;-) Would anyone be interested in adding two

Re: remaining process after (seamless) reload

2018-05-28 Thread William Lallemand
On Thu, May 24, 2018 at 11:00:29PM +0200, William Dauchy wrote: > On Thu, May 24, 2018 at 12:01:38PM +0200, William Lallemand wrote: > > I managed to reproduce something similar with the 1.8.8 version. It looks > > like > > letting a socat connected to the socket helps. > > > > I'm looking into

Re: JWT payloads break b64dec convertor

2018-05-28 Thread Willy Tarreau
On Mon, May 28, 2018 at 03:10:01PM +0100, Jonathan Matthews wrote: > On Mon, 28 May 2018 at 14:26, Willy Tarreau wrote: > > > On Mon, May 28, 2018 at 01:43:41PM +0100, Jonathan Matthews wrote: > > > Improvements and suggestions welcome; flames and horror -> /dev/null ;-) > > > >

Re: JWT payloads break b64dec convertor

2018-05-28 Thread Jonathan Matthews
On Mon, 28 May 2018 at 14:26, Willy Tarreau wrote: > On Mon, May 28, 2018 at 01:43:41PM +0100, Jonathan Matthews wrote: > > Improvements and suggestions welcome; flames and horror -> /dev/null ;-) > > Would anyone be interested in adding two new converters for this, > working

Re: haproxy and solarflare onload

2018-05-28 Thread Elias Abacioglu
Hi Willy and HAproxy folks! Sorry for bumping this old thread. But Solarflare recently released a new Onload version. http://www.openonload.org/download/openonload-201805-ReleaseNotes.txt Here is a small excerpt from the Release Notes: " A major overhaul to clustering and scalable filters

Re: JWT payloads break b64dec convertor

2018-05-28 Thread Willy Tarreau
On Mon, May 28, 2018 at 01:43:41PM +0100, Jonathan Matthews wrote: > Improvements and suggestions welcome; flames and horror -> /dev/null ;-) Would anyone be interested in adding two new converters for this, working exactly like base64/b64dec but with the URL-compatible base64 encoding instead ?

Re: [PATCHES] Fix bugs in the new scheduler

2018-05-28 Thread Willy Tarreau
On Mon, May 28, 2018 at 03:16:19PM +0200, Olivier Houchard wrote: > Hi, > > Unsurprisingly, the scheduler revamp that was committed last week has bugs. :-) > The main issue is that threads could sleep while there are still tasks to > run, there are also fairness issues between the global

[PATCHES] Fix bugs in the new scheduler

2018-05-28 Thread Olivier Houchard
Hi, Unsurprisingly, the scheduler revamp that was committed last week has bugs. The main issue is that threads could sleep while there are still tasks to run, there are also fairness issues between the global runqueue and the local one. The attached patches should fix that. Regards, Olivier

Re: [PATCH v2] MINOR: http: Log warning if (add|set)-header fails

2018-05-28 Thread Willy Tarreau
Hi again Tim, On Mon, May 28, 2018 at 10:57:59AM +0200, Willy Tarreau wrote: > > I added a counter and verified that it works using the stats socket. I > > copied > > it from elsewhere in proto_http. Please check whether I did correctly (not > > overcounting and such things). Also check whether

Re: JWT payloads break b64dec convertor

2018-05-28 Thread Jonathan Matthews
On 28 May 2018 at 12:32, Jonathan Matthews wrote: > I think with your points and ccripy's sneaky (kudos!) padding > insertion, I can do something which suffices for my current audit > needs. For the list, here's my working v1 that I ended up with. I'm sure various things

Re: JWT payloads break b64dec convertor

2018-05-28 Thread Jonathan Matthews
On 28 May 2018 at 09:19, Adis Nezirovic wrote: > On 05/26/2018 04:27 PM, Jonathan Matthews wrote: >> Hello folks, >> >> The payload (and other parts) of a JSON Web Token (JWT, a popular and >> growing auth standard: https://tools.ietf.org/html/rfc7519) is base64 >>

Re: [PATCH] BUG/MEDIUM: stick-tables: Decrement ref_cnt in table_* converters

2018-05-28 Thread Willy Tarreau
Hi Daniel, On Sun, May 27, 2018 at 12:31:54PM -0400, Daniel Corbett wrote: > I have attached the latest patch with these changes. Now merged, thank you! willy

Re: JWT payloads break b64dec convertor

2018-05-28 Thread Adis Nezirovic
On 05/26/2018 04:27 PM, Jonathan Matthews wrote: > Hello folks, > > The payload (and other parts) of a JSON Web Token (JWT, a popular and > growing auth standard: https://tools.ietf.org/html/rfc7519) is base64 > encoded. > > Unfortunately, the payload encoding (specified in >

Re: haproxy 1.9 status update

2018-05-28 Thread Frederic Lecaille
On 05/25/2018 06:10 PM, Willy Tarreau wrote: Hi all, [sniped] - peers over SSL [Fred] : the purpose is to allow all bind options with peers so that peers can exchange information securely. I think I've seen it posted somewhere, I'll have to dig through the archives. Here are