BUG: segfault with lua sample converters & wrong arg types

2018-06-14 Thread Patrick Hemmer
Haproxy segfaults if you pass the wrong argument type to a converter. Example: haproxy.cfg: global lua-load /tmp/haproxy.lua frontend f1 mode http bind :8000 default_backend b1 http-request lua.foo backend b1 mode http

Re: Connections stuck in CLOSE_WAIT state with h2

2018-06-14 Thread Willy Tarreau
On Thu, Jun 14, 2018 at 07:22:34PM +0200, Janusz Dziemidowicz wrote: > 2018-06-14 18:56 GMT+02:00 Willy Tarreau : > > > If you'd like to run a test, I'm attaching the patch. > > Sure, but you forgot to attach it :) Ah, that's because I'm stupid :-) Here it comes this time. Willy diff --git

Re: Connections stuck in CLOSE_WAIT state with h2

2018-06-14 Thread Janusz Dziemidowicz
2018-06-14 18:56 GMT+02:00 Willy Tarreau : > If you'd like to run a test, I'm attaching the patch. Sure, but you forgot to attach it :) -- Janusz Dziemidowicz

Re: [PATCHES] Fix a few shortcomings in the tasklet code

2018-06-14 Thread Willy Tarreau
On Thu, Jun 14, 2018 at 04:27:04PM +0200, Olivier Houchard wrote: > Attached are 2 patches that fix a few bugs in the tasklet code. > It should have little incidence right now because tasklets are unused, but > will be useful for later work. Applied, thank you! Willy

Re: Connections stuck in CLOSE_WAIT state with h2

2018-06-14 Thread Willy Tarreau
On Thu, Jun 14, 2018 at 01:51:20PM +0200, Janusz Dziemidowicz wrote: > 2018-06-14 11:46 GMT+02:00 Willy Tarreau : > >> Will try. > > I've tried the seconds path, together with the first one, no change at all. > > However, I was able to catch it on my laptop finally. I still can't > easily

[PATCHES] Fix a few shortcomings in the tasklet code

2018-06-14 Thread Olivier Houchard
Hi, Attached are 2 patches that fix a few bugs in the tasklet code. It should have little incidence right now because tasklets are unused, but will be useful for later work. Regards, Olivier >From fd2838a8b4eae2d9801592889285ae221fc3a7cb Mon Sep 17 00:00:00 2001 From: Olivier Houchard Date:

Re: Connections stuck in CLOSE_WAIT state with h2

2018-06-14 Thread Janusz Dziemidowicz
2018-06-14 11:46 GMT+02:00 Willy Tarreau : >> Will try. I've tried the seconds path, together with the first one, no change at all. However, I was able to catch it on my laptop finally. I still can't easily reproduce this, but at least that's something. Little background, my company makes online

Extra load with unix-socket backend

2018-06-14 Thread accpad1
Hello, I have a heavy loaded local HTTP-cache servers behind Haproxy I've made it use Unix-socket instead of TCP and on the test-server Apache Benchmark show a few percent benefit (tested in 1-2 threads, with small and big files). But when I deployed new settings on few production servers, I

Re: Connections stuck in CLOSE_WAIT state with h2

2018-06-14 Thread Willy Tarreau
On Thu, Jun 14, 2018 at 11:29:39AM +0200, Janusz Dziemidowicz wrote: > 2018-06-14 11:14 GMT+02:00 Willy Tarreau : > > Yep it's really not easy and probably once we find it I'll be ashamed > > saying "I thought this code was not merged"... By the way yesterday I > > found another suspect but I'm

Re: Connections stuck in CLOSE_WAIT state with h2

2018-06-14 Thread Janusz Dziemidowicz
2018-06-14 11:14 GMT+02:00 Willy Tarreau : > Yep it's really not easy and probably once we find it I'll be ashamed > saying "I thought this code was not merged"... By the way yesterday I > found another suspect but I'm undecided on it ; the current architecture > of the H2 mux complicates the code

Re: Connections stuck in CLOSE_WAIT state with h2

2018-06-14 Thread Willy Tarreau
On Wed, Jun 13, 2018 at 08:01:30PM +0200, Janusz Dziemidowicz wrote: > 2018-06-13 19:14 GMT+02:00 Willy Tarreau : > > On Wed, Jun 13, 2018 at 07:06:58PM +0200, Janusz Dziemidowicz wrote: > >> 2018-06-13 14:42 GMT+02:00 Willy Tarreau : > >> > Hi Milan, hi Janusz, > >> > > >> > thanks to your

Re: dev1.9 2018/06/05 threads cpu 100% spin_lock v.s. thread_sync_barrier

2018-06-14 Thread Willy Tarreau
Hi Pieter, On Tue, Jun 12, 2018 at 08:09:08PM +0200, PiBa-NL wrote: > Is there something i can do to find out more info if it happens again? Or > maybe before that build with more specific debug info so if it happens again > more info would be retrievable.?. > (My usual way of 'debugging' with