Re: patch to avoid null pointer dereference

2018-10-01 Thread Willy Tarreau
Hi Ilya, On Tue, Oct 02, 2018 at 09:16:23AM +0500, ??? wrote: > this one was found by automation, i.e. coverity. > I see haproxy was added to coverity in 2015 and builds were not submitted > since 2015. > > shall we send builds, for example monthly ? It's as you want, the only thing is

Re: patch to avoid null pointer dereference

2018-10-01 Thread Илья Шипицин
вт, 2 окт. 2018 г. в 7:06, Willy Tarreau : > Hi Ilya, > > On Sat, Sep 15, 2018 at 12:55:07AM +0500, ??? wrote: > > hi, > > > > please find attached patch > > > > cheers, > > Ilya Shipitsin > > > From 7961bb27597cf529a88da475d3928d6223a88753 Mon Sep 17 00:00:00 2001 > > From: Ilya

Re: lua time tracking

2018-10-01 Thread Willy Tarreau
Hi Patrick, On Mon, Oct 01, 2018 at 01:08:32PM -0400, Patrick Hemmer wrote: > What are the thoughts around putting time tracking stats around LUA > calls? Just really basic info like how long a request spent running LUA > code. Similar to how we already have metrics for time spent in queue, >

Re: PATCH : mux_h2 h2c pointer deref

2018-10-01 Thread Willy Tarreau
Hi, On Sun, Sep 23, 2018 at 06:18:37PM +0200, Mildis wrote: > Hi, > > Here is a patch for a null-deref. > It checks if h2c exists before working on it. > For these two patches, I'd prefer to have multiple exit labels than adding some "if" in the error exit path. It's important that the error

Re: faster than load-server-state-from-file?

2018-10-01 Thread Willy Tarreau
Hi Pierre, On Fri, Sep 21, 2018 at 03:50:19PM +, Pierre Cheynier wrote: > I'm extensively using server-templates to avoid reloading too much but still, > backend creation or deletion has to be done by reloading as far as I know. In > my specific context, it can happen every 5/10s or so. > As

Re: patch to avoid null pointer dereference

2018-10-01 Thread Willy Tarreau
Hi Ilya, On Sat, Sep 15, 2018 at 12:55:07AM +0500, ??? wrote: > hi, > > please find attached patch > > cheers, > Ilya Shipitsin > From 7961bb27597cf529a88da475d3928d6223a88753 Mon Sep 17 00:00:00 2001 > From: Ilya Shipitsin > Date: Sat, 15 Sep 2018 00:50:05 +0500 > Subject: [PATCH]

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-01 Thread Willy Tarreau
Hi Pieter, On Mon, Oct 01, 2018 at 11:06:33PM +0200, PiBa-NL wrote: > I have used the exact config above, and well it 'works fine' ?? Results > below.. both types of nc requests send to 1 running haproxy result in a > proper '21'.. OK. > But even in this case the results would be 'predicable',

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-01 Thread PiBa-NL
Hi Frederic, Op 1-10-2018 om 15:15 schreef Frederic Lecaille: On 09/15/2018 02:03 AM, PiBa-NL wrote: Hi List, Willy, Hi Pieter, Sorry for this late reply. I am also sorry to tell you that -D option should not be used anymore because it as been recently broken. It adds an extra 2s delay on

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-01 Thread PiBa-NL
Hi Willy, Op 1-10-2018 om 4:00 schreef Willy Tarreau: On Sun, Sep 30, 2018 at 10:16:55PM +0200, PiBa-NL wrote: Hi Willy, Op 30-9-2018 om 20:38 schreef Willy Tarreau: On Sun, Sep 30, 2018 at 08:22:23PM +0200, Willy Tarreau wrote: On Sun, Sep 30, 2018 at 07:59:34PM +0200, PiBa-NL wrote:

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-10-01 Thread PiBa-NL
Hi Frederic, Op 1-10-2018 om 16:09 schreef Frederic Lecaille: - /connection/b0.vtc probably does not 'really' need abns@ sockets, so changing to unix@ would make it testable on more platforms? Correct. I agree I did not think to replace this part specific to Linux. Should i send a patch

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-10-01 Thread PiBa-NL
Hi Frederic, Op 1-10-2018 om 16:19 schreef Frederic Lecaille: On 09/11/2018 04:51 PM, PiBa-NL wrote: Hi List, I was wondering how to best run the reg-tests that are 'valid' for FreeBSD. There are a 2 tests that use abns@ sockets, which seem not available on FreeBSD. Also 1 test is failing

lua time tracking

2018-10-01 Thread Patrick Hemmer
What are the thoughts around putting time tracking stats around LUA calls? Just really basic info like how long a request spent running LUA code. Similar to how we already have metrics for time spent in queue, connecting, waiting on response, etc. Currently I accomplish this manually by grabbing

RE: Loan Officers

2018-10-01 Thread Lopez Evans
Did you get a chance to review my previous email? Please let me know if you did like to review few sample records from your target audience. Look forward to hearing back. Regards, Lopez From: Lopez Evans Sent: Thursday, September 27, 2018 3:37 PM To: 'haproxy@formilux.org' Subject: Loan

Re: [ANNOUNCE] haproxy-1.9-dev3

2018-10-01 Thread Tim Düsterhus
Willy, Am 29.09.2018 um 20:41 schrieb Willy Tarreau: > Ah, a small change is that we now build with -Wextra after having addressed > all warnings reported up to gcc 7.3 and filtered a few useless ones. If you > get some build warnings, please report them along with your gcc version and > your

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-10-01 Thread Frederic Lecaille
On 09/11/2018 04:51 PM, PiBa-NL wrote: Hi List, I was wondering how to best run the reg-tests that are 'valid' for FreeBSD. There are a 2 tests that use abns@ sockets, which seem not available on FreeBSD. Also 1 test is failing for a reason i'm not totally sure if its totally expected to or

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-10-01 Thread Frederic Lecaille
On 09/11/2018 04:51 PM, PiBa-NL wrote: Hi List, Hi, I was wondering how to best run the reg-tests that are 'valid' for FreeBSD. There are a 2 tests that use abns@ sockets, which seem not available on FreeBSD. Also 1 test is failing for a reason i'm not totally sure if its totally

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-01 Thread Frederic Lecaille
On 09/15/2018 02:03 AM, PiBa-NL wrote: Hi List, Willy, Hi Pieter, Sorry for this late reply. I am also sorry to tell you that -D option should not be used anymore because it as been recently broken. It adds an extra 2s delay on my PC. Without this option, on my PC the test fails but after