Re: Some patches about the master worker

2018-11-06 Thread William Lallemand
On Tue, Nov 06, 2018 at 07:13:26PM +0100, PiBa-NL wrote: > Hi William, > > Something seems to have been broken by below patch series. (when using > threads.?.) > > ***  h1    0.0 debug|[ALERT] 309/191142 (6588) : Current worker #1 > (6589) exited with code 134 (Abort trap) > ***  h1    0.0

Re: haproxy bug: healthcheck not passing after port change when statefile is enabled

2018-11-06 Thread Baptiste
Hi, After debriefing internally, the fix will be much longer and may even trigger a new server-state file format. I keep you updated. Baptiste On Sun, Nov 4, 2018 at 7:11 PM Baptiste wrote: > Hi Sven, > > I reviewed the whole thing and I think the support of port in state file > was added

Re: Some patches about the master worker

2018-11-06 Thread PiBa-NL
Hi William, Something seems to have been broken by below patch series. (when using threads.?.) ***  h1    0.0 debug|[ALERT] 309/191142 (6588) : Current worker #1 (6589) exited with code 134 (Abort trap) ***  h1    0.0 debug|[ALERT] 309/191142 (6588) : exit-on-failure: killing every workers

Re: CLI proxy for master process

2018-11-06 Thread David Birdsong
love socklog! i use it combined w/ s6-log https://skarnet.org/software/s6/s6-log.html On Mon, Nov 5, 2018 at 11:55 PM Aleksandar Lazic wrote: > Hi. > > In the meantime you can use Socklog [1] or fluent-bit [2] to listen to > syslog and write to stdout as I use it in my Image. Pay attention

Re: Some patches about the master worker

2018-11-06 Thread Willy Tarreau
On Tue, Nov 06, 2018 at 05:37:09PM +0100, William Lallemand wrote: > Some improvements for the master-worker. Thanks, whole series merged. I've replaced the warning with a qfprintf() as we discussed so that it's less scary at boot :-) I think we'd benefit from having ha_notice(), ha_info() and

[PATCH 5/7] MEDIUM: mworker: exit with the incriminated exit code

2018-11-06 Thread William Lallemand
The former behavior was to exit() the master process with the latest status code known, which was the one of the last process to exit. The problem is that the master process was not exiting with the status code which provoked the exit-on-failure. --- src/haproxy.c | 6 ++ 1 file changed, 6

[PATCH 6/7] MINOR: mworker: displays a message when a worker is forked

2018-11-06 Thread William Lallemand
Displays the PID and the relative PID when we fork a new worker. --- src/haproxy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/haproxy.c b/src/haproxy.c index 88cdc9df3..d092a9bc3 100644 --- a/src/haproxy.c +++ b/src/haproxy.c @@ -2995,6 +2995,7 @@ int main(int argc, char **argv)

[PATCH 7/7] MEDIUM: mworker: leave when the master die

2018-11-06 Thread William Lallemand
When the master die, the worker should exit too, this is achieved by checking if the FD of the socketpair/pipe was closed between the master and the worker. In the former architecture of the master-worker, there was only a pipe between the master and the workers, and it was easy to check an EOF

[PATCH 3/7] MEDIUM: mworker: does not create the CLI proxy when no listener

2018-11-06 Thread William Lallemand
Does not create the CLI proxy if no -S argument was specified. It prevents a warning that says that the MASTER proxy does not have any bind option. --- src/cli.c | 3 ++- src/haproxy.c | 25 +++-- 2 files changed, 17 insertions(+), 11 deletions(-) diff --git a/src/cli.c

[PATCH 2/7] MINOR: cli: can't connect to the target CLI

2018-11-06 Thread William Lallemand
Return an error and quit if the CLI proxy is not able to connect to a target. --- src/cli.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cli.c b/src/cli.c index 999e4c09a..32eaf4688 100644 --- a/src/cli.c +++ b/src/cli.c @@ -1926,6 +1926,11 @@ int pcli_wait_for_response(struct

[PATCH 4/7] MINOR: mworker: displays more information when leaving

2018-11-06 Thread William Lallemand
When a worker is leaving, we display the relative PID and the result of the strsignal() function if it was killed by a signal. --- src/haproxy.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/haproxy.c b/src/haproxy.c index b89be13f1..c7ea65d5f 100644 ---

Some patches about the master worker

2018-11-06 Thread William Lallemand
Some improvements for the master-worker.

[PATCH 1/7] MINOR: cli: show the number of reload in 'show proc'

2018-11-06 Thread William Lallemand
Displays the number of reload in the life of each worker. --- src/cli.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cli.c b/src/cli.c index 510e1e349..999e4c09a 100644 --- a/src/cli.c +++ b/src/cli.c @@ -1402,12 +1402,12 @@ static int

Re: Issue with HAProxy as a forward proxy

2018-11-06 Thread Aleksandar Lazic
Hi Vijay. Am 06.11.2018 um 10:06 schrieb Vijay Bais: > Hello, > > I'm using HAProxy 1.8 as a forward proxy with below configuration > > > > defaults >     mode                    tcp >     log                     global >     option                  tcplog >     option     

Preserve backend uptime after reload

2018-11-06 Thread Maximilian Böhm
Hello, I've setup the procedure to store and load the stats file from the socket after a reload in order to retain the uptime of my backends. But it actually does only retain the uptime of the frontend, backend uptime is starting by 0s. Is it thought this way or am I doing something wrong? The

Issue with HAProxy as a forward proxy

2018-11-06 Thread Vijay Bais
Hello, I'm using HAProxy 1.8 as a forward proxy with below configuration defaults modetcp log global option tcplog option dontlognull option http-server-close #option forwardfor except