Re: [PATCH] DOC: fix various typos in the CHANGELOG

2018-11-07 Thread Willy Tarreau
On Wed, Nov 07, 2018 at 10:21:09PM -0800, Joseph Herlant wrote: > > Thus I *tend* to think that fixing these changelogs would not > > significantly help ut could add a bit of difficulty over time, > > and I'd prefer to leave them as-is, at least for the git part. > > Probably that the older parts

Re: [PATCH] DOC: fix various typos in the CHANGELOG

2018-11-07 Thread Joseph Herlant
Hi Willy, On Wed, Nov 7, 2018 at 8:48 PM Willy Tarreau wrote: > This case is very interesting because there is no easy answer. > Given that our changelogs are now automatically produced from > git log, I tend to think we'd rather not adjust them, because > their only use case is to either

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-11-07 Thread Willy Tarreau
Hi guys, On Wed, Nov 07, 2018 at 09:37:14AM +0100, Frederic Lecaille wrote: > > New 'version' of the script attached. > > It now supports a set of parameters to modify its behavior a little. And > > also checking for a 'version requirement'. So a H2 test doesn't have to > > fail on 1.7. > > Very

Re: Sponsorship

2018-11-07 Thread Willy Tarreau
Hi Pete, On Wed, Nov 07, 2018 at 11:10:52AM +0100, Pete Zaborszky wrote: > Hi, I noticed one of our competitors appearing here on your site: > http://www.haproxy.org/they-use-it.html > > I'd also like to appear here, we have some relevant content. I'd also be > happy to donate some money if

Re: [PATCH] DOC: fix various typos in the CHANGELOG

2018-11-07 Thread Willy Tarreau
Hi Joseph, On Wed, Nov 07, 2018 at 06:03:14PM -0800, Joseph Herlant wrote: > Hi, > > Please find attached a patch to cleanup typos in the changelog. I'm > not sure where you stand on cleaning up typos in changelogs, some > people totally refuse to allow that, hence a totally separate patch > for

Re: [PATCH] BUG/MINOR: cli: Fix memory leak

2018-11-07 Thread Willy Tarreau
On Thu, Nov 08, 2018 at 12:54:55AM +0100, William Lallemand wrote: > On Thu, Nov 08, 2018 at 12:47:00AM +0100, Tim Düsterhus wrote: > > Hi > > > > Hi Tim, > > > Am 08.11.18 um 00:32 schrieb Tim Duesterhus: > > > if (!str2listener(path, global.stats_fe, bind_conf, "master-socket", 0, > > > ))

Re: Issue with HAProxy as a forward proxy

2018-11-07 Thread Vijay Bais
Hello Aleksandar, I tried running haproxy as root, but it still failed with same logs. Btw, here's the global section used, global log 127.0.0.1 local2 chroot /var/lib/haproxy pidfile /var/run/haproxy.pid maxconn 4000 userroot group

[PATCH] DOC: fix various typos in the CHANGELOG

2018-11-07 Thread Joseph Herlant
Hi, Please find attached a patch to cleanup typos in the changelog. I'm not sure where you stand on cleaning up typos in changelogs, some people totally refuse to allow that, hence a totally separate patch for this. Anyway, here's a cleanup proposal for it. Note: I'm just starting to break down

Re: [PATCH] BUG/MINOR: cli: Fix memory leak

2018-11-07 Thread William Lallemand
On Thu, Nov 08, 2018 at 12:47:00AM +0100, Tim Düsterhus wrote: > Hi > Hi Tim, > Am 08.11.18 um 00:32 schrieb Tim Duesterhus: > > if (!str2listener(path, global.stats_fe, bind_conf, "master-socket", 0, > > )) { > > I just notice that `err` in `mworker_cli_sockpair_new` should probably > be

Re: [PATCH] BUG/MINOR: cli: Fix memory leak

2018-11-07 Thread Tim Düsterhus
Hi Am 08.11.18 um 00:32 schrieb Tim Duesterhus: > if (!str2listener(path, global.stats_fe, bind_conf, "master-socket", 0, > )) { I just notice that `err` in `mworker_cli_sockpair_new` should probably be freed as well. Valgrind did not report this, because I did not have any errors. Can

[PATCH] BUG/MINOR: cli: Fix memory leak

2018-11-07 Thread Tim Duesterhus
Valgrind's memcheck reports memory leaks in cli.c, because the out parameter of memprintf is not properly freed: ==31035== 11 bytes in 1 blocks are definitely lost in loss record 16 of 101 ==31035==at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==31035==

[PR] Fix typos in comments and documentation

2018-11-07 Thread PR Bot
Dear list! Author: Joseph Herlant Number of patches: 1 This is an automated relay of the Github pull request: Fix typos in comments and documentation Patch title(s): Fix typos in comments and documentation Link: https://github.com/haproxy/haproxy/pull/1 Edit locally: wget

Re: Issue with HAProxy as a forward proxy

2018-11-07 Thread Vijay Bais
Thanks for the reply! Here, the haproxy process runs as a *haproxy* user itself. Let me try it as root and revert back. On Tue 6 Nov, 2018, 9:19 PM Aleksandar Lazic, wrote: > Hi Vijay. > > Am 06.11.2018 um 10:06 schrieb Vijay Bais: > > Hello, > > > > I'm using HAProxy 1.8 as a forward proxy

Sponsorship

2018-11-07 Thread Pete Zaborszky
Hi, I noticed one of our competitors appearing here on your site: http://www.haproxy.org/they-use-it.html I'd also like to appear here, we have some relevant content. I'd also be happy to donate some money if needed. Would that be possible? Thanks! Peter Zaborszky

Re: reg-test failures on FreeBSD, how to best adapt/skip some tests?

2018-11-07 Thread Frederic Lecaille
On 10/28/18 8:01 PM, PiBa-NL wrote: Hi Frederic, Hello Pieter, Sorry again for this late reply. Op 19-10-2018 om 11:51 schreef Frederic Lecaille: The idea of the script sounds good to me. About the script itself it is a nice work which could be a good start. Thanks. Just a few details

Re: Some patches about the master worker

2018-11-07 Thread Willy Tarreau
On Wed, Nov 07, 2018 at 08:45:01AM +0100, William Lallemand wrote: > Oh that's funny, the mworker_pipe_register() was supposed to be called > once per process, that's why I put an abort() there, but that's not the case > anymore with nbthread. > > Thanks Pieter. > > Patch attached. applied,