Re: Regarding Client IP

2018-11-15 Thread Bruno Henc
Hello, To get the client IP information on the smtp server you will need to configure haproxy to send proxy protocol data and the smtp server to receive it. Postfix supports proxy protocol and you can see at

Regarding Client IP

2018-11-15 Thread Ram Chandra
Dear Team,I have configured haproxy for smtp server and it is working fine but i am getting haproxy ip instead of client ip.Please suggest, it`s urgent. Thanks : R.C. भाकरMO-9001092999 | E-mail - ram.chan...@dil.in [XGENFOOTER] [-XGENFOOTER] Do not Remove:

[PATCH] CLEANUP: Fix typos in the acl subsystem

2018-11-15 Thread Joseph Herlant
Hi, The attached patch fixes typos in the code comments of the acl subsystem. Thanks, Joseph From 0fa0b0af2c914df1f20be80b6b8d90f526c83e52 Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 14:55:09 -0800 Subject: [PATCH] CLEANUP: Fix typos in the acl subsystem Fix typos in

[PATCH] CLEANUP: Fix typos in the regex subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes typos in the code comment of the regex subsystem. Thanks, Joseph From 6944830de98bf005672546f113e3bf48537f277d Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 14:46:29 -0800 Subject: [PATCH] CLEANUP: Fix typos in the regex subsystem Fix typos in the

[PATCH] CLEANUP: Fix typos in the task subsystem

2018-11-15 Thread Joseph Herlant
Hi, The attached patch fixes typos in the code comments of the task subsystem. Thanks, Joseph From 8c693fb717df1d9cae04a77eea45feb6feab7a16 Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 14:19:23 -0800 Subject: [PATCH] CLEANUP: Fix typos in the task subsystem Fix typos in

[PATCH] CLEANUP: Fix typos in the cache subsystem

2018-11-15 Thread Joseph Herlant
Hi, The attached patch fixes common misspells in the code comments of the cache subsystem. Thanks, Joseph From f5c333cf17b2d6e94630ca356302998338584676 Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 14:07:53 -0800 Subject: [PATCH] CLEANUP: Fix typos in the cache subsystem

[PATCH] CLEANUP: Fix typos in the cfgparse subsystem

2018-11-15 Thread Joseph Herlant
Hi, The attached patch fixes typos in the code comments of the cfgpase subsystem. Thanks, Joseph From 574d9494e16129879aec7c38923a65749b115c7c Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 14:04:19 -0800 Subject: [PATCH] CLEANUP: Fix typos in the cfgparse subsystem Fix

[PATCH] CLEANUP: Fix typos in the http subsystem

2018-11-15 Thread Joseph Herlant
Hi, The attached patch fixes typos in code comment of the http subsystem. Note that I included the changes for those 4 files in it as I think they probably belong to the same subsystem, let me know if it's not the case: * src/flt_http_comp.c * src/http.c * src/http_conv.c * src/http_fetch.c

Re: [PATCH] CLEANUP: Fix typos in the stick_table subsystem

2018-11-15 Thread Joseph Herlant
Sorry I forgot the attachement on this one. On Thu, Nov 15, 2018 at 1:44 PM Joseph Herlant wrote: > > Hi, > > This patch fixes some typos in the code comments of the stick_table subsystem. > > Thanks, > Joseph From 0e2d2be3a8d84024f5ef75c8640cb535201f41ac Mon Sep 17 00:00:00 2001 From: Joseph

[PATCH] MINOR: Fix a typo in a warning message in the spoe subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes a typo in a user-facing message of the spoe subsystem. Thanks, Joseph From 1a241dfc448fd7c6358809b340b89a93177f85ff Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 13:49:02 -0800 Subject: [PATCH] MINOR: Fix a typo in a warning message in the spoe

[PATCH] CLEANUP: Fix typos in the spoe subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes typos in the code comments of the spoe subsystem. Thanks, Joseph From 20610f5c7ee2eaca0de501cc0aab696a21671b75 Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 13:46:49 -0800 Subject: [PATCH] CLEANUP: Fix typos in the spoe subsystem Fix typos in the

[PATCH] CLEANUP: Fix typos in the stick_table subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes some typos in the code comments of the stick_table subsystem. Thanks, Joseph

[PATCH] CLEANUP: Fix a typo in the stats subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes a typo in a code comment of the stats subsystem. Thanks, Joseph From edd5dfe33185086fcba39be781dd957c86882d36 Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 13:39:46 -0800 Subject: [PATCH] CLEANUP: Fix a typo in the stats subsystem Fix a typo in a

[PATCH] CLEANUP: Fix typos in the filters subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes typos in the code comments of the filters subsystems. Thanks, Joseph From b52c553940479a5551917c8e82d83d82ebcc2c6b Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 12:24:23 -0800 Subject: [PATCH] CLEANUP: Fix typos in the filters subsystem Fix typos in

[PATCH] CLEANUP: Fix typos in the peers subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes some typos in the code comments of the peers subsystem. Thanks, Joseph From b097e7d802a895f3fd253aa2e5cceb136b19fd9a Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 12:19:14 -0800 Subject: [PATCH] CLEANUP: Fix typos in the peers subsystem Fix some

[PATCH] CLEANUP: Fix typos in the sample subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes some typos in the code comment of the sample subsystem. Thanks, Joseph From b642de7897c81eb8f566e1e5042816f38d9f6dc8 Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 12:14:56 -0800 Subject: [PATCH] CLEANUP: Fix typos in the sample subsystem Fix some

[PATCH] CLEANUP: Fix typos in the log subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes some misspells in the code comments of the log subsystem. Thanks, Joseph From 2ec313b751d654ef9b28c55c2c691ac93cac8e5f Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 12:10:04 -0800 Subject: [PATCH] CLEANUP: Fix typos in the log subsystem Fix some

[PATCH] MINOR: Fix typo in error message in the standard subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes a typo in an error message that could be user-visible when running out of memory in the parse_binary function. Thanks Joseph From 387a0efc1bdd963c5601906b101c6935ea70f4c2 Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 12:01:22 -0800 Subject: [PATCH]

[PATCH] CLEANUP: Fix typos in the standard subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes typos in the code comments of the standard subsystem. Thanks, Joseph From 0d9920eeacb034f58caf45659ebb0643524a52df Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 11:58:28 -0800 Subject: [PATCH] CLEANUP: Fix typos in the standard subsystem Fix typos in

[PATCH] MINOR: Fix typos in error messages in the proxy subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes typos in error messages that will be user-visible in the proxy subsystem. Thanks Joseph From cd2c9397006e6ecb80d71916213cac9ab680868b Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 11:50:44 -0800 Subject: [PATCH] MINOR: Fix typos in error messages in

[PATCH] MINOR: Fix typos in error messages in the proxy subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes typos in error messages that will be user-visible in the proxy subsystem. Thanks, Joseph From cd2c9397006e6ecb80d71916213cac9ab680868b Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 11:50:44 -0800 Subject: [PATCH] MINOR: Fix typos in error messages in

[PATCH] CLEANUP: fix typos in the proxy subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes typos in the code comments of the proxy subsystem. Thanks, Joseph From 20424768e88ee7ed9fb471a7aa0ef7b34b84d60f Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 11:46:55 -0800 Subject: [PATCH] CLEANUP: fix typos in the proxy subsystem Fix typos in the

[PATCH] MINOR: Fix an error message thrown by the haproxy subsystem when running out of memory

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes a typo in an error message that can be seen by the end user when the haproxy subsystem runs out of memory. Thanks Joseph From 60babb1440788215ff86323c7f98d930b5d643eb Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 10:43:05 -0800 Subject: [PATCH] MINOR:

[PATCH] CLEANUP: Fix some typos in the haproxy subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes some typos found in the code comments of the haproxy subsystem. Thanks Joseph From 0520e8b0fc5e47a1578e9d175c3aeb980ca83371 Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 15 Nov 2018 10:41:50 -0800 Subject: [PATCH] CLEANUP: Fix some typos in the haproxy subsystem

[PATCH] CLEANUP: Fix typos in the dns subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes some typos in the code comments of the dns subsystem. Note that a typo has been found in the name of the `prefered_query_type` variable which should be `preferred_query_type`, but I'm not sure if you're ok with me fixing that too, so I left it out for now. The patch is

[PATCH] CLEANUP: Fix typos in the pattern subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes typos in the code comments of the pattern subsystem. The patch is attached, but if you want to view the diff online, you can check: https://github.com/haproxy/haproxy/compare/master...aerostitch:cleanup_pattern_typos Thanks Joseph From

[PATCH 1&2] CLEANUP & MINOR: fix typos in the hlua subsystem

2018-11-15 Thread Joseph Herlant
Hi, Please find attached 2 patches that fix typos in the hlua subsystem. One of them is minor as it ends up being visible by the end-user when an error 500 is sent back from the hlua subsystem. I grouped them together as they are the same subject on the same subsystem but with different

[PATCH] CLEANUP: fix typos in the hlua_fcn subsystem

2018-11-15 Thread Joseph Herlant
Hi, Fixes typos detected in the code comments of the hlua_fcn subsystem using the misspell tool and other ones detected manually. The patch is attached, but if you want to view the diff online, you can check: https://github.com/haproxy/haproxy/compare/master...aerostitch:cleanup_hlua_fcn_typos

[PATCH] CLEANUP: fix 2 typos in the xxhash subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes 2 typos in the code comments of the xxhash subsystem. The patch is attached, but if you want to view the diff online, you can check: https://github.com/haproxy/haproxy/compare/master...aerostitch:cleanup_xxhash_typos Thanks, Joseph From

[PATCH] CLEANUP: fix typos in the proto_http subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes typos in the code comments of the proto_http subsystem using misspell, same as previous patches. The patch is attached, but if you want to view the diff online, you can check: https://github.com/haproxy/haproxy/compare/master...aerostitch:cleanup_proto_http_typos Thanks,

[PATCH] CLEANUP: fix typos in the comments of the vars subsystem

2018-11-15 Thread Joseph Herlant
Hi, Those are mostly misspells of the words available and variable. The patch is attached, but if you want to view the diff online, you can check: https://github.com/haproxy/haproxy/compare/master...aerostitch:cleanup_vars_typos Thanks, Joseph From 0fc4fabcd22d966b51d9498e26b94ea65445acf3 Mon

[PATCH] CLEANUP: fix a typo found in the stream subsystem

2018-11-15 Thread Joseph Herlant
Hi, This typo is in a code comment so not end-user visible. The patch is attached, but if you want to view the diff online, you can check: https://github.com/haproxy/haproxy/compare/master...aerostitch:ceanup_stream_typo Thanks, Joseph From b67b60971611ed3d9769d15c0a097316c2a3a371 Mon Sep 17

[PATCH] CLEANUP: fix typos in the ssl_sock subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes a few typos found in the comments of the ssl_sock subsystem. The patch is attached, but if you want to view the diff online, you can check: https://github.com/haproxy/haproxy/compare/master...aerostitch:cleanup_ssl_sock_typos Thanks Joseph From

[PATCH] CLEANUP: fix a few typos in the comments of the server subsystem

2018-11-15 Thread Joseph Herlant
Hi, This patch fixes a few typos found in the comments of the server subsystem. The patch is attached, but if you want to view the diff online, you can check: https://github.com/haproxy/haproxy/compare/master...aerostitch:cleanup_server_typos Thanks, Joseph From

Re: 1.9b6 301 redirect anomaly

2018-11-15 Thread Dave Cottlehuber
On Thu, 15 Nov 2018, at 14:49, Christopher Faulet wrote: > Le 15/11/2018 à 11:14, Dave Cottlehuber a écrit : > > bonjour list, > > > > In comparison to 1.8 (and probably 1.9b5 but I can't verify that at > > present) the 301 redirect seems to be handled differently. Initially I > > thought this

Re: Difference between rspdel and http-response del-header use case?

2018-11-15 Thread Jerome Magnin
Hi, On Thu, Nov 15, 2018 at 02:01:18PM +, Ricardo Fraile wrote: > Hello, > > > What is the difference between using one of the following rules instead > of the other? > > I think that rspdel is the historic way to do, but maybe it have other > implications. > > > rspdel ^Server.* > > or

Difference between rspdel and http-response del-header use case?

2018-11-15 Thread Ricardo Fraile
Hello, What is the difference between using one of the following rules instead of the other? I think that rspdel is the historic way to do, but maybe it have other implications. rspdel ^Server.* or http-response del-header Server Thanks,

Re: 1.9b6 301 redirect anomaly

2018-11-15 Thread Christopher Faulet
Le 15/11/2018 à 11:14, Dave Cottlehuber a écrit : bonjour list, In comparison to 1.8 (and probably 1.9b5 but I can't verify that at present) the 301 redirect seems to be handled differently. Initially I thought this was an HTTP2 issue but it 's reproducible on HTTP/1.1 as well. Hi Dave, A

Re: [PATCH] BUG/CRITICAL: SIGBUS crash on aarch64

2018-11-15 Thread Olivier Houchard
On Thu, Nov 15, 2018 at 02:26:59PM +0100, Willy Tarreau wrote: > On Thu, Nov 15, 2018 at 11:58:36AM +0100, Olivier Houchard wrote: > > Willy, can you push the attached patch ? > > Applied, thanks. I've just slightly edited it to put parenthesis around > "i" below : > > > +#define

Re: [PATCH] BUG/CRITICAL: SIGBUS crash on aarch64

2018-11-15 Thread Willy Tarreau
On Thu, Nov 15, 2018 at 11:58:36AM +0100, Olivier Houchard wrote: > Willy, can you push the attached patch ? Applied, thanks. I've just slightly edited it to put parenthesis around "i" below : > +#define round_ptr_size(i) ((i + (sizeof(void *) - 1)) &~ (sizeof(void *) - > 1)) so that if

Re: [PATCH] BUG/CRITICAL: SIGBUS crash on aarch64

2018-11-15 Thread Olivier Houchard
On Thu, Nov 15, 2018 at 09:48:20AM +, Paul Martin wrote: > On Wed, Nov 14, 2018 at 06:05:00PM +0100, Olivier Houchard wrote: > > > Oops, you're right indeed. > > I'm not sure I'm a big fan of special-casing STD_T_UINT. For example, > > STD_T_FRQP is probably 12bytes too, so it'd be a problem.

1.9b6 301 redirect anomaly

2018-11-15 Thread Dave Cottlehuber
bonjour list, In comparison to 1.8 (and probably 1.9b5 but I can't verify that at present) the 301 redirect seems to be handled differently. Initially I thought this was an HTTP2 issue but it 's reproducible on HTTP/1.1 as well. curl --http1.1 -4vsSLo /dev/null https://logs.example.com/ >

Re: [PATCH] BUG/CRITICAL: SIGBUS crash on aarch64

2018-11-15 Thread Paul Martin
On Wed, Nov 14, 2018 at 06:05:00PM +0100, Olivier Houchard wrote: > Oops, you're right indeed. > I'm not sure I'm a big fan of special-casing STD_T_UINT. For example, > STD_T_FRQP is probably 12bytes too, so it'd be a problem. > Can you test the (untested, but hopefully right) patch attached ?