Re: http2-issue with http2 enabled on frontend and on backend

2019-02-26 Thread Tom
Hi Willy I've applied your patch and now the website responds with http2..., many thanks for this. The current situation looks like this: - When I directly connect with http2 to the nginx, which has server-side-pushing enabled, my browser receive this push-traffic (without any GET-requests

Re: [RFC PATCH] MEDIUM: compression: Add support for brotli compression

2019-02-26 Thread Willy Tarreau
Hi Tim, On Tue, Feb 26, 2019 at 06:16:12PM +0100, Tim Düsterhus wrote: > Willy, > > Am 13.02.19 um 17:57 schrieb Tim Duesterhus: > > *snip* > > Are you able to give some (first, basic) feedback on this patch already? Not yet. In fact I don't know much what to think about it. The patch itself

Re: Wrong sha256 checksum for HAProxy 1.8 and 1.9?

2019-02-26 Thread Kevin Mao
Thanks everyone. Confirmed this is working now. Kevin On Tuesday, February 26, 2019, 5:15:58 AM PST, Willy Tarreau wrote: Hi all, On Tue, Feb 26, 2019 at 01:29:54PM +0100, Cyril Bonté wrote: > > De: "Tim Düsterhus" > > À: "Cyril Bonté" , "Willy Tarreau" , > > "Kevin Mao" > > Cc:

regtest, response lenght check failure for /reg-tests/http-capture/h00000.vtc with HTX enabled, using 2.0-dev1

2019-02-26 Thread PiBa-NL
Hi List, Christopher, With 2.0-dev1-6c1b667 and 2.0-dev1-12a7184 i get the 'failure' below when running reg-tests with HTX enabled. (without HTX the test passes) Seems this commit made it return different results:

http/2 server-push support

2019-02-26 Thread Patrick Hemmer
Now that we have h2 support on frontends, backends, trailers, etc, I'm hoping that server side server-push is somewhere on the roadmap. By "server side" I mean not this middleware based server-push methodology frequently used where a "Link" header is converted to a server push. But instead where

Re: [Potential Spoof] [PATCH] BUG/MAJOR: fd/threads, task/threads: ensure all spin locks are unlocked

2019-02-26 Thread Richard Russo
Olivier, I've been testing from master yesterday and today (with a reload every 60 second loop). As with any multithreaded testing, it's much easier to conclude something crashes than that it doesn't crash, but I didn't see any crashes or deadlocks in my test runs. So, I think it's good.

Re: [RFC PATCH] MEDIUM: compression: Add support for brotli compression

2019-02-26 Thread Tim Düsterhus
Willy, Am 13.02.19 um 17:57 schrieb Tim Duesterhus: > *snip* Are you able to give some (first, basic) feedback on this patch already? Best regards Tim Düsterhus

Re: [PATCH 1/2] CLEANUP: http: Remove unreachable code in parse_http_req_capture

2019-02-26 Thread Willy Tarreau
both applied, thanks Tim. Willy

[PATCH 2/2] CLEANUP: stream: Remove bogus loop in conn_si_send_proxy

2019-02-26 Thread Tim Duesterhus
The if-statement was converted into a while-loop in 7fe45698f58a53dda9182a5970a2ea4bda9f92fe to handle EINTR. This special handling was later replaced in 0a03c0f022faf2773995fc8b9d14256c8a306e5a by conn_sock_send. The while-loop was not changed back and is not unconditionally exited after one

[PATCH 1/2] CLEANUP: http: Remove unreachable code in parse_http_req_capture

2019-02-26 Thread Tim Duesterhus
`len` has already been checked to be strictly positive a few lines above. This unreachable code was introduced in 82bf70dff4eff42397fecfcb9e97a0a7ce721c49. --- src/http_act.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/http_act.c b/src/http_act.c index 4f51d4a2..0346be0c 100644

[ANNOUNCE] haproxy-2.0-dev1

2019-02-26 Thread Willy Tarreau
Hi, HAProxy 2.0-dev1 was released on 2019/02/26. It added 363 new commits after version 1.9.0. Given that things are cooling down and we've addressed a large number of issues, I think it's the right moment to emit a 2.0-dev1 version. This will allow many of us to more confidently upgrade to

Re: High p99 latency with HAProxy 1.9 in http mode compared to 1.8

2019-02-26 Thread Willy Tarreau
On Mon, Feb 25, 2019 at 11:11:08AM -0800, Ashwin Neerabail wrote: > Any ideas on this ? Seeing issues with HAProxy 1.9 performance with > connection pooling turned on. No idea for now, we really need to find a way to accurately measure this in order to spot when the problem happens. It could be

Re: http2-issue with http2 enabled on frontend and on backend

2019-02-26 Thread Willy Tarreau
> > 3) When I enable "http2_push_preload on;" on the nginx (because nginx wants > > to push images etc.) then the website is not working and I have the > > following entries in the haproxy-log: > > Feb 26 12:04:50 localhost haproxy[31691]: srcip=1.1.1.1:56146 > >

Re: http2-issue with http2 enabled on frontend and on backend

2019-02-26 Thread Willy Tarreau
On Tue, Feb 26, 2019 at 12:37:11PM +0100, Tom wrote: > Hi Jérôme > > Many thanks for your hint. This solved the initial problem. But there are > other issues regarding http2: > > 1) > When I enable "errorfile 503 /etc/haproxy/503.html" in the defaults-section, > then haproxy comes not up and

Re: http2-issue with http2 enabled on frontend and on backend

2019-02-26 Thread Christopher Faulet
Le 26/02/2019 à 14:12, Tim Düsterhus a écrit : Tom, Am 26.02.19 um 13:10 schrieb Tom: 2) When I enable removing the server-header from the backend with "rspidel ^Server:.*", then the haproxy-workers are terminating with Segmentation fault and the website via haproxy is not working: Does

Re: http2-issue with http2 enabled on frontend and on backend

2019-02-26 Thread Tom
Hi Tim Of course (haproxy-1.9.4): --- schnipp --- global log 127.0.0.1 local1 info chroot /home/haproxy user haproxy group haproxy master-worker ssl-server-verify none tune.ssl.default-dh-param 2048

Re: Wrong sha256 checksum for HAProxy 1.8 and 1.9?

2019-02-26 Thread Tim Düsterhus
Cyril, Am 26.02.19 um 14:10 schrieb Tim Düsterhus: > Am 26.02.19 um 13:29 schrieb Cyril Bonté: >> Well, this is more a browser bug than a misconfiguration. But for now, the >> configuration requires a workaround to not use "Content-Encoding: gzip" for >> gzipped files. >>

Re: Wrong sha256 checksum for HAProxy 1.8 and 1.9?

2019-02-26 Thread Willy Tarreau
Hi all, On Tue, Feb 26, 2019 at 01:29:54PM +0100, Cyril Bonté wrote: > > De: "Tim Düsterhus" > > À: "Cyril Bonté" , "Willy Tarreau" , > > "Kevin Mao" > > Cc: haproxy@formilux.org > > Envoyé: Mardi 26 Février 2019 12:12:33 > > Objet: Re: Wrong sha256 checksum for HAProxy 1.8 and 1.9? > > > >

Re: http2-issue with http2 enabled on frontend and on backend

2019-02-26 Thread Tim Düsterhus
Tom, Am 26.02.19 um 13:10 schrieb Tom: >>> 2) >>> When I enable removing the server-header from the backend with >>> "rspidel ^Server:.*", then the haproxy-workers are terminating with >>> Segmentation fault and the website via haproxy is not working: >> >> Does http-response del-header Server

Re: Wrong sha256 checksum for HAProxy 1.8 and 1.9?

2019-02-26 Thread Tim Düsterhus
Cyril, Am 26.02.19 um 13:29 schrieb Cyril Bonté: > Well, this is more a browser bug than a misconfiguration. But for now, the > configuration requires a workaround to not use "Content-Encoding: gzip" for > gzipped files. > https://bugzilla.mozilla.org/show_bug.cgi?id=610679 >

Re: Wrong sha256 checksum for HAProxy 1.8 and 1.9?

2019-02-26 Thread Cyril Bonté
> De: "Tim Düsterhus" > À: "Cyril Bonté" , "Willy Tarreau" , "Kevin > Mao" > Cc: haproxy@formilux.org > Envoyé: Mardi 26 Février 2019 12:12:33 > Objet: Re: Wrong sha256 checksum for HAProxy 1.8 and 1.9? > > Willy, > Cyril, > > Am 26.02.19 um 10:52 schrieb Cyril Bonté: > > Interesting, in fact

Re: http2-issue with http2 enabled on frontend and on backend

2019-02-26 Thread Tom
On 26.02.19 12:57, Jarno Huuskonen wrote: Hi, On Tue, Feb 26, Tom wrote: 1) When I enable "errorfile 503 /etc/haproxy/503.html" in the defaults-section, then haproxy comes not up and logs the following error: "Unable to convert message in HTX for HTTP return code 503." Does it work if you

Re: http2-issue with http2 enabled on frontend and on backend

2019-02-26 Thread Jarno Huuskonen
Hi, On Tue, Feb 26, Tom wrote: > 1) > When I enable "errorfile 503 /etc/haproxy/503.html" in the > defaults-section, then haproxy comes not up and logs the following > error: > "Unable to convert message in HTX for HTTP return code 503." Does it work if you move the errorfile 503 to

Re: http2-issue with http2 enabled on frontend and on backend

2019-02-26 Thread Tom
Hi Jérôme Many thanks for your hint. This solved the initial problem. But there are other issues regarding http2: 1) When I enable "errorfile 503 /etc/haproxy/503.html" in the defaults-section, then haproxy comes not up and logs the following error: "Unable to convert message in HTX for

Re: Wrong sha256 checksum for HAProxy 1.8 and 1.9?

2019-02-26 Thread Tim Düsterhus
Willy, Cyril, Am 26.02.19 um 10:52 schrieb Cyril Bonté: > Interesting, in fact the downloaded file is a gzip of the tar.gz itself. > Yes. This appears to be a misconfiguration in either HAProxy or Apache. Probably Apache, because the `.tar.gz` is delivered with Content-Type application/x-tar

Re: Wrong sha256 checksum for HAProxy 1.8 and 1.9?

2019-02-26 Thread Leonhard Wimmer
Hi, I can confirm the issue with haproxy-1.9.4.tar.gz and Firefox 65.0 on Linux (Ubuntu 18.10, latest Updates). For me the files differ already at byte 5: Correct: 1f 8b 08 00 70 e6 5a 5c 02 03 ec 5c 5b 73 e2 48 |p.Z\...\[s.H| 0010 96 ae 67 ff 0a 6d f5 43 55 75 18 6c a8 b2

Re: http2-issue with http2 enabled on frontend and on backend

2019-02-26 Thread Jerome Magnin
On Tue, Feb 26, 2019 at 11:19:12AM +0100, Tom wrote: > Hi list > > When I enable health-checks on the backend, then the backend comes not up, > because of "Layer7 invalid response". The backend is a simple nginx with > http2 enabled. As I mentioned: When I directly talk to the backend with >

Re: http2-issue with http2 enabled on frontend and on backend

2019-02-26 Thread Jerome Magnin
On Tue, Feb 26, 2019 at 11:19:12AM +0100, Tom wrote: > Hi list > > I'm using haproxy-1.9.4 and trying to enable http2 in frontend and on one > backend server (nginx with http2 enabled). I'm always receiving a http/502 > from haproxy. I'm successfully able to directly talk to the backend with >

http2-issue with http2 enabled on frontend and on backend

2019-02-26 Thread Tom
Hi list I'm using haproxy-1.9.4 and trying to enable http2 in frontend and on one backend server (nginx with http2 enabled). I'm always receiving a http/502 from haproxy. I'm successfully able to directly talk to the backend with http2, but not via haproxy. The haproxy-log looks like this

Re: Wrong sha256 checksum for HAProxy 1.8 and 1.9?

2019-02-26 Thread Cyril Bonté
Hi again, > De: "Cyril Bonté" > À: "Willy Tarreau" , "Kevin Mao" > Cc: haproxy@formilux.org > Envoyé: Mardi 26 Février 2019 09:39:08 > Objet: Re: Wrong sha256 checksum for HAProxy 1.8 and 1.9? > > Using firefox, I'm observing the same issue. > Most of the time, the downloaded file is missing

Re: Wrong sha256 checksum for HAProxy 1.8 and 1.9?

2019-02-26 Thread Cyril Bonté
Hi Willy, Le 26/02/2019 à 07:38, Willy Tarreau a écrit : Hi Kevin, On Tue, Feb 26, 2019 at 06:27:30AM +, Kevin Mao wrote: Hi haproxy@, It seems like the sha256 checksum's are wrong for the latest 1.8 and 1.9 HAProxy versions, Can you please confirm?