Re: v1.9.6+HEAD: segfault in h1_skip_chunk_crlf

2019-04-19 Thread Christopher Faulet
Le 19/04/2019 à 11:40, William Dauchy a écrit : Hi, On Fri, Apr 19, 2019 at 6:26 AM Willy Tarreau wrote: Good catch but in my opinion we should instead fix the called function (h1_skip_chunk_crlf). h1_skip_chunk_size() properly deals with the case where start==stop, but h1_skip_chunk_crlf()

Re: v1.9.6+HEAD: segfault in h1_skip_chunk_crlf

2019-04-18 Thread Christopher Faulet
/haproxy.c:2648 #8 run_thread_poll_loop (data=) at src/haproxy.c:2713 #9 0x7f73bbae6dd5 in start_thread () from /lib64/libpthread.so.0 #10 0x7f73ba81fead in clone () from /lib64/libc.so.6 It seems related to the last commits from Christopher Faulet, maybe around this commit: http

Re: segfault using cache with 1.9.4

2019-04-17 Thread Christopher Faulet
a bug in all HTTP sample fetches. So, your segfault is not related to the cache but to the way HTTP sample fetches work. I pushed fixes in the upstream and backported them in HAProxy-1.9. It should be ok now. Thanks ! -- Christopher Faulet

Re: haproxy1.9, SPOA: too many open files

2019-04-09 Thread Christopher Faulet
ion before investigating. Could you provide more information on the way you perform your benchmark. I also need to take a look on your HAProxy and spoe configurations. And finally, let me known how you start the agent. Regards, -- Christopher Faulet

Re: Strange "content-length" with http-use-htx

2019-03-27 Thread Christopher Faulet
such case but there is no reason to skip it. -- Christopher Faulet >From 07e02acaaeb104c9608cb93e1d988bae75ae16be Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Wed, 27 Mar 2019 15:44:56 +0100 Subject: [PATCH] BUG/MINOR: mux-h1: Only skip invalid C-L headers on output When an HTTP req

Re: Strange "content-length" with http-use-htx

2019-03-27 Thread Christopher Faulet
t in HTTP/1.1 on the server side. If not, it is a bug. Regards, -- Christopher Faulet

Re: Chained http -> http frontends: http/2 error 400 vs http/1.1 error 502

2019-03-26 Thread Christopher Faulet
bug from curl. So everything seems to work as expected from the HAproxy point of view. -- Christopher Faulet

Re: Chained http -> http frontends: http/2 error 400 vs http/1.1 error 502

2019-03-01 Thread Christopher Faulet
a quick check, it is a bug. Instead of catching an error from the server side, we handle it as an abort from the client. I have to investigate a bit more because abortonclose seems to be broken too. And when HTX is enable, the H1 is buggy too. -- Christopher Faulet

Re: regtest, response lenght check failure for /reg-tests/http-capture/h00000.vtc with HTX enabled, using 2.0-dev1

2019-03-01 Thread Christopher Faulet
to have more accurate logs. Some things that should be move in the mux are still done at the channel level for now. Not only about logs. However, while the legacy HTTP is still there, it is a bit hard to start this refactoring. BTW, I missed to update the reg-test. I will do so. Thanks, -- Christopher Faulet

Re: http2-issue with http2 enabled on frontend and on backend

2019-02-26 Thread Christopher Faulet
configuration that reproduces the segmentation fault for us to reproduce? Hi, I agree. I found the bug. A fix was merged and backported in 1.9. Thanks, -- Christopher Faulet

Re: http-use-htx and IIS

2019-02-13 Thread Christopher Faulet
rch. Hi, Just for the record. I worked on this issue with Marco off-list. And a fix was merged and backported to 1.9. For details, see git.haproxy.org/?p=haproxy.git;a=commit;h=6cdaf2ad -- Christopher Faulet

Re: haproxy segfault

2019-02-13 Thread Christopher Faulet
confirm, it is a crash during the allocation of s->unique_id. The commit 451c5a88 fixes this bug. -- Christopher Faulet

Re: error in haproxy 1.9 using txn.req:send in lua

2019-02-13 Thread Christopher Faulet
fortunately, for now, there is no way to rewrite the HTTP messages in Lua. -- Christopher Faulet

Re: haproxy segfault

2019-02-12 Thread Christopher Faulet
oxy.org/?p=haproxy-1.9.git;a=commit;h=451c5a88 Maybe you've hit this bug. -- Christopher Faulet

Re: [PATCH] CONTRIB: contrib/prometheus-exporter: Add a Prometheus exporter for HAProxy

2019-02-11 Thread Christopher Faulet
Le 09/02/2019 à 10:47, Aleksandar Lazic a écrit : Hi Christopher. Am 07-02-2019 22:09, schrieb Christopher Faulet: Hi, This patch adds a new component in contrib. It is a Prometheus exporter for HAProxy. [snipp] More details in the README. I'm not especially a Prometheus expert. And I

[PATCH] CONTRIB: contrib/prometheus-exporter: Add a Prometheus exporter for HAProxy

2019-02-07 Thread Christopher Faulet
estions, he is welcome. Thanks -- Christopher >From d7e241786cc7056f28dad8bdd8fd72171c7a4e78 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Thu, 7 Feb 2019 15:38:42 +0100 Subject: [PATCH] CONTRIB: contrib/prometheus-exporter: Add a Prometheus exporter for HAProxy It has been developped as a service app

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-21 Thread Christopher Faulet
;) Thanks in advance, PiBa-NL (Pieter) Hi Pieter, About the timing issue, could you try the following patch please ? With it, I can run the regtest about email alerts without any error. Thanks, -- Christopher Faulet >From 8b7822ad2c7d9e4f9fe6b19f57d1d1ff01336a70 Mon Sep 17 00:00:00 2001 F

Re: HTX & tune.maxrewrite [1.9.2]

2019-01-21 Thread Christopher Faulet
? Thanks, -- Christopher Faulet >From ccea4c140c8958507e8c91f14354e986eb8aabe6 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Mon, 21 Jan 2019 11:24:38 +0100 Subject: [PATCH 1/3] BUG/MINOR: proto-htx: Return an error if all headers cannot be receied at once When an HTX stream is wait

Re: HTX & tune.maxrewrite [1.9.2]

2019-01-18 Thread Christopher Faulet
multiplexer is not aware of the buffer reserve. So tweaking tune.maxrewrite won't have any effect. I'll work on a fix. Thanks, -- Christopher Faulet

Re: stats webpage crash, htx and scope filter, [PATCH] REGTEST is included

2019-01-17 Thread Christopher Faulet
Le 16/01/2019 à 22:25, Willy Tarreau a écrit : Hi Pieter, On Wed, Jan 16, 2019 at 08:44:58PM +0100, PiBa-NL wrote: Hi Willy, Christopher, Op 16-1-2019 om 17:32 schreef Willy Tarreau: On Wed, Jan 16, 2019 at 02:28:56PM +0100, Christopher Faulet wrote: here is a new patch, again. Willy, I hope

Re: stats webpage crash, htx and scope filter, [PATCH] REGTEST is included

2019-01-16 Thread Christopher Faulet
Le 15/01/2019 à 21:07, PiBa-NL a écrit : Hi Christopher, Op 15-1-2019 om 10:48 schreef Christopher Faulet: Le 14/01/2019 à 21:53, PiBa-NL a écrit : Hi Christopher, Op 14-1-2019 om 11:17 schreef Christopher Faulet: Le 12/01/2019 à 23:23, PiBa-NL a écrit : Hi List, I've configured haproxy

Re: stats webpage crash, htx and scope filter, [PATCH] REGTEST is included

2019-01-15 Thread Christopher Faulet
Le 14/01/2019 à 21:53, PiBa-NL a écrit : Hi Christopher, Op 14-1-2019 om 11:17 schreef Christopher Faulet: Le 12/01/2019 à 23:23, PiBa-NL a écrit : Hi List, I've configured haproxy with htx and when i try to filter the stats webpage. Sending this request: "GET /?;csv;scope=b1" to

Re: stats webpage crash, htx and scope filter, [PATCH] REGTEST is included

2019-01-14 Thread Christopher Faulet
t the HTX. If it's ok for you, I'll also merge your regtest. Thanks -- Christopher Faulet >From d09c87cf3d261b42f02671b3ddf2cbc36b7e1916 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Mon, 14 Jan 2019 11:07:34 +0100 Subject: [PATCH] BUG/MEDIUM: stats: Get the rigth scope pointer de

Re: [RFC PATCH] couple of reg-tests

2019-01-14 Thread Christopher Faulet
! -- Christopher Faulet

Re: stats webpage crash, htx and scope filter, [PATCH] REGTEST is included

2019-01-14 Thread Christopher Faulet
meone take a look? Thanks in advance. Hi Pieter, I'm on it. Thanks -- Christopher Faulet

Re: [PATCH] REGTEST: filters: add compression test

2019-01-09 Thread Christopher Faulet
e merged is attached to this mail*. Thank a lot Pieter. Thanks Fred and Pieter, now merged. I've just updated the patch to add the list of required options in the VTC file. -- Christopher Faulet

Re: [PATCH] REGTEST: filters: add compression test

2019-01-09 Thread Christopher Faulet
e is the patch to fix the bug. It is already merged. Thanks, -- Christopher Faulet >From 4893977665049d159d76077e7276a9e98f54c317 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Wed, 9 Jan 2019 12:16:58 +0100 Subject: [PATCH] BUG/MINOR: lua/htx: Respect the reserve when data are send fr

Re: [PATCH 1/1] REGTEST: Add some informatoin to test results.

2019-01-08 Thread Christopher Faulet
"${TESTDIR}" ]; then cat <<- EOF | tee -a "$TESTDIR/failedtests.log" $(echo "## $(cat "$i/INFO") ##") $(echo "## test results in: \"$i\"") -$(grep -- ^ "$i/LOG") +$(grep -E -- "^(|\*diag)" "$i/LOG") EOF done' sh {} + fi Thanks, now merged! -- Christopher Faulet

Re: compression in defaults happens twice with 1.9.0

2019-01-08 Thread Christopher Faulet
Le 07/01/2019 à 22:08, PiBa-NL a écrit : Hi Christopher, Op 7-1-2019 om 16:32 schreef Christopher Faulet: Le 06/01/2019 à 16:22, PiBa-NL a écrit : Hi List, Using both 1.9.0 and 2.0-dev0-909b9d8 compression happens twice when configured in defaults. This was noticed by user walle303 on IRC

Re: compression in defaults happens twice with 1.9.0

2019-01-07 Thread Christopher Faulet
the issue. Can someone take a look, thanks in advance. Hi Pieter, Here is the patch that should fix this issue. Could you confirm please ? Thanks -- Christopher Faulet >From ff3c04e40ab0f4a7176ef25835b40f0d068150cf Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Mon, 7 Jan 2019 14:41

Re: htx with compression issue, "Gunzip error: Body lacks gzip magics"

2019-01-02 Thread Christopher Faulet
hanks in advance. Hi Pieter, In fact, It is not a bug related to the compression. But a pure HTX one, about the defragmentation when we need space to store data. Here is a patch. It fixes the problem for me. Willy, if it is ok for you, I can merge it in upstream and backport it in 1.9.

Re: d94f877 causes timeout in a basic connection test 1.9-dev11_d94f877

2018-12-18 Thread Christopher Faulet
) #    top  TEST ./PB-TEST/basic_connection.vtc FAILED (120.236) signal=9 Please can you take a look :) Thanks in advance. Hi Pieter, I've run your reg-test and everything works find for me. But I'll try to do more test to reproduce your problem. Thanks, -- Christopher Faulet

Re: corruption of data with compression in 1.9-dev10

2018-12-17 Thread Christopher Faulet
Le 12/12/2018 à 20:43, PiBa-NL a écrit : Hi Christopher, Op 12-12-2018 om 13:49 schreef Christopher Faulet: Le 12/12/2018 à 12:07, Pi Ba a écrit : Found the issue on the 10th (I think commit 56b0348).. so yesterday's commit isn't the (only) problem.. tested with commit 0007d0a the issue also

Re: corruption of data with compression in 1.9-dev10

2018-12-13 Thread Christopher Faulet
Le 12/12/2018 à 20:43, PiBa-NL a écrit : Hi Christopher, Op 12-12-2018 om 13:49 schreef Christopher Faulet: Le 12/12/2018 à 12:07, Pi Ba a écrit : Found the issue on the 10th (I think commit 56b0348).. so yesterday's commit isn't the (only) problem.. tested with commit 0007d0a the issue also

Re: corruption of data with compression in 1.9-dev10

2018-12-12 Thread Christopher Faulet
Le 12/12/2018 à 12:07, Pi Ba a écrit : Found the issue on the 10th (I think commit 56b0348).. so yesterday's commit isn't the (only) problem.. tested with commit 0007d0a the issue also happens. Reverting only below mentioned commit I can't easily do atm. I'll check more closely this evening.

Re: corruption of data with compression in 1.9-dev10

2018-12-12 Thread Christopher Faulet
Le 12/12/2018 à 10:52, Christopher Faulet a écrit : Le 12/12/2018 à 02:08, PiBa-NL a écrit : Hi List, Didn't have time yet to bisect when it went wrong. But attached testfile produces the following output after 3 curl requests at different speeds, this seems to trigger a problem as the hash

Re: corruption of data with compression in 1.9-dev10

2018-12-12 Thread Christopher Faulet
Le 12/12/2018 à 02:08, PiBa-NL a écrit : Hi List, Didn't have time yet to bisect when it went wrong. But attached testfile produces the following output after 3 curl requests at different speeds, this seems to trigger a problem as the hash of the downloaded content is nolonger the same as it

Re: [ANNOUNCE] haproxy-1.9-dev9 : the last mile

2018-12-03 Thread Christopher Faulet
HTTP/1.1 505 as h2 is not enabled on the backend (and being plaintext port 80 with no ALPN negotiation it is also unlikely). Hi Lukas, This is a known bug. But because a lack of time, I did not send my patches. Could you confirm they fix your bug ? Thanks ! -- Christopher Faulet >F

Re: regtest failure for /cache/h00000.vtc, config parsing fails? after commit 7805e2b

2018-12-02 Thread Christopher Faulet
) Argh! You're right. I was in hurry to finish all my work on the HTX. Here is a fix. Thanks, -- Christopher Faulet >From 641ebec149de991052a707aa00d31d97ddb367ff Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Sun, 2 Dec 2018 09:37:38 +0100 Subject: [PATCH] BUG/MINOR: cfgparse:

Re: 1.7.11 with gzip compression serves incomplete files

2018-11-30 Thread Christopher Faulet
of a close and not all chunks are received ? Or the response is correct from the HTTP point of view, but the file is truncated once uncompressed ? Sorry to ask you so much work but I'm on a dead end for now. And this kind of bug a still pretty hard to reproduce. :) Thanks ! -- Christopher

Re: h1 buffer / confirmation

2018-11-20 Thread Christopher Faulet
Le 20/11/2018 à 17:06, David CARLIER a écrit : Hi Christopher (I think you maintain it), Just to confirm into src/h1_mux.c, line 131 you meant h1c->flags & *(H1C_F_CS_ERROR|H1C_F_CS_SHUTW*) instead ? Argh, Right ! Thanks for report. I'll fix that. -- Christopher Faulet

Re: haproxy segfaults when clearing the input buffer via LUA

2018-11-20 Thread Christopher Faulet
Le 17/11/2018 à 20:42, Willy Tarreau a écrit : Hi Moemen, On Wed, Nov 14, 2018 at 04:07:42PM +0100, Moemen MHEDHBI wrote: Hi, I was playing with LUA, to configure a traffic mirroring behavior. Basically I wanted HAProxy to send the http response of a request to a 3rd party before sending the

Re: varnishtest with H2>HTX>H1(keep-alive)

2018-11-20 Thread Christopher Faulet
is not yet compatible with the HTX for now. So you should never use both in same time. However, this configuration error should be detected during the configuration parsing, to avoid runtime errors. Here is a patch to do so. I'll merge it. Thanks -- Christopher Faulet >F

Re: 1.9b6 301 redirect anomaly

2018-11-15 Thread Christopher Faulet
, A bug was introduced in the commit 6b952c810 in the way the request's uri is captured. So it exists since the 1.9-dev2. Could you test the attached patch to confirm the fix ? Thanks ! -- Christopher Faulet >From 40c8c8bdbb73b41911fcf7e8fd2d7c9ac2d787e2 Mon Sep 17 00:00:00 2001 From: Christop

Re: [PATCH] MINOR: generate-certificates for BoringSSL

2018-10-08 Thread Christopher Faulet
Le 03/10/2018 à 12:52, Emmanuel Hocdet a écrit : Hi, For generate-certificates, X509V3_EXT_conf is used but it's an (very) old API call: X509V3_EXT_nconf must be preferred. Openssl compatibility is ok because it's inside #ifdef SSL_CTRL_SET_TLSEXT_HOSTNAME, introduce 5 years after

Re: [PATCH] MINOR: generate-certificates for BoringSSL

2018-10-08 Thread Christopher Faulet
Le 03/10/2018 à 12:52, Emmanuel Hocdet a écrit : Hi, For generate-certificates, X509V3_EXT_conf is used but it's an (very) old API call: X509V3_EXT_nconf must be preferred. Openssl compatibility is ok because it's inside #ifdef SSL_CTRL_SET_TLSEXT_HOSTNAME, introduce 5 years after

Re: haproxy 1.8.12 / 1.9- 20180623 / stopping process hangs with threads (100% cpu) on -sf reload / FreeBSD

2018-07-20 Thread Christopher Faulet
Le 20/07/2018 à 10:38, Willy Tarreau a écrit : On Fri, Jul 20, 2018 at 10:27:42AM +0200, Christopher Faulet wrote: In thread_sync_barrier, we exit when all threads have set their own bit in the barrier mask. It is done by comparing it to all_threads_mask. But we must not use a simple equality

[PATCH] BUG/MINOR: http: Set brackets for the unlikely macro at the right place

2018-07-20 Thread Christopher Faulet
Hi Willy, Here is a little patch to fix brackets place of the unlikely macro in http code. It must be backported in 1.8. -- Christopher Faulet >From fc53818025c8681c800e807960af2a6859006014 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Fri, 20 Jul 2018 09:54:26 +0200 Subj

[PATCH] BUG/MINOR: build: Fix compilation with debug mode enabled

2018-07-20 Thread Christopher Faulet
Hi Willy, Here is a patch to fix the compilation of HAProxy with the debug mode enabled. Some debug messages were still using the old buffers api. -- Christopher Faulet >From deb61c7822acbfcc7fe0ff611eee51fd57773e72 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Fri, 20 Jul 2018

Re: haproxy 1.8.12 / 1.9- 20180623 / stopping process hangs with threads (100% cpu) on -sf reload / FreeBSD

2018-07-20 Thread Christopher Faulet
Le 17/07/2018 à 19:39, PiBa-NL a écrit : Hi Christopher, Op 17-7-2018 om 10:09 schreef Christopher Faulet: Could you try to revert the following commit please ?  * ba86c6c25 MINOR: threads: Be sure to remove threads from all_threads_mask on exit Without this specific commit the termination

Re: haproxy 1.8.12 / 1.9- 20180623 / stopping process hangs with threads (100% cpu) on -sf reload / FreeBSD

2018-07-17 Thread Christopher Faulet
, -- Christopher Faulet

Re: [PATCH] BUG/MINOR: thread: log: Log buffers allocated twice by main, thread.

2018-07-11 Thread Christopher Faulet
). Note that only the main thread will do the first allocation. The others will only do the second one because they are created after the configuration parsing. -- Christopher Faulet

Re: remaining process after (seamless) reload

2018-06-22 Thread Christopher Faulet
Le 20/06/2018 à 18:29, Willy Tarreau a écrit : On Wed, Jun 20, 2018 at 04:42:58PM +0200, Christopher Faulet wrote: When HAProxy is shutting down, it exits the polling loop when there is no jobs anymore (jobs == 0). When there is no thread, it works pretty well, but when HAProxy is started

Re: remaining process after (seamless) reload

2018-06-20 Thread Christopher Faulet
Le 20/06/2018 à 15:11, William Dauchy a écrit : Hello Christopher, Thank you for the quick answer and the patch. On Wed, Jun 20, 2018 at 11:32 AM Christopher Faulet wrote: Here is a patch to avoid a thread to exit its polling loop while others are waiting in the sync point

Re: remaining process after (seamless) reload

2018-06-20 Thread Christopher Faulet
. It is a theoretical patch because I was not able to reproduce the bug. Could you check if it fixes it please ? Thanks, -- Christopher Faulet >From 3576ecdfe108b07c20173d3d82dce5370e796742 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Wed, 20 Jun 2018 11:05:03 +0200 Subject: [PATCH]

[PATCH] BUG/MINOR: contrib/spoa_example: Don't reset the status code during disconnect

2018-06-04 Thread Christopher Faulet
Hi, Here are 3 small patches to remember the status code when an error is detected by HAProxy and have it in the SPOE logs (e.g. an unsupported version). Thanks, -- Christopher Faulet >From b84eeae6f11d856297ae433eedbda538acc6f211 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date:

[PATCH] MAJOR: spoe: upgrade the SPOP version to 2.0 and remove the support for 1.0

2018-06-04 Thread Christopher Faulet
Hi, Here is a patch to change the SPOP version. It follows the commit c4dcaff3 ("BUG/MEDIUM: spoe: Flags are not encoded in network order") in order to make sure no incompatible agent will be used with HAProxy. To do so, the SPOP 1.0 is no more supported. Thanks, -- Christopher Fa

Re: haproxy=1.8.5 stuck in thread syncing

2018-05-30 Thread Christopher Faulet
on the extent of the changes. -- Christopher Faulet

Re: 100% cpu using resolvers with haproxy v1.8.9

2018-05-29 Thread Christopher Faulet
right indeed. There's a bug in the pollers revamp that has been done recently. The attached patch should fix it. Thanks for reporting ! Olivier Now merged, thank you! -- Christopher Faulet

Re: SPOE patchs

2018-05-18 Thread Christopher Faulet
Le 18/05/2018 à 14:53, Christopher Faulet a écrit : Le 18/05/2018 à 12:38, Thierry FOURNIER a écrit : Hi, In attachment two patches for SPOE. The first fix an error message, and the second fix a mistake in the protocol. Thanks Thierry for these patches. Here are fixes for the SPOAs

Re: SPOE patchs

2018-05-18 Thread Christopher Faulet
Le 18/05/2018 à 12:38, Thierry FOURNIER a écrit : Hi, In attachment two patches for SPOE. The first fix an error message, and the second fix a mistake in the protocol. Thanks Thierry for these patches. Here are fixes for the SPOAs modsecurity and mod_defender. -- Christopher Faulet >F

[PATCH] BUG/MEDIUM: threads: Fix the sync point for more than 32 threads

2018-05-02 Thread Christopher Faulet
Hi Willy, Here is a patch to fix the sync point from more than 32 threads. It is an obvious bug once found. But I had a hard time debugging it :) Thanks, -- Christopher Faulet >From 49fe27fda17418b9d8f62295d8f7b066bd2b57b4 Mon Sep 17 00:00:00 2001 From: Christopher Faulet <cfau...@hapro

[PATCH] BUG/MINOR: checks: Fix check->health computation for flapping, servers

2018-05-02 Thread Christopher Faulet
Hi, Here is a patch to fix an old bug in health-checks. As stated in the commit message, it must be backported to HAProxy 1.5 and newer. Thanks, -- Christopher Faulet >From 913d6d9adda3420b79b4eadb1c4b847519dc88d9 Mon Sep 17 00:00:00 2001 From: Christopher Faulet <cfau...@haproxy.com

[ANNOUNCE] haproxy-1.7.11

2018-04-30 Thread Christopher Faulet
NUP: ssl: Remove a duplicated #include BUG/MINOR: cli: Fix a typo in the 'set rate-limit' usage Baptiste Assmann (2): BUG/MEDIUM: tcp-check: single connect rule can't detect DOWN servers BUG/MINOR: tcp-check: use the server's service port as a fallback Christopher Faulet (5): BUG/ME

[PATCH] BUG/MINOR: lua/threads: Make lua's tasks sticky to the current thread

2018-04-26 Thread Christopher Faulet
Willy, Here is a patch to fix a bug recently reported by Pieter in the lua part (in the thread ".1.9dev LUA core.tcp() cannot be used from different threads"). Thanks, -- Christopher Faulet >From b38e9bdf727073a6063f1c56f173a247969c6f9e Mon Sep 17 00:00:00 2001 From: Christopher

Re: 1.9dev LUA core.tcp() cannot be used from different threads

2018-04-26 Thread Christopher Faulet
Le 26/04/2018 à 12:01, Thierry Fournier a écrit : On 26 Apr 2018, at 11:49, Christopher Faulet <cfau...@haproxy.com> wrote: Le 25/04/2018 à 20:51, PiBa-NL a écrit : Hi Christopher, Thierry, Op 25-4-2018 om 11:30 schreef Christopher Faulet: Oh, these tasks can be created before the t

Re: 1.9dev LUA core.tcp() cannot be used from different threads

2018-04-26 Thread Christopher Faulet
Le 25/04/2018 à 20:51, PiBa-NL a écrit : Hi Christopher, Thierry, Op 25-4-2018 om 11:30 schreef Christopher Faulet: Oh, these tasks can be created before the threads creation... Ok, so maybe the right way to fix the bug is to registered these tasks without specific affinity and set

Re: 1.9dev LUA core.tcp() cannot be used from different threads

2018-04-25 Thread Christopher Faulet
ks are woken up. Here is an updated (and untested) patch. Pieter, could you check it please ? Thierry, is there any way to create cosockets and applets from outside a lua's task and then manipulate them in the task's context ? -- Christopher Faulet >From 2996582f5c7d7878767b5972621e0fb0badc

Re: 1.9dev LUA core.tcp() cannot be used from different threads

2018-04-25 Thread Christopher Faulet
ks context, it will be a problem. Regards, -- Christopher Faulet >From b7fc496e5b5cadbb9a59f598bd9077ca466f3ddb Mon Sep 17 00:00:00 2001 From: Christopher Faulet <cfau...@haproxy.com> Date: Wed, 25 Apr 2018 10:34:45 +0200 Subject: [PATCH] BUG/MINOR: lua/threads: Make tasks regis

[PATCH] BUG/MINOR: http: Return an error in proxy mode when url2sa fails

2018-04-16 Thread Christopher Faulet
hes, HAProxy always return an error 400 in this case. -- Christopher Faulet >From d1e5d8cb24ad0e71706cf5d4472142a4e048a7f1 Mon Sep 17 00:00:00 2001 From: Christopher Faulet <cfau...@haproxy.com> Date: Fri, 13 Apr 2018 15:53:12 +0200 Subject: [PATCH] BUG/MINOR: http: Return an error in proxy mo

Re: Segfault in haproxy v1.8 with Lua

2018-04-13 Thread Christopher Faulet
at all. And unfortunately, to rewrite the entire response, the current filter API will not be your friend. But, definitely, this cannot be achieved using Lua. HAProxy was not designed to do HTTP messages rewriting. -- Christopher Faulet

Re: Segfault in haproxy v1.8 with Lua

2018-04-12 Thread Christopher Faulet
. On the other hand, if you just need to generate a custom response on some criteria of the request, you can use a Lua applet. -- Christopher Faulet

Re: Segfault in haproxy v1.8 with Lua

2018-04-12 Thread Christopher Faulet
scribe what you try to do. There is probably another way to achieve it. I hope so, because it will never work this way. -- Christopher Faulet

Re: Segfault in haproxy v1.8 with Lua

2018-04-11 Thread Christopher Faulet
example. Could you provide the output of "haproxy -vv" and the full backtrace of your segfault ? Regards, -- Christopher Faulet

Re: [PATCH] BUG/MEDIUM: threads: Fix the max/min calculation because of name clashes

2018-04-10 Thread Christopher Faulet
Le 09/04/2018 à 11:52, Christopher Faulet a écrit : Hi, This patch fixes a bug affecting HAProxy compiled with gcc < 4.7 (with threads). It must be merged in 1.8. Sorry, I sent the patch I used for HAProxy 1.8. Here is the right patch, for the upstream. But good news for you Wi

[PATCH] BUG/MEDIUM: threads: Fix the max/min calculation because of name clashes

2018-04-09 Thread Christopher Faulet
Hi, This patch fixes a bug affecting HAProxy compiled with gcc < 4.7 (with threads). It must be merged in 1.8. Thanks, -- Christopher Faulet >From 12456b597dbfe231ba5ea33457676ea59b505ed5 Mon Sep 17 00:00:00 2001 From: Christopher Faulet <cfau...@haproxy.com> Date: Fri, 6 Apr 2

Re: patch (cleanup unused labels)

2018-03-29 Thread Christopher Faulet
Le 29/03/2018 à 12:11, Илья Шипицин a écrit : please review the patch attached Hi, These labels must not be removed, they are used in calls to the macro EAT_AND_JUMP_OR_RETURN. -- Christopher Faulet

Re: haproxy=1.8.5 stuck in thread syncing

2018-03-29 Thread Christopher Faulet
Christopher Faulet <cfau...@haproxy.com <mailto:cfau...@haproxy.com>>: Le 28/03/2018 à 09:36, Максим Куприянов a écrit : Hi! Yesterday one of our haproxies (1.8.5) with nbthread=8 set in its config stuck with 800% CPU usage. Some responses

Re: haproxy=1.8.5 stuck in thread syncing

2018-03-28 Thread Christopher Faulet
%  [.] fwrr_get_next_server Hi, Could you share your configuration please ? It will help to diagnose the problem. In your logs, what is the values of srv_queue and backend_queue fields ? Thanks, -- Christopher Faulet

[PATCH] BUG/MINOR: email-alert: Set the mailer port during alert initialization

2018-03-27 Thread Christopher Faulet
Hi, This patch fixes an issue about email alerts reported by Johan. It must be backported in 1.8. Johan, could you confirm it fixes the bug ? Thanks -- Christopher Faulet >From c3ece0fff609ea2eb47445f331a66cd3ed096ef1 Mon Sep 17 00:00:00 2001 From: Christopher Faulet <cfau...@hapro

Re: email alert not working with 1.8.5

2018-03-27 Thread Christopher Faulet
the commit 2f3a56b4f ("BUG/MINOR: tcp-check: use the server's service port as a fallback"). The server's port is used instead of the mailer's one. I will send a patch to fix this issue. Thanks -- Christopher Faulet

Re: multithreading issuse in haproxy 1.8.5

2018-03-26 Thread Christopher Faulet
m appears. Is there any way to test if the CPU back down when you stop the traffic ? -- Christopher Faulet

Re: patch: fix build when USE_THREAD is not defined

2018-03-24 Thread Christopher Faulet
Le 24/03/2018 à 13:19, Илья Шипицин a écrit : please review attached patch Good catch. But instead of using #ifdef in queue.c, there are macros in hathreads.h. Here is the updated patch. Thanks, -- Christopher Faulet >From fa07c58b33524caa8d059dfd0ed741f4b2eb4637 Mon Sep 17 00:00:00 2

Re: actconn issue

2018-03-23 Thread Christopher Faulet
ith the session, not the stream"). I attached the patch to fix this issue. Willy, could you merge it ? Thanks -- Christopher Faulet >From 2355573a959622d2293c522fe1c49c11da589541 Mon Sep 17 00:00:00 2001 From: Christopher Faulet <cfau...@haproxy.com> Date: Fri, 23 Mar 2018 15:11:55 +01

Re: 100% cpu usage after reload (USR2) with "bind abns@...."

2018-03-16 Thread Christopher Faulet
Le 12/03/2018 à 09:48, Christopher Faulet a écrit : Le 05/03/2018 à 21:06, Dennis Jacobfeuerborn a écrit : Hi, today I started experimenting with the HAProxy 1.8.4 release and ran into a Problem when it comes to reloading the configuration (USR2). I'm running the release tarball via RPM

Re: segfault in haproxy=1.8.4

2018-03-15 Thread Christopher Faulet
Le 15/03/2018 à 15:50, Willy Tarreau a écrit : On Thu, Mar 15, 2018 at 02:49:59PM +0100, Christopher Faulet wrote: When we scan a queue, it is locked. So on your mark, the server queue is already locked. To remove a pendconn from a queue, we also need to have a lock on this queue

Re: segfault in haproxy=1.8.4

2018-03-15 Thread Christopher Faulet
it, nobody can fall on the pendconn by scanning the queue. In fact without locking the queue (server one and/or proxy one), it is unsafe to loop on it. In same way, we must lock the queue to remove a pendconn from it. I will add comments to clarify everything. But, I really think it is thread-safe. -- Christopher Faulet

Re: segfault in haproxy=1.8.4

2018-03-15 Thread Christopher Faulet
Le 15/03/2018 à 07:19, Willy Tarreau a écrit : Hi Christopher, first, thank you for this one, I know how painful it can have been! Hi Willy, Thanks for your support :) On Wed, Mar 14, 2018 at 09:56:19PM +0100, Christopher Faulet wrote: (...) But it is not optimal and in some situations

Re: segfault in haproxy=1.8.4

2018-03-14 Thread Christopher Faulet
Le 07/03/2018 à 09:58, Christopher Faulet a écrit : I found thread-safety bugs about the management of pending connections. It is totally fucked up :) It needs to be entirely reworked. I'm on it. I hope to propose a patch this afternoon. Hi, Sorry for the lag. This issue was definitely harder

Re: 100% cpu usage after reload (USR2) with "bind abns@...."

2018-03-12 Thread Christopher Faulet
http://git.haproxy.org/?p=haproxy.git;a=commitdiff;h=ec9516a6 It was pushed in upstream and will be backported in 1.8. Could you check if it works please ? -- Christopher Faulet

Re: segfault in haproxy=1.8.4

2018-03-07 Thread Christopher Faulet
Le 06/03/2018 à 17:50, Максим Куприянов a écrit : Hi, Willy! If it could be interesting, I got a new core with exactly the same backtrace: Program terminated with signal SIGSEGV, Segmentation fault. #0  0x563f5373bf21 in __pendconn_free (p=0x563f560db0c8) at src/queue.c:296

[PATCH] BUG/MINOR: h2: Set the target of dbuf_wait to h2c

2018-02-26 Thread Christopher Faulet
Hi Willy, Here is a small patch to fix an annoying bug when demux buffer allocation fails in H2. -- Christopher Faulet >From ccf62f1411d64654b6249d28b1f0b89763bbedbb Mon Sep 17 00:00:00 2001 From: Christopher Faulet <cfau...@haproxy.com> Date: Mon, 26 Feb 2018 13:43:38 +0100 Subjec

[PATCH] BUG/MEDIUM: buffer: Fix bi/bo_putblk in the wrapping case

2018-02-26 Thread Christopher Faulet
Faulet >From 5d4575a2f8dcd1d8b75134c0d99178173e0d056e Mon Sep 17 00:00:00 2001 From: Christopher Faulet <cfau...@haproxy.com> Date: Mon, 26 Feb 2018 10:47:03 +0100 Subject: [PATCH 1/2] BUG/MEDIUM: buffer: Fix the wrapping case in bo_putblk When the block of data need to be split t

Re: haproxy 1.8 ssl backend server leads to server session aborts

2018-02-19 Thread Christopher Faulet
-1-8-3/2116/6 I asked him to test the attached patch. But It could be cool to have more feedback on the fix. The bug can easily be reproduced by closing a connection opened with openssl s_client with a control-c. Thanks -- Christopher Faulet >From e0ffb9cd3210ccc3eec96350b0405963746960d0 Mon

Re: Compression issues with http-server-close/httpclose

2018-02-05 Thread Christopher Faulet
server and another one between your client and HAproxy could be very helpful to diagnose the bug. Thanks, -- Christopher Faulet

Re: Bug using no-check in HAProxy 1.8: segfaults

2018-01-25 Thread Christopher Faulet
:1.8 and haproxy:1.8-alpine If I should report this to docker-images and/or Debian instead, please excuse me and let me know. Hi, This is a bug in HAProxy. I attached the patch. Willy, you can merge it. It must be backported in 1.8. Thanks -- Christopher Faulet >F

Re: problem in 1.8 with hosts going out of service

2018-01-25 Thread Christopher Faulet
Le 24/01/2018 à 23:54, Paul Lockaby a écrit : This patch works for me. Thank you! On Jan 24, 2018, at 1:02 PM, Christopher Faulet <cfau...@haproxy.com> wrote: Le 24/01/2018 à 17:21, Paul Lockaby a écrit : Sorry, I know this list is super busy and that there are a number of othe

Re: problem in 1.8 with hosts going out of service

2018-01-24 Thread Christopher Faulet
busy. And you're right to ping us. So, I can confirm the bug. It is a bug on threads, a deadlock, because of a typo. Could you check the attached patch to confirm it fixes your problem ? Thanks, -- Christopher Faulet >From 6436e9d934045c7cd9c41bffa036eb6213ff21ee Mon Sep 17 00:00:00 2001 F

Re: haproxy 1.8 ssl backend server leads to server session aborts

2018-01-17 Thread Christopher Faulet
the client side ? (truncated / good / error ...) -- Christopher Faulet

Re: High load average under 1.8 with multiple draining processes

2018-01-15 Thread Christopher Faulet
ot;show fd" too) ? -- Christopher Faulet

  1   2   3   >